Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --bs-form-check-bg definition #37621

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Fix --bs-form-check-bg definition #37621

merged 1 commit into from
Dec 11, 2022

Conversation

julien-deramond
Copy link
Member

Related issues

Closes #37620

Description

Customizing $input-bg change $*-input-bg values.
The problematic one was $form-check-input-bg that tried to apply escape-svg() on it.
This PR suggests to simply remove unnecessary call to escape-svg() since we're handling colors and not images in this case.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

Testing

  • All use cases depending on $form-check-input-bg still work correctly
  • Modifying $input-bg to #fd0 (for example) doesn't cause anymore any compilation issues

@julien-deramond julien-deramond marked this pull request as ready for review December 10, 2022 10:12
@julien-deramond julien-deramond requested a review from a team as a code owner December 10, 2022 10:12
@mdo mdo merged commit fd3da4e into main Dec 11, 2022
@mdo mdo deleted the main-jd-fix-input-bg-usage branch December 11, 2022 02:06
@mdo
Copy link
Member

mdo commented Dec 11, 2022

Thank you, sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

$input-bg must be a string in latest Bootstrap version
2 participants