Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22847 Migrate ADO pipelines to GHA #3112

Merged
merged 1 commit into from
Sep 6, 2024
Merged

ICU-22847 Migrate ADO pipelines to GHA #3112

merged 1 commit into from
Sep 6, 2024

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Aug 20, 2024 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22847
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

rp9-next added a commit to rp9-next/icu that referenced this pull request Aug 23, 2024
@rp9-next
ICU-22847 Migrate ADO pipelines to GHA
22dedf8 
See unicode-org#3112
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@rp9-next rp9-next marked this pull request as ready for review August 23, 2024 11:24
markusicu
markusicu reviewed Aug 26, 2024
View reviewed changes
.ci-builds/.azure-pipelines-icu4c.yml Outdated Show resolved Hide resolved
.github/workflows/icu4c.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
docs/processes/release/tasks/healthy-code.md Outdated Show resolved Hide resolved
docs/processes/release/tasks/publish/index.md Outdated Show resolved Hide resolved
@nciric
Copy link
Contributor

nciric commented Aug 26, 2024

I see Markus is already reviewing, and Elango is assigned - we don't need to wait for Fredrik's input.

@roubert roubert removed their request for review August 26, 2024 17:30
echeran
echeran reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good.

optional: Would you be able to update the ICU User Guide page on CI? I assume it's mostly removing content. If there's something to add, it could be copy-pasting the info about running exaustive tests from the other Markdown file.

.github/workflows/icu4c.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_merge_ci.yml Show resolved Hide resolved
echeran
echeran reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added suggestions about running exhaustive tests (docs, workflow refactoring for easier maintenance).

.github/workflows/icu_exhaustive_tests.yml Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
.github/workflows/icu_exhaustive_tests.yml Outdated Show resolved Hide resolved
docs/userguide/dev/ci.md Show resolved Hide resolved
echeran
echeran previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work!

@rp9-next rp9-next requested a review from mihnita August 30, 2024 11:28
markusicu
markusicu reviewed Aug 30, 2024
View reviewed changes
docs/processes/release/tasks/healthy-code.md Outdated Show resolved Hide resolved
docs/processes/cldr-icu.md Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/cldr-icu.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/userguide/dev/gitdev.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_exhaustive_tests.yml is different
  • docs/userguide/dev/gitdev.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

rp9-next added a commit to rp9-next/icu that referenced this pull request Sep 3, 2024
@rp9-next
ICU-22847 Migrate ADO pipelines to GHA
3061ca5 
See unicode-org#3112
- Update Docs
- Make exhaustive tests run manually, based on cron for main and post merge for maint
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

rp9-next added a commit to rp9-next/icu that referenced this pull request Sep 5, 2024
@rp9-next
ICU-22847 Migrate ADO pipelines to GHA
ef3de2c 
See unicode-org#3112
- change exhaustive tests to run weekly on main
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

rp9-next added a commit to rp9-next/icu that referenced this pull request Sep 5, 2024
@rp9-next
ICU-22847 Migrate ADO pipelines to GHA
3fe079b 
    See unicode-org#3112
    - Update Docs
    - Make exhaustive tests run manually, based on cron for main and post merge for maint
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/cldr-icu.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@rp9-next
ICU-22847 Migrate ADO pipelines to GHA
ee0c35e 
  See unicode-org#3112
    - Update Docs
    - Make exhaustive tests run manually, based on cron for main and post merge for maint
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rp9-next thank you very much!!

@rp9-next rp9-next merged commit 91ed39f into unicode-org:main Sep 6, 2024
123 checks passed
@rp9-next rp9-next deleted the migrateADO2GHA branch September 6, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roubert roubert roubert left review comments

@markusicu markusicu markusicu approved these changes

@echeran echeran echeran left review comments

@mihnita mihnita Awaiting requested review from mihnita

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rp9-next @nciric @roubert @echeran @markusicu