fix(player): controls component delay overriding player prop

ref #972
vidstack · Oct 23, 2023 · 35bf1e0 · 35bf1e0
1 parent ebc5771
commit 35bf1e0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/vidstack/src/components/ui/controls.ts b/packages/vidstack/src/components/ui/controls.ts
@@ -63,7 +63,9 @@ export class Controls extends Component<ControlsProps, {}, ControlsEvents> {
   private _watchHideDelay() {
     const { controls } = this._media.player,
       { hideDelay } = this.$props;
-    controls.defaultDelay = hideDelay();
+
+    // Use controls delay prop on player if this is the default value.
+    controls.defaultDelay = hideDelay() === 2000 ? this._media.$props.controlsDelay() : hideDelay();
   }
 
   private _isShowing() {

diff --git a/packages/vidstack/src/core/state/media-request-manager.ts b/packages/vidstack/src/core/state/media-request-manager.ts
@@ -79,7 +79,7 @@ export class MediaRequestManager extends MediaPlayerController implements MediaR
 
     this.listen('fullscreen-change', this._onFullscreenChange.bind(this));
 
-    effect(this._onControlsHideDelayChange.bind(this));
+    effect(this._onControlsDelayChange.bind(this));
     effect(this._onFullscreenSupportChange.bind(this));
     effect(this._onPiPSupportChange.bind(this));
   }
@@ -325,7 +325,7 @@ export class MediaRequestManager extends MediaPlayerController implements MediaR
     );
   }
 
-  private _onControlsHideDelayChange() {
+  private _onControlsDelayChange() {
     this._controls.defaultDelay = this.$props.controlsDelay();
   }