fix(player): add media-icons/element to external deps

vidstack · Mar 26, 2024 · ac7acf6 · ac7acf6
1 parent 2c56c58
commit ac7acf6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/vidstack/rollup.config.js b/packages/vidstack/rollup.config.js
@@ -19,8 +19,14 @@ const MODE_WATCH = process.argv.includes('-w'),
 /** @type {Record<string, string | false>} */
 const MANGLE_CACHE = !MODE_TYPES ? await buildMangleCache() : {};
 
-const NPM_EXTERNAL_PACKAGES = ['hls.js', 'dashjs', 'media-captions', 'media-icons'],
-  CDN_EXTERNAL_PACKAGES = ['media-captions', 'media-icons'],
+const NPM_EXTERNAL_PACKAGES = [
+    'hls.js',
+    'dashjs',
+    'media-captions',
+    'media-icons',
+    'media-icons/element',
+  ],
+  CDN_EXTERNAL_PACKAGES = ['media-captions', 'media-icons', 'media-icons/element'],
   PLUGINS_EXTERNAL_PACKAGES = ['vite', 'rollup', /webpack/, /rspack/, 'esbuild', 'unplugin'];
 
 // Styles
@@ -316,6 +322,7 @@ function defineCDNBundle({ dev = false, input, dir, file, legacy = false }) {
         'media-captions': legacy
           ? 'https://cdn.jsdelivr.net/npm/media-captions@next/dist/prod.js'
           : 'https://cdn.vidstack.io/captions',
+        'media-icons/element': 'https://cdn.vidstack.io/icons',
       },
       manualChunks(id) {
         if (dev) return file;

diff --git a/packages/vidstack/src/providers/vimeo/provider.ts b/packages/vidstack/src/providers/vimeo/provider.ts
@@ -592,7 +592,7 @@ export class VimeoProvider
       this._ctx.qualities[QualitySymbol._setAuto](isAuto, trigger);
       this._ctx.qualities[ListSymbol._select](undefined, true, trigger);
     } else {
-      this._ctx.qualities[ListSymbol._select](newQuality, true, trigger);
+      this._ctx.qualities[ListSymbol._select](newQuality ?? undefined, true, trigger);
     }
   }