-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): should update parent host el when component self u… #1360
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b3e4656
fix(runtime-core): should update parent host el when component self u…
underfin 97fa0a2
fix: update el with same type vnode
underfin 25a5600
test: add test
underfin ad58f8e
fix: should update vnode when component not need updated
underfin 57128ee
fix: revert
underfin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add test
- Loading branch information
commit 25a5600ecced3a99fb3cd5709cd088e26fef819b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { | ||
ref, | ||
h, | ||
render, | ||
nodeOps, | ||
serializeInner, | ||
nextTick, | ||
VNode | ||
} from '@vue/runtime-test' | ||
|
||
describe('renderer: component', () => { | ||
test('should update parent(hoc) component host el when child component self update', async () => { | ||
const value = ref(true) | ||
let parentVnode: VNode | ||
let childVnode1: VNode | ||
let childVnode2: VNode | ||
|
||
const Parent = { | ||
render: () => { | ||
// let Parent first rerender | ||
console.log(value.value) | ||
return (parentVnode = h(Child)) | ||
} | ||
} | ||
|
||
const Child = { | ||
render: () => { | ||
return value.value | ||
? (childVnode1 = h('div')) | ||
: (childVnode2 = h('span')) | ||
} | ||
} | ||
|
||
const root = nodeOps.createElement('div') | ||
render(h(Parent), root) | ||
expect(serializeInner(root)).toBe(`<div></div>`) | ||
expect(parentVnode!.el).toBe(childVnode1!.el) | ||
|
||
value.value = false | ||
await nextTick() | ||
expect(serializeInner(root)).toBe(`<span></span>`) | ||
expect(parentVnode!.el).toBe(childVnode2!.el) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here caused that the vnode isn't euquals to parent.subTree when parent is first rerender