-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(warn): better message with no constructors props #9241
Conversation
All reactions
-
👍 4 reactions
@posva - Do you think this needs any changes or do you think it might be promoted to code review? |
All reactions
Sorry, something went wrong.
@posva - Just following up on this. A friendly reminder to have a peak at it when possible 😄 |
All reactions
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor changes. @posva, please have a look at it as well.
Sorry, something went wrong.
All reactions
Co-authored-by: Siddhesh Mhadnak <siddhesh.mhadnak@outlook.com>
Successfully merging this pull request may close these issues.
Warn when the type of a prop isn't a constructor
Closes #9224
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Proof
Before
After