Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local-fonts to table of provisional permissions #20

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Add local-fonts to table of provisional permissions #20

merged 6 commits into from
Dec 9, 2022

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Dec 6, 2022 •
edited by pr-preview bot
Loading

@inexorabletash
Copy link
Member Author

Failures:

Error: ROR] Couldn’t find “local-fonts“ in this document or other cited documents: [dom], [fetch], [html], [infra], [local-fonts], [permissions], [permissions-policy], [url], [w3c-process], and [webidl].
Error: ROR] Reference “[local-font-access]” not found.
Hint: Search for “local-font-access” on Specref to see if it exists or if it’s misspelled.

Will look...

@inexorabletash
Copy link
Member Author

inexorabletash commented Dec 6, 2022 •
edited
Loading

Missing from https://github.com/WICG/admin/blame/gh-pages/biblio.json so specref hasn't picked it up. Will PR there.

ETA: WICG/admin#166

@inexorabletash
Copy link
Member Author

I poked at the export; after specref etc update we can trigger this again and see if it works.

@inexorabletash
Copy link
Member Author

inexorabletash commented Dec 7, 2022 •
edited
Loading

Okay, passing now. @miketaylr or any other reviewers, PTAL at your leisure.

@miketaylr
Copy link
Member

Apologies for the delay! Looking now...

miketaylr
miketaylr approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks @inexorabletash!

(note, you can remove the inline issue 2 now https://wicg.github.io/local-font-access/#permissiondef-local-fonts)

@miketaylr miketaylr merged commit 51fb32e into w3c:main Dec 9, 2022
github-actions bot added a commit that referenced this pull request Dec 9, 2022
@inexorabletash @github-actions
Add local-fonts to table of provisional permissions (#20)
aba5dbe 
SHA: 51fb32e
Reason: push, by miketaylr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inexorabletash @miketaylr