-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export permissions task source #407
base: main
Are you sure you want to change the base?
Conversation
This is used in the Storage Access API: https://privacycg.github.io/storage-access/#ref-for-dfn-permissions-task-source
I'm not sure this makes sense. Shouldn't there be a single task queued that informs a document about a state (change) and that task is then used to do various things such as resolve promises or fire events? As in, I would kinda expect the flow to be that other specifications ask something from Permissions with a set of completion steps and Permissions queues a task and runs those completion steps at the end of that task. |
Oops, approved before seeing Anne's comment. I was going to suggest something similar, in that it would be good if the permissions spec did more of the work. |
I've also just spotted another incorrect usage of the task source in a different spec... it's being used where the "user interaction task source" should be used. |
- Use user interaction task source instead of still evolving permissions task source. w3c/permissions#407 - Replace auto-generated issue 110 with a normal inline issue
- Use user interaction task source instead of still evolving permissions task source. w3c/permissions#407 - Replace auto-generated issue 110 with a normal inline issue
Looks like we're using it for |
Note that using the same task source is really only about relative ordering for the tasks going into that task source. And since there's only ever really a single task as the result of an in parallel algorithm in the case of permissions, relative ordering might not even matter? I'm not as much of an event loop expert as I'd like to be though, so it would be good if that could be verified. |
This is used in the Storage Access API:
https://privacycg.github.io/storage-access/#ref-for-dfn-permissions-task-source
Preview | Diff