Introduce "web-share" feature policy #166

ewilligers · 2020-07-16T05:47:19Z

resolves #151

For normative changes, the following tasks have been completed:

Modified Web platform tests (https://chromium-review.googlesource.com/c/chromium/src/+/2299791)

Implementation commitment:

WebKit (https://bugs.webkit.org/show_bug.cgi?id=214448)
Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=1079104)
Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=1653199)

resolves w3c#151

marcoscaceres

Some suggestions... just for the lulz, they just renamed that spec "Permission Policy" a few weeks ago.

index.html

marcoscaceres · 2020-07-16T09:33:03Z

Gecko tracking bug https://bugzilla.mozilla.org/show_bug.cgi?id=1653199

marcoscaceres · 2020-07-16T09:44:09Z

Testing the HTTP header on the top level doc is great, but I wonder if yo could also test it on sub-frames? See the usage of "test_feature_availability" in the following, for instance https://github.com/web-platform-tests/wpt/pull/23729/files

It should be possible to copy/paste some of those tests.

marcoscaceres · 2020-07-16T09:44:50Z

Blocking on test coverage.

Co-authored-by: Marcos Cáceres <[email protected]>

share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec is being updated w3c/web-share#166 Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3

ewilligers · 2020-07-17T05:10:14Z

Testing the HTTP header on the top level doc is great, but I wonder if yo could also test it on sub-frames? See the usage of "test_feature_availability" in the following, for instance https://github.com/web-platform-tests/wpt/pull/23729/files

Those tests fail in browsers. In WPTs, how do we ensure user activation in sub-frames?

Based on the linked tests, I tried adding feature-policy/resources/feature-policy-web-share.html .

Only when I include
await test_driver.bless("web share"); in feature-policy/resources/feature-policy-web-share.html
and comment out the following lines from resources/testdriver.js click

            if (window.top !== window) {
                return Promise.reject(new Error("can only click in top-level window"));
            }

do I have passing tests for same-origin iframes.

marcoscaceres · 2020-07-17T06:19:05Z

Oh good point. Let's do that as a followup.

In WPTs, how do we ensure user activation in sub-frames?

... yeah, if we can't click() on subframe elements, we are kinda screwed... another way is clicking and sending a .postMessage(), but that only works in Chrome (it's not specified behavior in HTML yet).

do I have passing tests for same-origin iframes.

Ok, that's probably good enough for now 👍

marcoscaceres · 2020-07-17T06:42:53Z

Just FYI, I'm just adding about to send up the patch for this for Gecko (literally compiling right now 🤞).

@othermaciej, do you want us to file WebKit bugs or is someone from WebKit tracking the changes we are making?

othermaciej · 2020-07-17T07:24:13Z

WebKit bug(s) would be appreciated. I'd have to call on @hober for follow-through and/or soliciting a WebKit opinion on this.

marcoscaceres · 2020-07-17T08:13:33Z

Filed https://bugs.webkit.org/show_bug.cgi?id=214448

share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3

share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#789872}

…licy, a=testonly Automatic update from web-platform-tests WebShare: Introduce web-share feature policy share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#789872} -- wpt-commits: 1bd9297b8aa6870267c0c0ad1fa445f897ddecd7 wpt-pr: 24628

ewilligers · 2020-07-26T09:10:03Z

WPT issue raised for transient activation in iframes: web-platform-tests/wpt#24755

…licy, a=testonly Automatic update from web-platform-tests WebShare: Introduce web-share feature policy share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <ericwilligerschromium.org> Reviewed-by: Ian Clelland <iclellandchromium.org> Reviewed-by: Daniel Murphy <dmurphchromium.org> Reviewed-by: Dominick Ng <dominicknchromium.org> Cr-Commit-Position: refs/heads/master{#789872} -- wpt-commits: 1bd9297b8aa6870267c0c0ad1fa445f897ddecd7 wpt-pr: 24628 UltraBlame original commit: a38778c7eacc05993acc592b72e85e34b9c3074f

marcoscaceres · 2021-08-13T04:48:05Z

@ericwilligers, looks like Chrome did add some kind of use counter for this (that would count the fail cases). Could you share the results of that?

I'd like to close #169

marcoscaceres · 2021-09-02T13:44:31Z

Sent WebKit patch. Hopefully will land in a day or two.

share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated w3c/web-share#166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#789872} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: e41da738c01c870e5c30ccb24bb4c9f9b1cb5ae9

Introduce "web-share" feature policy

79890ab

resolves w3c#151

ewilligers requested review from marcoscaceres and mgiuca July 16, 2020 05:47

marcoscaceres approved these changes Jul 16, 2020

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

marcoscaceres added the Blocked label Jul 16, 2020

ewilligers and others added 6 commits July 16, 2020 22:37

feature => permission

5772b34

Co-authored-by: Marcos Cáceres <[email protected]>

Feature => Permission

4ba64dc

Co-authored-by: Marcos Cáceres <[email protected]>

feature => permission

03b7ffd

Co-authored-by: Marcos Cáceres <[email protected]>

dfn web-share

69082df

Co-authored-by: Marcos Cáceres <[email protected]>

feature => permission

8c9baf8

Co-authored-by: Marcos Cáceres <[email protected]>

HTML Tidy

79e0d6f

chromium-wpt-export-bot mentioned this pull request Jul 16, 2020

WebShare: Introduce web-share feature policy web-platform-tests/wpt#24628

Merged

marcoscaceres removed the Blocked label Jul 17, 2020

ewilligers merged commit 2ef967a into w3c:master Jul 17, 2020

ewilligers deleted the feature-policy branch July 17, 2020 06:38

mgiuca mentioned this pull request Jul 24, 2020

Web Share API can be triggered from iframe sandbox #155

Closed

marcoscaceres mentioned this pull request Oct 19, 2020

TPAC planning and specification status report #162

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce "web-share" feature policy #166

Introduce "web-share" feature policy #166

ewilligers commented Jul 16, 2020 •

edited by marcoscaceres

Loading

marcoscaceres left a comment

marcoscaceres commented Jul 16, 2020

marcoscaceres commented Jul 16, 2020

marcoscaceres commented Jul 16, 2020

ewilligers commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

othermaciej commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

ewilligers commented Jul 26, 2020

marcoscaceres commented Aug 13, 2021

marcoscaceres commented Sep 2, 2021

Introduce "web-share" feature policy #166

Introduce "web-share" feature policy #166

Conversation

ewilligers commented Jul 16, 2020 • edited by marcoscaceres Loading

marcoscaceres left a comment

Choose a reason for hiding this comment

marcoscaceres commented Jul 16, 2020

marcoscaceres commented Jul 16, 2020

marcoscaceres commented Jul 16, 2020

ewilligers commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

othermaciej commented Jul 17, 2020

marcoscaceres commented Jul 17, 2020

ewilligers commented Jul 26, 2020

marcoscaceres commented Aug 13, 2021

marcoscaceres commented Sep 2, 2021

ewilligers commented Jul 16, 2020 •

edited by marcoscaceres

Loading