Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark at-risk features in a new snapshot #449

Merged
merged 10 commits into from
Apr 3, 2019
Merged

Conversation

gkatsev
Copy link
Collaborator

@gkatsev gkatsev commented Mar 6, 2019

Made a new snapshot for 2019-03-06 and manually applied 2c06667 and c9100e0.
Then I marked collision avoidance with snap-to-lines false, ::cue-region and ::cue-region() pseudo-elements, and :past and :future pseudo-classes as at-risk.
STYLE block is no longer marked at risk because I have a prototype that would be completed during the mandatory 28-day waiting period after this snapshot is published as the new CR.

<a href="https://github.com/web-platform-tests/wpt/tree/master/webvtt">test suite</a>. The Working
Group does not require that implementations are publicly available but encourages them to be so.</p>

<div data-fill-with="at-risk">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this piece is the main change.

Copy link
Member

@silviapfeiffer silviapfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be helpful to readers, and to us later, if it is really clear exactly which spec text will be removed if each at risk feature is to be removed. It looks pretty clear for the second two features, but not for the first one.

archives/2019-03-06/Overview.html Outdated Show resolved Hide resolved
@plehegar
Copy link
Member

Transition request: w3c/transitions#126

archives/2019-03-06/Overview.html Outdated Show resolved Hide resolved
archives/2019-03-06/Overview.html Outdated Show resolved Hide resolved
archives/2019-03-06/Overview.html Outdated Show resolved Hide resolved
archives/2019-03-06/Overview.html Outdated Show resolved Hide resolved
@gkatsev
Copy link
Collaborator Author

gkatsev commented Mar 28, 2019

I've accepted the updates.

@nigelmegitt
Copy link
Contributor

The previous version needs to be updated too, as does the pub date (15 April) which is too late for a 2 May deadline for comments.

@plehegar plehegar merged commit b4c746f into w3c:gh-pages Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants