Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup gh actions #494

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Setup gh actions #494

merged 3 commits into from
Feb 26, 2021

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Dec 9, 2020

I've checked

  • output from HEAD of PR 492 and index.html in gh-pages is the same, except for syntax used by bikeshed
  • configured to use main branch as a source, and gh-pages as a destination

and propose:

  • remove index.html in gh-pages (done in this PR), to prevent local and/or remote crash

If fine, please (or I can take actions):

@himorin himorin requested a review from gkatsev December 9, 2020 08:38
@gkatsev
Copy link
Collaborator

gkatsev commented Dec 9, 2020

Should we include index.html in .gitignore so that it won't get checked in by people into the repo? We'd want to exclude .gitignore from the deploy copy as well.

Otherwise, this LGTM. Thanks @himorin!

@w3cbot
Copy link

w3cbot commented Dec 10, 2020

himorin marked as non substantive for IPR from ash-nazg.

@himorin
Copy link
Contributor Author

himorin commented Dec 10, 2020

Should we include index.html in .gitignore so that it won't get checked in by people into the repo? We'd want to exclude .gitignore from the deploy copy as well.

updated.
(/html5/ in .gitignore should be removed??)

@himorin
Copy link
Contributor Author

himorin commented Feb 26, 2021

@gkatsev Let me propose as follows:

  • merge this Setup gh actions #494 first (should work incl. GHActions)
  • change github pages source to gh-pages branch
  • cleaning up files in gh-pages branch, since we now have the same for main and gh-pages
  • merge other PRs

@gkatsev
Copy link
Collaborator

gkatsev commented Feb 26, 2021

@himorin that sounds great to me!

@gkatsev gkatsev merged commit 3a39d9b into w3c:main Feb 26, 2021
@gkatsev
Copy link
Collaborator

gkatsev commented Feb 26, 2021

@himorin looks like the action failed :( https://github.com/w3c/webvtt/runs/1984601204#step:5:80

@gkatsev
Copy link
Collaborator

gkatsev commented Feb 26, 2021

Actually, looks like it succeeded but then the rest of the action had an issue? 34e1ab9

@himorin
Copy link
Contributor Author

himorin commented Feb 26, 2021

Ah! I forgot recent update... (which I did for other WG)
let me open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants