Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let HTML handle the "same site" definition #457

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 11, 2019

Closes #449. Partially addresses #448.


Marking "do not merge yet" because the build will fail until the HTML pull request is merged.


Preview | Diff

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Nov 11, 2019
url.bs Outdated Show resolved Hide resolved
@domenic
Copy link
Member Author

domenic commented Nov 19, 2019

This should be mergeable whenever the bikeshed link database updates. I'll set a reminder to do so tomorrow, if you give it the green checkmark.

@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 19, 2019
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it fails because the URL Standard still defines the term according to Bikeshed's database. I guess we could temporarily include a link-defaults block?

Also, this closes both #448 and #449, no?

@domenic domenic merged commit 3703f92 into master Nov 20, 2019
@domenic domenic deleted the domenic/site-revamp branch November 20, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants