This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Concatenate items added via multiple calls to precache() #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Yeah, looks like the other changes are due to an update in the cache polyfill. |
wibblymat
added a commit
that referenced
this pull request
Jan 15, 2015
Concatenate items added via multiple calls to precache()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across situations in which I want to call
shed.precache()multiple times from different scripts, and currently that will cause the precache list to be overwritten each time. Instead, the change in this PR will concatenate to the existing list each time it's called.(I am not sure where all those changes to
dist/shed.jscame from—perhaps I built it with a more recent version of some of the npm dependencies? Do those look okay to you, @wibblymat?)