Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple Pay - Donate form API calls #4619

Merged
merged 33 commits into from
Sep 27, 2023
Merged

Apple Pay - Donate form API calls #4619

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
76916e0
Add feature flag
tonisevener Sep 8, 2023
85a3a07
Add json resources
tonisevener Sep 22, 2023
0f37f7f
Add WKServiceEnvironment, add methods for creating donate API URLs
tonisevener Sep 22, 2023
7fbb310
Move WKData protocols into Protocol subfolder, tweak service protocol…
tonisevener Sep 22, 2023
e23e324
Move feature-specific models into subfolders
tonisevener Sep 22, 2023
63e3073
Add WKURLSession wrapper for assistance in unit testing
tonisevener Sep 22, 2023
3b33078
Add extensions needed for basic service
tonisevener Sep 22, 2023
421971c
Add WKBasicService and WKBasicServiceRequest
tonisevener Sep 22, 2023
20295db
Add WKMockURLSession and unit tests for WKBasicService
tonisevener Sep 22, 2023
deec94c
Add basicService and serviceEnvironment properties to WKDataEnvironment
tonisevener Sep 22, 2023
bbb5b71
Add models for donateConfig, paymentMethods, and submitPayment API calls
tonisevener Sep 22, 2023
c315364
Add WKDonateDataController for making donation-related API calls
tonisevener Sep 22, 2023
7ebe664
Add WKMockDonateBasicService and unit tests for WKDonateDataController
tonisevener Sep 22, 2023
b49f212
Set the correct WKDataEnvironment service environment upon launch
tonisevener Sep 22, 2023
b6b436b
Fetch donate configs when announcements are fetched
tonisevener Sep 22, 2023
cdf54df
Add missed posting protocol conformance
tonisevener Sep 22, 2023
fdf2151
Merge branch 'main' into apple-pay-1
tonisevener Sep 22, 2023
312faba
Remove double header setting
tonisevener Sep 22, 2023
a1c1e3f
Fix compile failure - add fetchDonateConfig helper method to WMFAnnou…
tonisevener Sep 22, 2023
a82a1f8
Better brand name handling
tonisevener Sep 22, 2023
f4fe16e
Remove extra extension file
tonisevener Sep 22, 2023
b3aea1b
Temporary changes for testing
tonisevener Sep 22, 2023
d4bdfde
Merge branch 'main' into apple-pay-1
staykids Sep 25, 2023
cc2e9cd
PR Feedback - http response extension for status code success flag
tonisevener Sep 26, 2023
880b5b9
PR Feedback - base api path components
tonisevener Sep 26, 2023
d5b60e9
PR feedback - unnecessary comments
tonisevener Sep 26, 2023
7da6760
PR Feedback - rename feature flag
tonisevener Sep 26, 2023
96a531a
PR Feedback - improve donate config key names
tonisevener Sep 26, 2023
105b610
Merge branch 'main' into apple-pay-1
tonisevener Sep 26, 2023
c023c78
PR Feedback - rename feature flag again
tonisevener Sep 26, 2023
729ff24
PR Feedback - missing completion handler
tonisevener Sep 27, 2023
664e9f2
PR Feedback - add assertion failure for failure to encode dictionary …
tonisevener Sep 27, 2023
c7453a2
Merge branch 'main' into apple-pay-1
tonisevener Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add feature flag
  • Loading branch information
@tonisevener
tonisevener committed Sep 8, 2023
commit 76916e0343a7d792c6c6a42b7f2aba1650da47e5
7 changes: 7 additions & 0 deletions WMF Framework/FeatureFlags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,11 @@ public struct FeatureFlags {
#endif
}

public static var applePayEnabled: Bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but what do you think about something like applePayDonationEnabled instead? On first read applePayEnabled connoted the availability of Apple Pay itself to me, rather than our intent of Apple Pay as a donation option.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (twice actually, sorry). I went with the more general donorExperienceImrovementsEnabled - I'm hoping to be able to wrap up all of our improvements in the next few weeks around that for easy rollback, not just the native form.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 new name works great, much more precise about what it is

#if WMF_STAGING
return true
#else
return false
#endif
}
}