Implement "Yes-No-Address-Form" #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
4 times, most recently
from
ca0211d to
21f6fc0
Compare
|
Till also left some comments in the ticket, I spotted something else while checking out the code locally:
|
gbirke
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
from
21f6fc0 to
b70db33
Compare
|
I'm not sure about the current state of error summary behaviour, but I noticed the options here don't turn red + no red error prompt below the options, I don't know whether we need that. |
gbirke
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
2 times, most recently
from
c8e9bc6 to
1d6c091
Compare
As requested by KuF team Ticket: https://phabricator.wikimedia.org/T380462
- Add new form component - it'll contain a new section - Add new section component - it'll contain a new address type selection - Add new address type component that just switches between "Person" and "Company" These components take the "regular" donation form component as a base. Ticket: https://phabricator.wikimedia.org/T380462
gbirke
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
2 times, most recently
from
e372966 to
7ea8ba2
Compare
|
I left those error messages out on purpose because of the proximity to the error summary. But wouldn't be a problem to add them, will have to discuss that with PM. |
moiikana
reviewed
Nov 26, 2024
Comment on lines
29
to
31
|
|
||
| describe( 'DonationForm.vue', () => { | ||
|
|
There was a problem hiding this comment.
describe( DonationFormAnonymousChoice.vue, () => {
moiikana
approved these changes
Nov 26, 2024
- Add new model with composable - Add new ErrorSummary component that only shows payment errors and non-selection of opt-out/opt-in - Adapt `PersonalDataSectionAnonymousChoice` - Adapt `DonationFormAnonymousChoice` - Grace fully handle user changes of payment type (enforcing address for direct debit) Ticket: https://phabricator.wikimedia.org/T380462
gbirke
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
from
7ea8ba2 to
762330b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an A/B test implementation for the new "Yes/No choice form" that gets presented when the user donates a low amount
Ticket: https://phabricator.wikimedia.org/T380462