Implement Gravatar QuickEditor #21312

AdamGrzybkowski · 2024-10-18T12:23:28Z

This PR implements the QuickEditor from the Gravatar SDK. It fully replaces the Avatar update flow, including uploading already existing photos or new ones from the camera.

A few things worth noting:

One of Gravatar's compose dependencies bumps the foundation library. This caused the WP build to fail because a few things got deprecated. These issues were fixed in 5b1adac. If you would prefer, I can update the compose BOM (only this specific artifact) and apply those changes in a separate PR.
Gravatar uses UCrop like the WP app. We found an issue where the cropped image size (file size) is not changed. We've tried to fix that in UCrop (PR) but things aren't moving fast there, so we released the Automattic fork with the fix applied. I had to update WP to the Automattic version to not cause conflicts.
I've added a feature flag for the QuickEditor. Its purpose is a safety mechanism to be able to turn off the integration in case something doesn't work as it should. I'm not sure where to set this remotely or whether this has to happen now or when it's needed. Can you guide me here?

Here's how the QuickEditor looks like in WP on the MeFragment

jp_gravatar.mp4

And here's the SignupEpilogueFragment

sign-up_qe.mp4

To Test:

Go through the sign-up flow
On the SignupEpilogueFragment tap the avatar to upload a new image
Confirm the avatar was uploaded
Continue and go to the MeFragment by tapping the Me option
Tap on the avatar
Confirm the QuickEditor was opened
Upload a new avatar, play with the QE.
Modify the GRAVATAR_QUICK_EDITOR feature flag in build.gradle to false
Repeat steps 1-7 - this should behave same as it works now without the QuickEditor.

Regression Notes

Potential unintended areas of impact
- no

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic · 2024-10-18T12:26:14Z

	1 Warning
⚠️	Class `GravatarQuickEditorFeatureConfig` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2024-10-18T12:30:53Z

Project dependencies changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

Build environment changes

The following changes in the build classpath were detected:

list

Upgraded Dependencies
androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.8.3, (changed from 2.7.7)
androidx.navigation:navigation-safe-args-generator:2.8.3, (changed from 2.7.7)
androidx.navigation:navigation-safe-args-gradle-plugin:2.8.3, (changed from 2.7.7)

tree

-\--- androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.7.7
-     \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.7.7
-          +--- androidx.navigation:navigation-safe-args-generator:2.7.7
-          |    +--- com.squareup:javapoet:1.13.0
-          |    +--- com.squareup:kotlinpoet:1.14.2 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.20 (*)
-          |    +--- xmlpull:xmlpull:1.1.3.1
-          |    +--- xpp3:xpp3:1.1.4c
-          |    \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.7.7 (c)
-          +--- com.android.tools.build:gradle:7.3.0 -> 8.5.1
-          |    +--- com.android.tools.build:gradle-settings-api:8.5.1
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- com.android.tools:sdk-common:31.5.1
-          |    |    +--- com.android.tools.analytics-library:shared:31.5.1
-          |    |    |    +--- com.android.tools.analytics-library:protos:31.5.1
-          |    |    |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    +--- com.android.tools:common:31.5.1
-          |    |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    |    |    +--- net.java.dev.jna:jna-platform:5.6.0
-          |    |    |    |    |    \--- net.java.dev.jna:jna:5.6.0
-          |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    |    +--- net.java.dev.jna:jna-platform:5.6.0 (*)
-          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950
-          |    |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1
-          |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    |    +--- net.sf.kxml:kxml2:2.3.0
-          |    |    |    \--- org.jetbrains:annotations:23.0.0
-          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1
-          |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- net.sf.kxml:kxml2:2.3.0
-          |    |    |    \--- org.jetbrains:annotations:23.0.0
-          |    |    +--- com.android.tools:sdklib:31.5.1
-          |    |    |    +--- com.android.tools:repository:31.5.1
-          |    |    |    |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
-          |    |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    |    +--- com.google.jimfs:jimfs:1.1
-          |    |    |    |    |    \--- com.google.guava:guava:18.0 -> 32.0.1-jre (*)
-          |    |    |    |    +--- com.sun.activation:javax.activation:1.2.0
-          |    |    |    |    +--- org.apache.commons:commons-compress:1.21
-          |    |    |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2
-          |    |    |    |    |    +--- jakarta.xml.bind:jakarta.xml.bind-api:2.3.2
-          |    |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
-          |    |    |    |    |    +--- org.glassfish.jaxb:txw2:2.3.2
-          |    |    |    |    |    +--- com.sun.istack:istack-commons-runtime:3.0.8
-          |    |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
-          |    |    |    |    |    +--- org.jvnet.staxex:stax-ex:1.8.1
-          |    |    |    |    |    |    +--- jakarta.activation:jakarta.activation-api:1.2.1
-          |    |    |    |    |    |    \--- jakarta.xml.bind:jakarta.xml.bind-api:2.3.2 (*)
-          |    |    |    |    |    +--- com.sun.xml.fastinfoset:FastInfoset:1.2.16
-          |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
-          |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- com.android.tools:dvlib:31.5.1
-          |    |    |    |    \--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
-          |    |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    |    +--- org.apache.commons:commons-compress:1.21
-          |    |    |    +--- org.apache.httpcomponents:httpcore:4.4.16
-          |    |    |    +--- org.apache.httpcomponents:httpmime:4.5.6
-          |    |    |    |    \--- org.apache.httpcomponents:httpclient:4.5.6 -> 4.5.14
-          |    |    |    |         +--- org.apache.httpcomponents:httpcore:4.4.16
-          |    |    |    |         +--- commons-logging:commons-logging:1.2
-          |    |    |    |         \--- commons-codec:commons-codec:1.11
-          |    |    |    \--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
-          |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    +--- javax.inject:javax.inject:1
-          |    |    +--- net.sf.kxml:kxml2:2.3.0
-          |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77
-          |    |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
-          |    |    |    \--- org.bouncycastle:bcutil-jdk18on:1.77
-          |    |    |         \--- org.bouncycastle:bcprov-jdk18on:1.77
-          |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
-          |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
-          |    |    +--- org.jetbrains.intellij.deps:trove4j:1.0.20200330
-          |    |    +--- org.jetbrains.kotlin:kotlin-reflect:1.9.20 (*)
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- com.android.tools:sdklib:31.5.1 (*)
-          |    +--- com.android.tools:repository:31.5.1 (*)
-          |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
-          |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950 (*)
-          |    +--- com.android.tools.build:aaptcompiler:8.5.1
-          |    |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950 (*)
-          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
-          |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- com.android.tools.analytics-library:crash:31.5.1
-          |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    +--- org.apache.httpcomponents:httpclient:4.5.14 (*)
-          |    |    +--- org.apache.httpcomponents:httpcore:4.4.16
-          |    |    \--- org.apache.httpcomponents:httpmime:4.5.6 (*)
-          |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
-          |    +--- com.android.tools.lint:lint-model:31.5.1
-          |    |    +--- com.android.tools.build:builder-model:8.5.1
-          |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
-          |    |    +--- net.sf.kxml:kxml2:2.3.0
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- com.android.tools.lint:lint-typedef-remover:31.5.1
-          |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    \--- org.ow2.asm:asm:9.6
-          |    +--- androidx.databinding:databinding-compiler-common:8.5.1
-          |    |    +--- androidx.databinding:databinding-common:8.5.1
-          |    |    +--- com.android.databinding:baseLibrary:8.5.1
-          |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10
-          |    |    |    +--- com.google.code.gson:gson:2.8.0 -> 2.10.1
-          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 2.0.20 (*)
-          |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    +--- com.googlecode.juniversalchardet:juniversalchardet:1.0.3
-          |    |    +--- com.squareup:javapoet:1.10.0 -> 1.13.0
-          |    |    +--- commons-io:commons-io:2.13.0
-          |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- androidx.databinding:databinding-common:8.5.1
-          |    +--- com.android.databinding:baseLibrary:8.5.1
-          |    +--- com.android.tools.build:builder-test-api:8.5.1
-          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
-          |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    \--- com.google.guava:guava:32.0.1-jre (*)
-          |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
-          |    +--- com.android.tools.utp:android-device-provider-ddmlib-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-device-provider-gradle-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-additional-test-output-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-coverage-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-emulator-control-proto:31.5.1
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-logcat-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-apk-installer-proto:31.5.1
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-host-retention-proto:31.5.1
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.android.tools.utp:android-test-plugin-result-listener-gradle-proto:31.5.1
-          |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    +--- io.grpc:grpc-core:1.57.0
-          |    |    |    +--- io.grpc:grpc-api:1.57.0
-          |    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
-          |    |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    |    +--- com.google.android:annotations:4.1.1.4
-          |    |    |    +--- org.codehaus.mojo:animal-sniffer-annotations:1.23
-          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
-          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    |    +--- io.perfmark:perfmark-api:0.26.0
-          |    |    |    \--- io.grpc:grpc-context:1.57.0
-          |    |    |         \--- io.grpc:grpc-api:1.57.0 (*)
-          |    |    +--- io.grpc:grpc-netty:1.57.0
-          |    |    |    +--- io.grpc:grpc-core:1.57.0 (*)
-          |    |    |    +--- io.netty:netty-codec-http2:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final
-          |    |    |    |    |    \--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    |    \--- io.netty:netty-resolver:4.1.93.Final
-          |    |    |    |    |         \--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-codec:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    |    \--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |    +--- io.netty:netty-handler:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-resolver:4.1.93.Final (*)
-          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |    |    +--- io.netty:netty-transport-native-unix-common:4.1.93.Final
-          |    |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    |    |    \--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |    |    \--- io.netty:netty-codec:4.1.93.Final (*)
-          |    |    |    |    \--- io.netty:netty-codec-http:4.1.93.Final
-          |    |    |    |         +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |         +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |         +--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |         +--- io.netty:netty-codec:4.1.93.Final (*)
-          |    |    |    |         \--- io.netty:netty-handler:4.1.93.Final (*)
-          |    |    |    +--- io.netty:netty-handler-proxy:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |    +--- io.netty:netty-codec:4.1.93.Final (*)
-          |    |    |    |    +--- io.netty:netty-codec-socks:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
-          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
-          |    |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
-          |    |    |    |    |    \--- io.netty:netty-codec:4.1.93.Final (*)
-          |    |    |    |    \--- io.netty:netty-codec-http:4.1.93.Final (*)
-          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
-          |    |    |    +--- io.perfmark:perfmark-api:0.26.0
-          |    |    |    \--- io.netty:netty-transport-native-unix-common:4.1.93.Final (*)
-          |    |    +--- io.grpc:grpc-protobuf:1.57.0
-          |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
-          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    |    +--- com.google.api.grpc:proto-google-common-protos:2.17.0
-          |    |    |    |    \--- com.google.protobuf:protobuf-java:3.21.12 -> 3.22.3
-          |    |    |    +--- io.grpc:grpc-protobuf-lite:1.57.0
-          |    |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
-          |    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    +--- io.grpc:grpc-stub:1.57.0
-          |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
-          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
-          |    |    |    \--- com.google.errorprone:error_prone_annotations:2.18.0
-          |    |    +--- javax.annotation:javax.annotation-api:1.3.2
-          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    +--- com.android.tools.build:transform-api:2.0.0-deprecated-use-gradle-api
-          |    +--- org.apache.httpcomponents:httpmime:4.5.6 (*)
-          |    +--- commons-io:commons-io:2.13.0
-          |    +--- org.ow2.asm:asm:9.6
-          |    +--- org.ow2.asm:asm-analysis:9.6
-          |    |    \--- org.ow2.asm:asm-tree:9.6
-          |    |         \--- org.ow2.asm:asm:9.6
-          |    +--- org.ow2.asm:asm-commons:9.6
-          |    |    +--- org.ow2.asm:asm:9.6
-          |    |    \--- org.ow2.asm:asm-tree:9.6 (*)
-          |    +--- org.ow2.asm:asm-util:9.6
-          |    |    +--- org.ow2.asm:asm:9.6
-          |    |    +--- org.ow2.asm:asm-tree:9.6 (*)
-          |    |    \--- org.ow2.asm:asm-analysis:9.6 (*)
-          |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
-          |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
-          |    +--- net.sf.jopt-simple:jopt-simple:4.9
-          |    +--- com.android.tools.build:bundletool:1.16.0
-          |    |    +--- com.android.tools.build:aapt2-proto:7.3.0-alpha07-8248216 -> 8.5.1-11315950 (*)
-          |    |    +--- com.google.auto.value:auto-value-annotations:1.6.2
-          |    |    +--- com.google.errorprone:error_prone_annotations:2.3.1 -> 2.18.0
-          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    +--- com.google.protobuf:protobuf-java-util:3.22.3
-          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    |    |    +--- com.google.code.gson:gson:2.8.9 -> 2.10.1
-          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.11.0 -> 2.18.0
-          |    |    |    +--- com.google.guava:guava:31.1-jre -> 32.0.1-jre (*)
-          |    |    |    \--- com.google.j2objc:j2objc-annotations:1.3 -> 2.8
-          |    |    +--- com.google.dagger:dagger:2.28.3
-          |    |    |    \--- javax.inject:javax.inject:1
-          |    |    +--- javax.inject:javax.inject:1
-          |    |    +--- org.bitbucket.b_c:jose4j:0.9.5
-          |    |    \--- org.slf4j:slf4j-api:1.7.30
-          |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10 (*)
-          |    +--- com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta10
-          |    |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10 (*)
-          |    |    +--- org.ow2.asm:asm:8.0.1 -> 9.6
-          |    |    +--- org.ow2.asm:asm-util:8.0.1 -> 9.6 (*)
-          |    |    +--- org.ow2.asm:asm-commons:8.0.1 -> 9.6 (*)
-          |    |    +--- org.jdom:jdom2:2.0.6
-          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 2.0.20 (*)
-          |    +--- com.squareup:javapoet:1.10.0 -> 1.13.0
-          |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    +--- com.google.protobuf:protobuf-java-util:3.22.3 (*)
-          |    +--- com.google.code.gson:gson:2.10.1
-          |    +--- io.grpc:grpc-core:1.57.0 (*)
-          |    +--- io.grpc:grpc-netty:1.57.0 (*)
-          |    +--- io.grpc:grpc-protobuf:1.57.0 (*)
-          |    +--- io.grpc:grpc-stub:1.57.0 (*)
-          |    +--- com.google.crypto.tink:tink:1.7.0
-          |    |    +--- com.google.protobuf:protobuf-java:3.19.3 -> 3.22.3
-          |    |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
-          |    +--- com.google.testing.platform:core-proto:0.0.9-alpha02
-          |    +--- net.sf.kxml:kxml2:2.3.0
-          |    +--- com.google.flatbuffers:flatbuffers-java:1.12.0
-          |    +--- org.tensorflow:tensorflow-lite-metadata:0.1.0-rc2
-          |    |    +--- org.checkerframework:checker-qual:2.5.8 -> 3.33.0
-          |    |    \--- com.google.flatbuffers:flatbuffers-java:1.12.0
-          |    +--- com.android.tools.build:builder:8.5.1
-          |    |    +--- com.android.tools.build:builder-model:8.5.1 (*)
-          |    |    +--- com.android.tools.build:builder-test-api:8.5.1 (*)
-          |    |    +--- com.android.tools:sdklib:31.5.1 (*)
-          |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
-          |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
-          |    |    +--- com.android:signflinger:8.5.1
-          |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    +--- com.android.tools.build:apksig:8.5.1
-          |    |    |    \--- com.android:zipflinger:8.5.1
-          |    |    |         \--- com.android.tools:annotations:31.5.1
-          |    |    +--- com.android.tools.analytics-library:protos:31.5.1 (*)
-          |    |    +--- com.android.tools.analytics-library:tracker:31.5.1
-          |    |    |    +--- com.android.tools.analytics-library:protos:31.5.1 (*)
-          |    |    |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
-          |    |    |    +--- com.android.tools:annotations:31.5.1
-          |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
-          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
-          |    |    +--- commons-codec:commons-codec:1.10 -> 1.11
-          |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
-          |    |    +--- javax.inject:javax.inject:1
-          |    |    +--- org.ow2.asm:asm-commons:9.6 (*)
-          |    |    +--- com.android.tools.build:manifest-merger:31.5.1
-          |    |    |    +--- com.android.tools:common:31.5.1 (*)
-          |    |    |    +--- com.android.tools:sdklib:31.5.1 (*)
-          |    |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
-          |    |    |    +--- com.google.code.gson:gson:2.10.1
-          |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |    |    |    \--- net.sf.kxml:kxml2:2.3.0
-          |    |    +--- com.android:zipflinger:8.5.1 (*)
-          |    |    +--- com.android.tools.build:apksig:8.5.1
-          |    |    +--- com.android.tools.build:apkzlib:8.5.1
-          |    |    |    +--- com.android.tools.build:apksig:8.5.1
-          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
-          |    |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
-          |    |    |    \--- org.bouncycastle:bcprov-jdk18on:1.77
-          |    |    \--- com.squareup:javawriter:2.5.0
-          |    +--- com.android.tools.build:builder-model:8.5.1 (*)
-          |    \--- com.android.tools.build:gradle-api:8.5.1
-          |         +--- com.android.tools.build:builder-test-api:8.5.1 (*)
-          |         +--- com.google.guava:guava:32.0.1-jre (*)
-          |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
-          |         \--- org.ow2.asm:asm:9.6
-          +--- com.google.code.gson:gson:2.9.0 -> 2.10.1
-          +--- org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0 -> 2.0.21
-          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-model:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:compose-compiler-gradle-plugin:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-allopen:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-serialization:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21 (c)
-          |    |    +--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21 (c)
-          |    |    \--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21 (c)
-          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21 (*)
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21
-          |    |    |    +--- org.jetbrains.kotlin:kotlin-util-io:2.0.21
-          |    |    |    \--- org.jetbrains.kotlin:kotlin-util-klib:2.0.21
-          |    |    |         \--- org.jetbrains.kotlin:kotlin-util-io:2.0.21
-          |    |    \--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21
-          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-model:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21 (*)
-          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21
-          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21
-          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea-proto:2.0.21
-          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea:2.0.21 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-klib-commonizer-api:2.0.21
-          |    |    \--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-build-tools-api:2.0.21
-          |    +--- org.jetbrains.kotlin:kotlin-build-statistics:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-build-tools-api:2.0.21
-          |    |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
-          |    +--- org.jetbrains.kotlin:kotlin-compiler-runner:2.0.21
-          |    |    +--- org.jetbrains.kotlin:kotlin-daemon-client:2.0.21
-          |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-util-klib:2.0.21 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-compiler-embeddable:2.0.21
-          |         +--- org.jetbrains.kotlin:kotlin-daemon-embeddable:2.0.21
-          |         +--- org.jetbrains.intellij.deps:trove4j:1.0.20200330
-          |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (*)
-          \--- androidx.navigation:navigation-safe-args-generator:2.7.7 (c)
+\--- androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.8.3
+     \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.8.3
+          +--- androidx.navigation:navigation-safe-args-generator:2.8.3
+          |    +--- com.squareup:javapoet:1.13.0
+          |    +--- com.squareup:kotlinpoet:1.14.2 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.20 (*)
+          |    +--- xmlpull:xmlpull:1.1.3.1
+          |    +--- xpp3:xpp3:1.1.4c
+          |    \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.8.3 (c)
+          +--- com.android.tools.build:gradle:7.3.0 -> 8.5.1
+          |    +--- com.android.tools.build:gradle-settings-api:8.5.1
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- com.android.tools:sdk-common:31.5.1
+          |    |    +--- com.android.tools.analytics-library:shared:31.5.1
+          |    |    |    +--- com.android.tools.analytics-library:protos:31.5.1
+          |    |    |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    +--- com.android.tools:common:31.5.1
+          |    |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    |    |    +--- net.java.dev.jna:jna-platform:5.6.0
+          |    |    |    |    |    \--- net.java.dev.jna:jna:5.6.0
+          |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    |    +--- net.java.dev.jna:jna-platform:5.6.0 (*)
+          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950
+          |    |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1
+          |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    |    +--- net.sf.kxml:kxml2:2.3.0
+          |    |    |    \--- org.jetbrains:annotations:23.0.0
+          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1
+          |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- net.sf.kxml:kxml2:2.3.0
+          |    |    |    \--- org.jetbrains:annotations:23.0.0
+          |    |    +--- com.android.tools:sdklib:31.5.1
+          |    |    |    +--- com.android.tools:repository:31.5.1
+          |    |    |    |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
+          |    |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    |    +--- com.google.jimfs:jimfs:1.1
+          |    |    |    |    |    \--- com.google.guava:guava:18.0 -> 32.0.1-jre (*)
+          |    |    |    |    +--- com.sun.activation:javax.activation:1.2.0
+          |    |    |    |    +--- org.apache.commons:commons-compress:1.21
+          |    |    |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2
+          |    |    |    |    |    +--- jakarta.xml.bind:jakarta.xml.bind-api:2.3.2
+          |    |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
+          |    |    |    |    |    +--- org.glassfish.jaxb:txw2:2.3.2
+          |    |    |    |    |    +--- com.sun.istack:istack-commons-runtime:3.0.8
+          |    |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
+          |    |    |    |    |    +--- org.jvnet.staxex:stax-ex:1.8.1
+          |    |    |    |    |    |    +--- jakarta.activation:jakarta.activation-api:1.2.1
+          |    |    |    |    |    |    \--- jakarta.xml.bind:jakarta.xml.bind-api:2.3.2 (*)
+          |    |    |    |    |    +--- com.sun.xml.fastinfoset:FastInfoset:1.2.16
+          |    |    |    |    |    \--- jakarta.activation:jakarta.activation-api:1.2.1
+          |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- com.android.tools:dvlib:31.5.1
+          |    |    |    |    \--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
+          |    |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    |    +--- org.apache.commons:commons-compress:1.21
+          |    |    |    +--- org.apache.httpcomponents:httpcore:4.4.16
+          |    |    |    +--- org.apache.httpcomponents:httpmime:4.5.6
+          |    |    |    |    \--- org.apache.httpcomponents:httpclient:4.5.6 -> 4.5.14
+          |    |    |    |         +--- org.apache.httpcomponents:httpcore:4.4.16
+          |    |    |    |         +--- commons-logging:commons-logging:1.2
+          |    |    |    |         \--- commons-codec:commons-codec:1.11
+          |    |    |    \--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
+          |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    +--- javax.inject:javax.inject:1
+          |    |    +--- net.sf.kxml:kxml2:2.3.0
+          |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77
+          |    |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
+          |    |    |    \--- org.bouncycastle:bcutil-jdk18on:1.77
+          |    |    |         \--- org.bouncycastle:bcprov-jdk18on:1.77
+          |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
+          |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
+          |    |    +--- org.jetbrains.intellij.deps:trove4j:1.0.20200330
+          |    |    +--- org.jetbrains.kotlin:kotlin-reflect:1.9.20 (*)
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- com.android.tools:sdklib:31.5.1 (*)
+          |    +--- com.android.tools:repository:31.5.1 (*)
+          |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
+          |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950 (*)
+          |    +--- com.android.tools.build:aaptcompiler:8.5.1
+          |    |    +--- com.android.tools.build:aapt2-proto:8.5.1-11315950 (*)
+          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
+          |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- com.android.tools.analytics-library:crash:31.5.1
+          |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    +--- org.apache.httpcomponents:httpclient:4.5.14 (*)
+          |    |    +--- org.apache.httpcomponents:httpcore:4.4.16
+          |    |    \--- org.apache.httpcomponents:httpmime:4.5.6 (*)
+          |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
+          |    +--- com.android.tools.lint:lint-model:31.5.1
+          |    |    +--- com.android.tools.build:builder-model:8.5.1
+          |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
+          |    |    +--- net.sf.kxml:kxml2:2.3.0
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- com.android.tools.lint:lint-typedef-remover:31.5.1
+          |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    \--- org.ow2.asm:asm:9.6
+          |    +--- androidx.databinding:databinding-compiler-common:8.5.1
+          |    |    +--- androidx.databinding:databinding-common:8.5.1
+          |    |    +--- com.android.databinding:baseLibrary:8.5.1
+          |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10
+          |    |    |    +--- com.google.code.gson:gson:2.8.0 -> 2.10.1
+          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 2.0.20 (*)
+          |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    +--- com.googlecode.juniversalchardet:juniversalchardet:1.0.3
+          |    |    +--- com.squareup:javapoet:1.10.0 -> 1.13.0
+          |    |    +--- commons-io:commons-io:2.13.0
+          |    |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- androidx.databinding:databinding-common:8.5.1
+          |    +--- com.android.databinding:baseLibrary:8.5.1
+          |    +--- com.android.tools.build:builder-test-api:8.5.1
+          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
+          |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    \--- com.google.guava:guava:32.0.1-jre (*)
+          |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
+          |    +--- com.android.tools.utp:android-device-provider-ddmlib-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-device-provider-gradle-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-additional-test-output-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-coverage-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-emulator-control-proto:31.5.1
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-logcat-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-apk-installer-proto:31.5.1
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-host-retention-proto:31.5.1
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.android.tools.utp:android-test-plugin-result-listener-gradle-proto:31.5.1
+          |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    +--- io.grpc:grpc-core:1.57.0
+          |    |    |    +--- io.grpc:grpc-api:1.57.0
+          |    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
+          |    |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    |    +--- com.google.android:annotations:4.1.1.4
+          |    |    |    +--- org.codehaus.mojo:animal-sniffer-annotations:1.23
+          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
+          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    |    +--- io.perfmark:perfmark-api:0.26.0
+          |    |    |    \--- io.grpc:grpc-context:1.57.0
+          |    |    |         \--- io.grpc:grpc-api:1.57.0 (*)
+          |    |    +--- io.grpc:grpc-netty:1.57.0
+          |    |    |    +--- io.grpc:grpc-core:1.57.0 (*)
+          |    |    |    +--- io.netty:netty-codec-http2:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final
+          |    |    |    |    |    \--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    |    \--- io.netty:netty-resolver:4.1.93.Final
+          |    |    |    |    |         \--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-codec:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    |    \--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |    +--- io.netty:netty-handler:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-resolver:4.1.93.Final (*)
+          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |    |    +--- io.netty:netty-transport-native-unix-common:4.1.93.Final
+          |    |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    |    |    \--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |    |    \--- io.netty:netty-codec:4.1.93.Final (*)
+          |    |    |    |    \--- io.netty:netty-codec-http:4.1.93.Final
+          |    |    |    |         +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |         +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |         +--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |         +--- io.netty:netty-codec:4.1.93.Final (*)
+          |    |    |    |         \--- io.netty:netty-handler:4.1.93.Final (*)
+          |    |    |    +--- io.netty:netty-handler-proxy:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |    +--- io.netty:netty-codec:4.1.93.Final (*)
+          |    |    |    |    +--- io.netty:netty-codec-socks:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-common:4.1.93.Final
+          |    |    |    |    |    +--- io.netty:netty-buffer:4.1.93.Final (*)
+          |    |    |    |    |    +--- io.netty:netty-transport:4.1.93.Final (*)
+          |    |    |    |    |    \--- io.netty:netty-codec:4.1.93.Final (*)
+          |    |    |    |    \--- io.netty:netty-codec-http:4.1.93.Final (*)
+          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.18.0
+          |    |    |    +--- io.perfmark:perfmark-api:0.26.0
+          |    |    |    \--- io.netty:netty-transport-native-unix-common:4.1.93.Final (*)
+          |    |    +--- io.grpc:grpc-protobuf:1.57.0
+          |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
+          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    |    +--- com.google.api.grpc:proto-google-common-protos:2.17.0
+          |    |    |    |    \--- com.google.protobuf:protobuf-java:3.21.12 -> 3.22.3
+          |    |    |    +--- io.grpc:grpc-protobuf-lite:1.57.0
+          |    |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
+          |    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    |    \--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    +--- io.grpc:grpc-stub:1.57.0
+          |    |    |    +--- io.grpc:grpc-api:1.57.0 (*)
+          |    |    |    +--- com.google.guava:guava:32.0.1-android -> 32.0.1-jre (*)
+          |    |    |    \--- com.google.errorprone:error_prone_annotations:2.18.0
+          |    |    +--- javax.annotation:javax.annotation-api:1.3.2
+          |    |    \--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    +--- com.android.tools.build:transform-api:2.0.0-deprecated-use-gradle-api
+          |    +--- org.apache.httpcomponents:httpmime:4.5.6 (*)
+          |    +--- commons-io:commons-io:2.13.0
+          |    +--- org.ow2.asm:asm:9.6
+          |    +--- org.ow2.asm:asm-analysis:9.6
+          |    |    \--- org.ow2.asm:asm-tree:9.6
+          |    |         \--- org.ow2.asm:asm:9.6
+          |    +--- org.ow2.asm:asm-commons:9.6
+          |    |    +--- org.ow2.asm:asm:9.6
+          |    |    \--- org.ow2.asm:asm-tree:9.6 (*)
+          |    +--- org.ow2.asm:asm-util:9.6
+          |    |    +--- org.ow2.asm:asm:9.6
+          |    |    +--- org.ow2.asm:asm-tree:9.6 (*)
+          |    |    \--- org.ow2.asm:asm-analysis:9.6 (*)
+          |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
+          |    +--- org.glassfish.jaxb:jaxb-runtime:2.3.2 (*)
+          |    +--- net.sf.jopt-simple:jopt-simple:4.9
+          |    +--- com.android.tools.build:bundletool:1.16.0
+          |    |    +--- com.android.tools.build:aapt2-proto:7.3.0-alpha07-8248216 -> 8.5.1-11315950 (*)
+          |    |    +--- com.google.auto.value:auto-value-annotations:1.6.2
+          |    |    +--- com.google.errorprone:error_prone_annotations:2.3.1 -> 2.18.0
+          |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    +--- com.google.protobuf:protobuf-java-util:3.22.3
+          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    |    |    +--- com.google.code.gson:gson:2.8.9 -> 2.10.1
+          |    |    |    +--- com.google.errorprone:error_prone_annotations:2.11.0 -> 2.18.0
+          |    |    |    +--- com.google.guava:guava:31.1-jre -> 32.0.1-jre (*)
+          |    |    |    \--- com.google.j2objc:j2objc-annotations:1.3 -> 2.8
+          |    |    +--- com.google.dagger:dagger:2.28.3
+          |    |    |    \--- javax.inject:javax.inject:1
+          |    |    +--- javax.inject:javax.inject:1
+          |    |    +--- org.bitbucket.b_c:jose4j:0.9.5
+          |    |    \--- org.slf4j:slf4j-api:1.7.30
+          |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10 (*)
+          |    +--- com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta10
+          |    |    +--- com.android.tools.build.jetifier:jetifier-core:1.0.0-beta10 (*)
+          |    |    +--- org.ow2.asm:asm:8.0.1 -> 9.6
+          |    |    +--- org.ow2.asm:asm-util:8.0.1 -> 9.6 (*)
+          |    |    +--- org.ow2.asm:asm-commons:8.0.1 -> 9.6 (*)
+          |    |    +--- org.jdom:jdom2:2.0.6
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 2.0.20 (*)
+          |    +--- com.squareup:javapoet:1.10.0 -> 1.13.0
+          |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    +--- com.google.protobuf:protobuf-java-util:3.22.3 (*)
+          |    +--- com.google.code.gson:gson:2.10.1
+          |    +--- io.grpc:grpc-core:1.57.0 (*)
+          |    +--- io.grpc:grpc-netty:1.57.0 (*)
+          |    +--- io.grpc:grpc-protobuf:1.57.0 (*)
+          |    +--- io.grpc:grpc-stub:1.57.0 (*)
+          |    +--- com.google.crypto.tink:tink:1.7.0
+          |    |    +--- com.google.protobuf:protobuf-java:3.19.3 -> 3.22.3
+          |    |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
+          |    +--- com.google.testing.platform:core-proto:0.0.9-alpha02
+          |    +--- net.sf.kxml:kxml2:2.3.0
+          |    +--- com.google.flatbuffers:flatbuffers-java:1.12.0
+          |    +--- org.tensorflow:tensorflow-lite-metadata:0.1.0-rc2
+          |    |    +--- org.checkerframework:checker-qual:2.5.8 -> 3.33.0
+          |    |    \--- com.google.flatbuffers:flatbuffers-java:1.12.0
+          |    +--- com.android.tools.build:builder:8.5.1
+          |    |    +--- com.android.tools.build:builder-model:8.5.1 (*)
+          |    |    +--- com.android.tools.build:builder-test-api:8.5.1 (*)
+          |    |    +--- com.android.tools:sdklib:31.5.1 (*)
+          |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
+          |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    +--- com.android.tools.ddms:ddmlib:31.5.1 (*)
+          |    |    +--- com.android:signflinger:8.5.1
+          |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    +--- com.android.tools.build:apksig:8.5.1
+          |    |    |    \--- com.android:zipflinger:8.5.1
+          |    |    |         \--- com.android.tools:annotations:31.5.1
+          |    |    +--- com.android.tools.analytics-library:protos:31.5.1 (*)
+          |    |    +--- com.android.tools.analytics-library:tracker:31.5.1
+          |    |    |    +--- com.android.tools.analytics-library:protos:31.5.1 (*)
+          |    |    |    +--- com.android.tools.analytics-library:shared:31.5.1 (*)
+          |    |    |    +--- com.android.tools:annotations:31.5.1
+          |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    |    +--- com.google.protobuf:protobuf-java:3.22.3
+          |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    +--- com.android.tools.layoutlib:layoutlib-api:31.5.1 (*)
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
+          |    |    +--- commons-codec:commons-codec:1.10 -> 1.11
+          |    |    +--- org.bouncycastle:bcprov-jdk18on:1.77
+          |    |    +--- javax.inject:javax.inject:1
+          |    |    +--- org.ow2.asm:asm-commons:9.6 (*)
+          |    |    +--- com.android.tools.build:manifest-merger:31.5.1
+          |    |    |    +--- com.android.tools:common:31.5.1 (*)
+          |    |    |    +--- com.android.tools:sdklib:31.5.1 (*)
+          |    |    |    +--- com.android.tools:sdk-common:31.5.1 (*)
+          |    |    |    +--- com.google.code.gson:gson:2.10.1
+          |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |    |    |    \--- net.sf.kxml:kxml2:2.3.0
+          |    |    +--- com.android:zipflinger:8.5.1 (*)
+          |    |    +--- com.android.tools.build:apksig:8.5.1
+          |    |    +--- com.android.tools.build:apkzlib:8.5.1
+          |    |    |    +--- com.android.tools.build:apksig:8.5.1
+          |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    |    |    +--- com.google.guava:guava:32.0.1-jre (*)
+          |    |    |    +--- org.bouncycastle:bcpkix-jdk18on:1.77 (*)
+          |    |    |    \--- org.bouncycastle:bcprov-jdk18on:1.77
+          |    |    \--- com.squareup:javawriter:2.5.0
+          |    +--- com.android.tools.build:builder-model:8.5.1 (*)
+          |    \--- com.android.tools.build:gradle-api:8.5.1
+          |         +--- com.android.tools.build:builder-test-api:8.5.1 (*)
+          |         +--- com.google.guava:guava:32.0.1-jre (*)
+          |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20 (*)
+          |         \--- org.ow2.asm:asm:9.6
+          +--- com.google.code.gson:gson:2.9.0 -> 2.10.1
+          +--- org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24 -> 2.0.21
+          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-model:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:compose-compiler-gradle-plugin:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-allopen:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-serialization:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21 (c)
+          |    |    +--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21 (c)
+          |    |    \--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21 (c)
+          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21 (*)
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21
+          |    |    |    +--- org.jetbrains.kotlin:kotlin-util-io:2.0.21
+          |    |    |    \--- org.jetbrains.kotlin:kotlin-util-klib:2.0.21
+          |    |    |         \--- org.jetbrains.kotlin:kotlin-util-io:2.0.21
+          |    |    \--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21
+          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-model:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-api:2.0.21 (*)
+          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugins-bom:2.0.21 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-tooling-core:2.0.21
+          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugin-annotations:2.0.21
+          |    +--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea-proto:2.0.21
+          |    |    \--- org.jetbrains.kotlin:kotlin-gradle-plugin-idea:2.0.21 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-klib-commonizer-api:2.0.21
+          |    |    \--- org.jetbrains.kotlin:kotlin-native-utils:2.0.21 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-build-tools-api:2.0.21
+          |    +--- org.jetbrains.kotlin:kotlin-build-statistics:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-build-tools-api:2.0.21
+          |    |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
+          |    +--- org.jetbrains.kotlin:kotlin-compiler-runner:2.0.21
+          |    |    +--- org.jetbrains.kotlin:kotlin-daemon-client:2.0.21
+          |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-util-klib:2.0.21 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-compiler-embeddable:2.0.21
+          |         +--- org.jetbrains.kotlin:kotlin-daemon-embeddable:2.0.21
+          |         +--- org.jetbrains.intellij.deps:trove4j:1.0.20200330
+          |         \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (*)
+          \--- androidx.navigation:navigation-safe-args-generator:2.8.3 (c)

wpmobilebot · 2024-10-18T12:41:40Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21312-c704bda
	Commit	`c704bda`
	Direct Download	`jetpack-prototype-build-pr21312-c704bda.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-10-18T12:44:19Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21312-c704bda
	Commit	`c704bda`
	Direct Download	`wordpress-prototype-build-pr21312-c704bda.apk`

Note: Google Login is not supported on these builds.

AdamGrzybkowski · 2024-10-28T13:42:34Z

I added unit-tests-exemption label because Danger was complaining about the lack of tests for GravatarQuickEditorFeatureConfig. From what I've checked, those types of classes are not tested in the WP repo.

AdamGrzybkowski · 2024-10-29T10:12:42Z

There seems to be some kind of Lint issue with the navigation-compose library from the QuickEditor... I will mark it as a draft until I figure it out.

AdamGrzybkowski · 2024-10-30T09:36:49Z

gradle/libs.versions.toml

@@ -19,7 +19,7 @@ androidx-constraintlayout-compose = '1.0.1'
 androidx-core = '1.13.1'
 androidx-fragment = '1.8.4'
 androidx-lifecycle = '2.8.5'
-androidx-navigation = '2.7.7'
+androidx-navigation = '2.8.3'


There's a bug in 2.8.1 (used by QuickEditor) that causes some Lint warnings. WP is configured to fail on those so I had to bump the library here to fix the issue.

Here's the issue tracker with a bit more info - https://issuetracker.google.com/issues/368070326

We will update the library in the Gravatar SDK as well, but for now, this should do the trick.

@nbradbury Any thoughts on this?

Normally I'd opt for updating a library in a dedicated PR, but I just tested the app separately with androidx-navigation v2.8.3 and ran into no problems, so I'm fine with updating it here.

codecov · 2024-10-30T10:02:33Z

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (8699f1d) to head (c704bda).
Report is 27 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...java/org/wordpress/android/util/WPAvatarUtils.java	0.00%	7 Missing ⚠️
...ordpress/android/ui/main/utils/MeGravatarLoader.kt	0.00%	5 Missing ⚠️
...id/util/config/GravatarQuickEditorFeatureConfig.kt	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #21312      +/-   ##
==========================================
- Coverage   39.50%   39.49%   -0.01%     
==========================================
  Files        2120     2121       +1     
  Lines       99438    99467      +29     
  Branches    15282    15286       +4     
==========================================
+ Hits        39281    39286       +5     
- Misses      56675    56699      +24     
  Partials     3482     3482

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nbradbury · 2024-10-30T12:25:40Z

The QuickEditor is very nice! I have some feedback on it that's separate from this PR.

If I deny camera permission then try to take a photo, I see this dialog. This is fine, but it would be nicer if the dialog enabled the user to go directly to the app settings.

The QuickEditor has a "Done" button at the top left which seems odd to me. A standard X button seems better.

After I tap an image to make it my profile photo, there's a two-second delay before I see the toast informing me the photo was updated. Is there a way to provide immediate feedback? Also, the wording "May take a few minutes to appear everywhere" seems clipped. Should that be "It may take a few minutes to appear everywhere"?

delay.mp4

nbradbury

@AdamGrzybkowski I'm approving this PR, feel free to merge when ready but note that as with the parent PR, I'm unable to test the SignupEpilogueFragment.

AdamGrzybkowski · 2024-10-30T12:40:27Z

If I deny camera permission then try to take a photo, I see this dialog. This is fine, but it would be nicer if the dialog enabled the user to go directly to the app settings.

That makes sense, I will see what can we do here from an SDK perspective. Issue created - Automattic/Gravatar-SDK-Android#422

The QuickEditor has a "Done" button at the top left which seems odd to me. A standard X button seems better.

We followed the designs, but yeah in the Android world an x is more common, I think. Will talk with the team.

After I tap an image to make it my profile photo, there's a two-second delay before I see the toast informing me the photo was updated. I see the toast informing me the photo was updated. Is there a way to provide immediate feedback?

We show the confirmation when the avatar is updated. We could assume a positive result and do that instantly, but we opted for a progress indicator instead. Have you missed it?

Also, the wording "May take a few minutes to appear everywhere" seems clipped. Should that be "It may take a few minutes to appear everywhere"?

Yes, thanks for catching that! Issue - Automattic/Gravatar-SDK-Android#423

nbradbury · 2024-10-30T13:06:40Z

We could assume a positive result and do that instantly, but we opted for a progress indicator instead. Have you missed it?

Oh, yes - I did miss the progress indicator. It's a bit subtle, but I confess to not having super vision so it's likely my fault I missed it :)

AdamGrzybkowski · 2024-10-30T13:29:41Z

Oh, yes - I did miss the progress indicator. It's a bit subtle, but I confess to not having super vision so it's likely my fault I missed it :)

I think we can work on a better contrast there as well. Thanks for the feedback!

…ditor

AdamGrzybkowski · 2024-11-12T13:42:44Z

@hamorillo When you have time, would you mind reviewing and testing this integration? 🙏

hamorillo · 2024-11-12T14:57:09Z

💡 I wonder if, after switching avatars, we should keep the forceRefresh enabled after every onResume to avoid the following case:

Kapture.2024-11-12.at.15.50.43.mp4

Appart from that, LGTM!

hamorillo · 2024-11-12T14:59:43Z

Another minor detail (which probably is easy to say but more complicated to fix) is that we are not updating the avatar in the bottom bar:

AdamGrzybkowski · 2024-11-13T09:56:28Z

Another minor detail (which probably is easy to say but more complicated to fix) is that we are not updating the avatar in the bottom bar:

I know about this, but this issue was there before. So it should be tackled separately as it's not directly tied to the QE.

AdamGrzybkowski · 2024-11-13T09:57:24Z

💡 I wonder if, after switching avatars, we should keep the forceRefresh enabled after every onResume to avoid the following case:

I think we should, it's a bit annoying because the forceRefresh becomes the new default 🙄

hamorillo · 2024-11-13T10:44:39Z

I think we should, it's a bit annoying because the forceRefresh becomes the new default 🙄

I agree it's a pain. In this case, we can only enable it after switching avatars, which won't be very common. :(

AdamGrzybkowski · 2024-11-13T14:51:08Z

I agree it's a pain. In this case, we can only enable it after switching avatars, which won't be very common. :(

I think I was able to solve this without using the forceRefresh too often. There's this bitmap cache that is used to store the Avatar so I'm now caching a new bitmap for the avatarUrl (without the force refresh random string query part) when a new one was selected.

@hamorillo Can you try it?

sonarcloud · 2024-11-13T14:54:52Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AdamGrzybkowski · 2024-11-13T16:19:31Z

@nbradbury Could you give me access to Firebase or tell me which tests have failed? I'm running tests locally, but those that failed seem to be unrelated to my changes so I wonder if different ones failed on CI.

nbradbury · 2024-11-13T18:23:39Z

Could you give me access to Firebase or tell me which tests have failed?

@AdamGrzybkowski I'm not sure I can give you access to Firebase. @wzieba @ParaskP7 Is this something you can do?

I'm running tests locally, but those that failed seem to be unrelated to my changes so I wonder if different ones failed on CI.

You're right, it's the e2ee tests that are failing, which are unrelated. I'll do a rebuild in CI and see if that fixes the problem.

Update: Rebuilding solved the problem. Apologies for the false alarm!

AdamGrzybkowski · 2024-11-14T08:41:52Z

@nbradbury Thanks! I rerun the build yesterday but it failed again. I guess some external factors were in play.

ParaskP7 · 2024-11-14T08:57:04Z

@AdamGrzybkowski I'm not sure I can give you access to Firebase. @wzieba @ParaskP7 Is this something you can do?

Hey @AdamGrzybkowski @nbradbury , thanks for the ping, you would need to post a System Request for Firebase access (example: pMz3w-c9y-p2).

AdamGrzybkowski · 2024-11-14T08:58:37Z

@ParaskP7 No need for that. It seems like these were some flaky tests and I no longer need access to Firebase to check them.

hamorillo

@AdamGrzybkowski, I confirm it works great for me!

AdamGrzybkowski added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Oct 18, 2024

AdamGrzybkowski force-pushed the adam/gravatar_2.0.0 branch 2 times, most recently from 53bc90f to 926eb61 Compare October 25, 2024 12:47

AdamGrzybkowski added the Gravatar Gravatar integration label Oct 28, 2024

AdamGrzybkowski added 6 commits October 28, 2024 11:56

Add gravatar-quickeditor dependency

aba43f8

Use Automattic uCrop fork

82b1b3e

Fix deprecation issues from newer foundation library

d8aba3b

Setup remote feature flag for quick editor

4e75b4c

Show Gravatar QuickEditor on Avatar tap

0d378f9

Add QuickEditor to SignupEpilogueFragment

befee3c

AdamGrzybkowski force-pushed the adam/gravatar_quickeditor branch from 6d1bc0a to befee3c Compare October 28, 2024 13:36

AdamGrzybkowski added the unit-tests-exemption label Oct 28, 2024

AdamGrzybkowski marked this pull request as ready for review October 28, 2024 13:51

AdamGrzybkowski requested review from a team and nbradbury and removed request for a team October 28, 2024 13:52

AdamGrzybkowski removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Oct 28, 2024

AdamGrzybkowski marked this pull request as draft October 29, 2024 10:12

Bump navigation-compose to 2.8.3 to fix lint errors

b62a12a

AdamGrzybkowski marked this pull request as ready for review October 30, 2024 09:34

AdamGrzybkowski commented Oct 30, 2024

View reviewed changes

nbradbury approved these changes Oct 30, 2024

View reviewed changes

AdamGrzybkowski mentioned this pull request Oct 30, 2024

Improve the permission rationale dialog UI Automattic/Gravatar-SDK-Android#422

Open

nbradbury self-assigned this Oct 30, 2024

Base automatically changed from adam/gravatar_2.0.0 to trunk November 12, 2024 12:33

Merge remote-tracking branch 'origin/trunk' into adam/gravatar_quicke…

a2a35ed

…ditor

AdamGrzybkowski requested a review from hamorillo November 12, 2024 13:42

AdamGrzybkowski mentioned this pull request Nov 12, 2024

Improve contrast of the progress bar when uploading a new Avatar Automattic/Gravatar-SDK-Android#436

Closed

AdamGrzybkowski added this to the 25.8 milestone Nov 13, 2024

Store updated avatar in the bitmap cache

c704bda

hamorillo approved these changes Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Gravatar QuickEditor #21312

Implement Gravatar QuickEditor #21312

AdamGrzybkowski commented Oct 18, 2024 •

edited

Loading

dangermattic commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

AdamGrzybkowski commented Oct 28, 2024

AdamGrzybkowski commented Oct 29, 2024

AdamGrzybkowski Oct 30, 2024

nbradbury Oct 30, 2024

codecov bot commented Oct 30, 2024 •

edited

Loading

nbradbury commented Oct 30, 2024

nbradbury left a comment

AdamGrzybkowski commented Oct 30, 2024

nbradbury commented Oct 30, 2024

AdamGrzybkowski commented Oct 30, 2024

AdamGrzybkowski commented Nov 12, 2024

hamorillo commented Nov 12, 2024

hamorillo commented Nov 12, 2024

AdamGrzybkowski commented Nov 13, 2024

AdamGrzybkowski commented Nov 13, 2024

hamorillo commented Nov 13, 2024

AdamGrzybkowski commented Nov 13, 2024

sonarcloud bot commented Nov 13, 2024

AdamGrzybkowski commented Nov 13, 2024

nbradbury commented Nov 13, 2024 •

edited

Loading

AdamGrzybkowski commented Nov 14, 2024

ParaskP7 commented Nov 14, 2024

AdamGrzybkowski commented Nov 14, 2024

hamorillo left a comment

Implement Gravatar QuickEditor #21312

Are you sure you want to change the base?

Implement Gravatar QuickEditor #21312

Conversation

AdamGrzybkowski commented Oct 18, 2024 • edited Loading

To Test:

Regression Notes

PR Submission Checklist:

Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented Oct 18, 2024 • edited Loading

wpmobilebot commented Oct 18, 2024 • edited Loading

Project dependencies changes

Build environment changes

wpmobilebot commented Oct 18, 2024 • edited Loading

wpmobilebot commented Oct 18, 2024 • edited Loading

AdamGrzybkowski commented Oct 28, 2024

AdamGrzybkowski commented Oct 29, 2024

AdamGrzybkowski Oct 30, 2024

Choose a reason for hiding this comment

nbradbury Oct 30, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 30, 2024 • edited Loading

Codecov Report

nbradbury commented Oct 30, 2024

nbradbury left a comment

Choose a reason for hiding this comment

AdamGrzybkowski commented Oct 30, 2024

nbradbury commented Oct 30, 2024

AdamGrzybkowski commented Oct 30, 2024

AdamGrzybkowski commented Nov 12, 2024

hamorillo commented Nov 12, 2024

hamorillo commented Nov 12, 2024

AdamGrzybkowski commented Nov 13, 2024

AdamGrzybkowski commented Nov 13, 2024

hamorillo commented Nov 13, 2024

AdamGrzybkowski commented Nov 13, 2024

sonarcloud bot commented Nov 13, 2024

Quality Gate passed

AdamGrzybkowski commented Nov 13, 2024

nbradbury commented Nov 13, 2024 • edited Loading

AdamGrzybkowski commented Nov 14, 2024

ParaskP7 commented Nov 14, 2024

AdamGrzybkowski commented Nov 14, 2024

hamorillo left a comment

Choose a reason for hiding this comment

AdamGrzybkowski commented Oct 18, 2024 •

edited

Loading

dangermattic commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

wpmobilebot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading

nbradbury commented Nov 13, 2024 •

edited

Loading