Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/prefs privacy m3 #21446

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Issue/prefs privacy m3 #21446

merged 3 commits into from
Nov 13, 2024

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Nov 11, 2024

This small PR updates our privacy screen to Material 3. To test:

  • Change this function to always return true
  • Start the app and verify that the privacy screen looks as expected

privacy

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 11, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Nov 11, 2024

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21446-8b84c8d
Commit8b84c8d
Direct Downloadjetpack-prototype-build-pr21446-8b84c8d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21446-8b84c8d
Commit8b84c8d
Direct Downloadwordpress-prototype-build-pr21446-8b84c8d.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (ae41f3f) to head (8b84c8d).
Report is 35 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/prefs/privacy/banner/PrivacyBannerScreen.kt 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21446   +/-   ##
=======================================
  Coverage   39.50%   39.50%           
=======================================
  Files        2120     2120           
  Lines       99438    99438           
  Branches    15282    15282           
=======================================
  Hits        39281    39281           
  Misses      56675    56675           
  Partials     3482     3482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury marked this pull request as ready for review November 13, 2024 18:31
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound, testing succeeded.

@nbradbury nbradbury merged commit 7553850 into trunk Nov 13, 2024
24 checks passed
@nbradbury nbradbury deleted the issue/prefs-privacy-m3 branch November 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants