Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mingw detection in ucrt64 environment #3961

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix mingw detection in ucrt64 environment #3961

merged 1 commit into from
Jul 13, 2023

Conversation

calebkiage
Copy link
Contributor

#3960

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@calebkiage
Copy link
Contributor Author

Should is_host("windows") be replaced with is_host("windows") and not is_subhost("msys", "cygwin") in lua?

@waruqi
Copy link
Member

waruqi commented Jul 13, 2023

Should is_host("windows") be replaced with is_host("windows") and not is_subhost("msys", "cygwin") in lua?

no, msys/cygwin is also on windows

@waruqi waruqi merged commit 8ea20fc into xmake-io:dev Jul 13, 2023
@calebkiage calebkiage deleted the msys-ucrt64 branch July 13, 2023 06:12
@calebkiage
Copy link
Contributor Author

Yes, but the msys shell behaves like linux.
For example:

    if is_host("windows") and not opt.rawargs then
        argv = winos.cmdargv(argv, {escape = true})
    end

msys shell shouldn't have a character limit

@waruqi
Copy link
Member

waruqi commented Jul 13, 2023

Yes, but the msys shell behaves like linux. For example:

    if is_host("windows") and not opt.rawargs then
        argv = winos.cmdargv(argv, {escape = true})
    end

msys shell shouldn't have a character limit

this limit is from CreateProcess, not shell. msys2 has also this problem.

@calebkiage
Copy link
Contributor Author

What about /dev/null handling?

@waruqi
Copy link
Member

waruqi commented Jul 13, 2023

please use os.nuldev()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants