Fix: Loading fixtures, does not update sequence (Postgres) #20346
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtangoo
commented
Mar 25, 2025
•
mtangoo
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #8298 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20346 +/- ##
============================================
- Coverage 64.85% 63.44% -1.41%
- Complexity 11437 11438 +1
============================================
Files 431 431
Lines 37199 37201 +2
============================================
- Hits 24125 23602 -523
- Misses 13074 13599 +525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
approved these changes
Mar 25, 2025
framework/CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Yii Framework 2 Change Log | |||
|
|
|||
| - Enh #20309: Add custom attributes support to style tags (nzwz) | |||
| - Bug #20329: pgsql: Column Schema doesn't recognize PG type cast (arkhamvm) | |||
| - Bug #8298 Loading fixtures, does not update sequence (mtangoo) | |||
There was a problem hiding this comment.
Suggested change
| - Bug #8298 Loading fixtures, does not update sequence (mtangoo) | |
| - Bug #8298: Loading fixtures should not update sequence (mtangoo) |
There was a problem hiding this comment.
actually the bug is, when it loads fixtures it fails to update the sequece. So this PR is addressing that.
Arhell
approved these changes
Mar 26, 2025
done |
samdark
reviewed
Mar 26, 2025
|
Is changelog good now? |
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
While Upgrade file is fine (and comitted) change log is not. It does not correctly explain the bug (#8298) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.