Implement IAMF v1.0.0 errata changes #3337
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picks https://chromium-review.googlesource.com/c/chromium/src/+/5128755 and adds minor changes to allow it to build. Original CL description follows. Adds an IAMF codec definition and implements IAMF MP4 parsing for v1.0.0. The implementation is disabled by default. Immersive Audio Model and Formats v1.0.0 https://aomediacodec.github.io/iamf/v1.0.0.html b/271301103 Removes string_view to build on 24.lts.
Has Cobalt recognize the Chrome `AudioCodec::kIAMF` as the Cobalt `kSbMediaAudioCodecIamf`, allowing Cobalt to handle IAMF streams. b/271301103
Updates the IAMF mp4 parsing implementation to support v1.0.0-errata. Streams configured with the original v1.0.0 spec are no longer supported. Changes are pulled from Chromium. Original CL descriptions follow: Update IAMF mp4 parsing implementation Updates the IAMF parsing implemenation to parse the IA Configuration Box defined in the IAMF v1.0.0-errata specification. https://aomediacodec.github.io/iamf/v1.0.0-errata.html#iaconfigurationbox-section Bug: b/340618404 Change-Id: I1467e60928ac28e0ead4a9e0f3857b6c5540c7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550540 Reviewed-by: Mark Foltz <[email protected]> Commit-Queue: Austin Osagie <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304144} Fix iacb atom parsing error Fixes an error in a previous change that parses the iamf atom instead of the iacb atom. Now, the iacb atom is properly read. Bug: b/340618404 Change-Id: I61d8c8c2758c9181b40ff6e99da24c790b202687
osagie98
force-pushed
the
iamf-errata-fix
branch
from
2ca82de
to
c0bc2b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the IAMF mp4 parsing implementation to support v1.0.0-errata.
Streams configured with the original v1.0.0 spec are no longer
supported.