Fix proxy configuration crash #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: In url_request_context.cc, we reset proxy_resolution_service_. However, in http_network_session, we store the original proxy_resolution_service_. From url_request_context.cc, if we delete the orignal proxy_resolution_service and create a new object, http_network_session may still try to access the orignal object. This will trigger the heap-use-after-free error. b/346555722
kaidokert
changed the title
kaidokert
approved these changes
Jun 14, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Bug: In url_request_context.cc, we reset proxy_resolution_service_. However, in http_network_session, we store the original proxy_resolution_service_. From url_request_context.cc, if we delete the orignal proxy_resolution_service and create a new object, http_network_session may still try to access the orignal object. This will trigger the heap-use-after-free error. b/346555722 (cherry picked from commit 3a90c17)
kaidokert
pushed a commit
that referenced
this pull request
Jun 14, 2024
Refer to the original PR: #3563 Bug: In url_request_context.cc, we reset proxy_resolution_service_. However, in http_network_session, we store the original proxy_resolution_service_. From url_request_context.cc, if we delete the orignal proxy_resolution_service and create a new object, http_network_session may still try to access the orignal object. This will trigger the heap-use-after-free error. b/346555722 Co-authored-by: Sherry Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
In url_request_context.cc, we reset proxy_resolution_service_. However, in http_network_session, we store the original proxy_resolution_service_. From url_request_context.cc, if we delete the orignal proxy_resolution_service and create a new object, http_network_session may still try to access the orignal object. This will trigger the heap-use-after-free error.
b/346555722