Cleanup codebase by running pre-commit. #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantting
requested review from
dahlstrom-g,
kaidokert and
andrewsavage1
and removed request for
dahlstrom-g
kaidokert
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Everything under .github and chrobalt/ and in precommit yaml is fine to land.
However, i didn't expect such a huge churn and diff under /starboard, i think maybe we left some of Pylint / CPPLint config files behind that were previously ignoring a bunch of style diffs ?
Can you bring the config files back and re-run ? That would be .clang-format at the toplevel and .pylintrc and .style.yapf
Oh i get it now - we have new |
.clang-format will not be added as Cobalt's .clang-format is a subset of Chromium's .clang-format that will be replacing it at the top level. Cobalt will conform to Chromium's style. .pylintrc will be added at the top level of Chrobalt as Chromium does not use pylint so .pylintrc will only apply to Cobalt. .style.yapf will be added to Cobalt directories as Chromium does use yapf so Chrobalt will avoid any top level changes that will affect Chromium.
cpplint, pylint, and gcheckstyle errors remain.
cpplint and pylint errors remain.
kaidokert
approved these changes
Oct 14, 2024
There remain 3 pylint "too many positional arguments" failures. These will not be resolved here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/371604735