Jni debugging and actual workaround #4358
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @johnxwork work here: #4353
Lots of printf debugging
Fixing initialization order. JNI_OnLoad needs to happen first, then StarboardBridge, and then Content
JNI_VERSION_1_6 and JNI_VERSION_1_4 mismatch
And finally, the actual key problem: With multiple dynamic libraries, everyone gets their own copy of the
g_vm
variables in JniEnvExt. The only actual way to solve this is to move those variables into a standalone library/module ( example:starboard_jnienv
). This ensures all callers "see" the same instance of it. ( print out variable pointers to ensure )This problem is likely present elsewhere in Starboard where it uses lots of globals. Also likely not an issue in release builds where it's all one single
.so