Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jni debugging and actual workaround #4358

Closed
wants to merge 2 commits into from
Closed

Conversation

kaidokert
Copy link
Member

Based on @johnxwork work here: #4353

  • Lots of printf debugging

  • Fixing initialization order. JNI_OnLoad needs to happen first, then StarboardBridge, and then Content

  • JNI_VERSION_1_6 and JNI_VERSION_1_4 mismatch

  • And finally, the actual key problem: With multiple dynamic libraries, everyone gets their own copy of the g_vm variables in JniEnvExt. The only actual way to solve this is to move those variables into a standalone library/module ( example: starboard_jnienv). This ensures all callers "see" the same instance of it. ( print out variable pointers to ensure )

  • This problem is likely present elsewhere in Starboard where it uses lots of globals. Also likely not an issue in release builds where it's all one single .so

@kaidokert kaidokert closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants