Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable leanback styles #4404

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Re-enable leanback styles #4404

merged 1 commit into from
Nov 12, 2024
+6 −12

Conversation

zhongqiliang
Copy link
Contributor

@zhongqiliang zhongqiliang commented Nov 8, 2024 •
edited
Loading

b/375037287

@zhongqiliang zhongqiliang requested a review from a team as a code owner November 8, 2024 19:07
@zhongqiliang zhongqiliang requested review from kaidokert, johnxwork and yell0wd0g and removed request for kaidokert and johnxwork November 8, 2024 19:07
@kaidokert
Copy link
Member

Build failed because of some missing GN dependencies - can you have a quick look please ?

johnxwork
johnxwork approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@johnxwork johnxwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as build passes this is great

@zhongqiliang zhongqiliang merged commit 20617c9 into youtube:main Nov 12, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnxwork johnxwork johnxwork approved these changes

@yell0wd0g yell0wd0g Awaiting requested review from yell0wd0g

@kaidokert kaidokert Awaiting requested review from kaidokert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongqiliang @kaidokert @johnxwork