Merge pull request #430 from nicksay/timing-test-resolution

Improve test reliability on platforms with clock skew
youtube · Dec 15, 2016 · cf845f8 · cf845f8
2 parents eac1c97 + 3d608ce
commit cf845f8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/client/cache/cache_test.js b/src/client/cache/cache_test.js
@@ -21,7 +21,7 @@ describe('spf.cache', function() {
     time = { advance: 0 };
     spf.__now = spf.now;
     spf.now = function() {
-      return (+new Date()) + time.advance;
+      return (new Date()).getTime() + time.advance;
     };
     // Reset.
     storage = spf.cache.storage_();

diff --git a/src/client/history/history_test.js b/src/client/history/history_test.js
@@ -50,7 +50,7 @@ describe('spf.history', function() {
     time = { advance: 0 };
     spf.__now = spf.now;
     spf.now = function() {
-      return (+new Date()) + time.advance;
+      return (new Date()).getTime() + time.advance;
     };
     // Init.
     callbacks = {

diff --git a/src/client/nav/request_test.js b/src/client/nav/request_test.js
@@ -920,7 +920,7 @@ describe('spf.nav.request', function() {
     it('regular: single, navigation timing', function() {
       var url = '/page';
       var text = '{}';
-      var startTime = new Date().getTime() - 1;
+      var startTime = spf.now() - 1;
       var fake = createFakeRegularXHR(text);
       spf.net.xhr.get = jasmine.createSpy('xhr.get').and.callFake(fake);
 
@@ -938,7 +938,7 @@ describe('spf.nav.request', function() {
     it('cached: single, navigation timing', function() {
       var url = '/page';
       var res = {'foo': 'FOO', 'bar': 'BAR'};
-      var startTime = new Date().getTime() - 1;
+      var startTime = spf.now() - 1;
 
       var cacheKey = 'prefetch ' + spf.url.absolute(url);
       var cacheObject = {