Full body response on onError option for spf.navigate #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @private | ||
| */ | ||
| spf.nav.handleNavigateError_ = function(options, url, err) { | ||
| spf.nav.handleNavigateError_ = function(options, url, err, xhr) { |
There was a problem hiding this comment.
Nit: Optional fields should be named opt_*
|
Whoops, this one slipped a bit. The changes look good. Could you squash the commits into one? Then we'll go ahead and merge it in. |
|
it's done. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we just received on simple detail.err string for failed navigate on option onError, I've added a detail.xhr with the full XMLHttpRequest in order to have more detail and responseText for debuging or displaying