Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to consider all requests chunked #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thibPG
Copy link

@thibPG thibPG commented Apr 10, 2020

Add a configuration option used to explicitly assume all json requests will be chunked. This can be used as an alternative to SPDY detection (based on the primary document load state).

src/client/net/xhr.js Outdated Show resolved Hide resolved
@thibPG
Copy link
Author

thibPG commented Apr 11, 2020

Updated build configuration; Added an option to skip manual java check since environment is controlled in travis (and parsing of java -version is not successful); Also updated util.error to console.error since util.error is deprecated.

@thibPG
Copy link
Author

thibPG commented Apr 11, 2020

Note for reviewer / repo owner: repo config might need to be updated

displaying "waiting for status to be reported" but build is successful:
https://travis-ci.org/github/youtube/spfjs/builds/673664970

Could travis-ci/travis-ci#10204 be the cause ?

https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154

bin/configure.js Show resolved Hide resolved
bin/calcdeps.js Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants