-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #157 and #160 #161
Fixes #157 and #160 #161
Conversation
I don't see any problems for Carthage, as this is just the podspec being updated |
@nvh The issue is with cocoa pods not with carthage. thanks |
@nvh That was very observant. Good job. |
Why am I being mentioned here then? I'm neither a maintainer nor an active contributor to this repo, the only thing I did was add a PR for Carthage support a while back. |
@iulukaya Please push fixed |
Until the podspec is pushed into CocoaPods. Specifying the repo is the way to go.
|
when will this be added to a new release? |
For developers
In order for changes to kick in you must push fixed
.podspec
file to repository.And check in future if your stuff is working before releasing it.
For users
You may need to remove your cached
youtube-ios-player-helper
pod from working folder and global cache folder, and pull pods again, like here.Fixed issues
YTPlayerView
loadWithVideoId
do not work since version 0.1.5 #160