Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #157 and #160 #161

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Fixes #157 and #160 #161

merged 1 commit into from
Dec 3, 2015

Conversation

Skogetroll
Copy link
Contributor

For developers

In order for changes to kick in you must push fixed .podspec file to repository.

And check in future if your stuff is working before releasing it.

For users

You may need to remove your cached youtube-ios-player-helper pod from working folder and global cache folder, and pull pods again, like here.

Fixed issues

@jgrana
Copy link

jgrana commented Nov 28, 2015

@iulukaya @nvh Could we merge this fix in? Thanks

@tomermobli
Copy link

@iulukaya @nvh please merge

@nvh
Copy link
Contributor

nvh commented Nov 30, 2015

I don't see any problems for Carthage, as this is just the podspec being updated

@tomermobli
Copy link

@nvh The issue is with cocoa pods not with carthage. thanks

@Skogetroll
Copy link
Contributor Author

I don't see any problems for Carthage, as this is just the podspec being updated

@nvh That was very observant. Good job.

@nvh
Copy link
Contributor

nvh commented Dec 1, 2015

Why am I being mentioned here then? I'm neither a maintainer nor an active contributor to this repo, the only thing I did was add a PR for Carthage support a while back.

ulukaya added a commit that referenced this pull request Dec 3, 2015
@ulukaya ulukaya merged commit 1d73019 into youtube:master Dec 3, 2015
@tuantmdev
Copy link

@iulukaya Please push fixed .podspec file to pod repository.

@mlomeli
Copy link

mlomeli commented Dec 17, 2015

Until the podspec is pushed into CocoaPods. Specifying the repo is the way to go.

pod 'youtube-ios-player-helper', :git => 'https://github.com/youtube/youtube-ios-player-helper'

@MrMatthewDavis
Copy link

when will this be added to a new release?

@Skogetroll Skogetroll deleted the Assets.bundle branch March 14, 2016 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants