The following modules should not need to be loaded in the head:
"ext.centralNotice.bannerController.mobiledevice",
"ext.centralNotice.bannerController.mobile", "ext.centralNotice.bannerController.lib", "ext.centralNotice.bannerChoiceData",
The following modules should not need to be loaded in the head:
"ext.centralNotice.bannerController.mobiledevice",
"ext.centralNotice.bannerController.mobile", "ext.centralNotice.bannerController.lib", "ext.centralNotice.bannerChoiceData",
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | None | T100255 [EPIC] Load ResourceLoader startup module from the bottom of the HTML | |||
Open | None | T100372 CentralNotice mobile modules should not be loaded in the head |
This is trickier than it first seems but I did find a way but this patch manages to save 5.3kb off when we're not running a campaign: https://gerrit.wikimedia.org/r/213990
Hey @Jdlrobson you should add @AndyRussG to the reviewers for that patch since he's our CN Czar these days :)
I'll add it to "review" in our next sprint, too.
Change 213990 had a related patch set uploaded (by Phuedx):
Save 5.3k whenever a campaign is not running
Change 217303 had a related patch set uploaded (by AndyRussG):
Don't merge -- Proof-of-concept -- Load campaign/banner selection code as dynamic dependency of choiceData
It's not merged yet @atgo :) Would be great if our teams could pair on this and work out how to fix this!
I'd say not! :) This WIP patch does more or less the same. I was planning to add this task as a bug tag in the next PS...
Change 221759 had a related patch set uploaded (by AndyRussG):
WIP - Don't merge but please review - Refactor client-side API and RL modules for banner display
The current patch for review, like the previous one, significantly reduces the code sent to users not targeted by a campaign who receive no possible campaigns from the server. It should also improve performance in other ways... I'd love to learn more details of where the bottlenecks are now--benchmarking, anyone? ;)
Change 221759 merged by jenkins-bot:
Refactor client-side API and RL modules for banner display
Change 217303 abandoned by AndyRussG:
Don't merge -- Proof-of-concept -- Load campaign/banner selection code as dynamic dependency of choiceData
@AndyRussG: All related patches in Gerrit have been merged or abandoned. Is there more to do in this task? Asking as you are set as task assignee.
(You can change the task status via Add Action... → Change Status in the dropdown menu.)
This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!
For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)