Page MenuHomePhabricator
Create Task
Maniphest T102581

Create a separate list of suppression-only reasons for Special:RevisionDelete
Closed, ResolvedPublic
Actions

Description

On wikis such as the English Wikipedia, the dropdown of pre-filled reasons for deleting a revision that's on Special:RevisionDelete has messages for people with suppression. Although the tick box to actually suppress the edit is only displayed if you have the ability to do suppress edits, the messages in the dropdown are displayed regardless. They probably shouldn't be, considering it's not possible to legitimately use them if you're not capable of suppressing edits.

We should support displaying the dropdown messages conditionally somehow.

Details

SubjectRepoBranchLines +/-
Split reason dropdown list on Special:RevisionDeletemediawiki/coremaster+27 -3
Customize query in gerrit

Related Objects

Event Timeline

• Deskana created this task.Jun 16 2015, 5:28 AM
• Deskana raised the priority of this task from to Low.
• Deskana updated the task description. (Show Details)
• Deskana added a project: MediaWiki-Revision-deletion.
• Deskana subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2015, 5:28 AM
FreeRangeFrog subscribed.Jun 16 2015, 5:35 AM
Callanecc subscribed.Jun 16 2015, 11:32 AM
Krenair renamed this task from Stop dropdown on Special:RevisionDelete from displaying suppression-only messages to Create a separate list of suppression-only reasons for Special:RevisionDelete.Jun 16 2015, 5:29 PM
Krenair set Security to None.
Krenair added a project: good first task.Jun 16 2015, 5:49 PM
Krenair subscribed.

Sounds easy enough

Nyttend subscribed.Jun 18 2015, 3:01 PM

I would appreciate it; even if you know that you shouldn't use the bottom-of-dropdown reasons, it's always possible to forget or to pick them by accident when you're trying to use a totally different rationale. Much easier to remove those reasons from view entirely for us "normal" admins, to prevent mistakes.

gerritbot subscribed.Sep 18 2018, 7:22 PM

Change 461194 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Split reason dropdown list on Special:RevisionDelete

https://gerrit.wikimedia.org/r/461194

gerritbot added a project: Patch-For-Review.Sep 18 2018, 7:22 PM
Umherirrender claimed this task.Sep 18 2018, 7:23 PM
JEumerus subscribed.Sep 19 2018, 7:59 AM

Actually, the suppression reasons are sometimes used by admins on enwiki ... when we get across something that probably merits suppression we often hide it pre-emptively before informing the oversight team to get it out of sight faster. The oversight team then has to judge whether it merits the full memory hole.

gerritbot added a comment.Apr 11 2019, 4:21 PM

Change 461194 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Split reason dropdown list on Special:RevisionDelete

https://gerrit.wikimedia.org/r/461194

DannyS712 subscribed.Jun 3 2019, 2:56 AM
gerritbot added a comment.Oct 7 2019, 7:44 PM

Change 461194 merged by jenkins-bot:
[mediawiki/core@master] Split reason dropdown list on Special:RevisionDelete

https://gerrit.wikimedia.org/r/461194

Umherirrender closed this task as Resolved.Oct 7 2019, 7:48 PM

The new message for the reasons is MediaWiki:revdelete-reason-dropdown-suppress, the old message is kept. Needs moving on each wiki when needed.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 7 2019, 8:00 PM
Amorymeltzer subscribed.Feb 17 2020, 11:03 AM
Amorymeltzer awarded a token.Feb 17 2020, 11:08 AM
Amorymeltzer added a comment.Feb 23 2020, 4:51 PM

@Umherirrender, et al.: this is much appreciated, but as-yet incomplete. AFAICT, the dropdown for AbuseFilter entries still only draws from MediaWiki:Revdelete-reason-dropdown and doesn't account for the new page. I can open a new task if you like, but since AF logs can only be suppressed, not revision-deleted, that means the new page can't really be used.

It would seem reasonable to me for the AF dropdown to only pull from this new page, but in practice it should probably take both as well.

Masumrezarock100 removed a project: Patch-For-Review.Feb 23 2020, 5:02 PM
Umherirrender added a comment.Feb 23 2020, 8:41 PM
In T102581#5910460, @Amorymeltzer wrote:

@Umherirrender, et al.: this is much appreciated, but as-yet incomplete. AFAICT, the dropdown for AbuseFilter entries still only draws from MediaWiki:Revdelete-reason-dropdown and doesn't account for the new page. I can open a new task if you like, but since AF logs can only be suppressed, not revision-deleted, that means the new page can't really be used.

It would seem reasonable to me for the AF dropdown to only pull from this new page, but in practice it should probably take both as well.

I was not aware that message is reused extensions, but if you want it there, please fill a new task against the extension. The AbuseFilter extension has many developer action at the moment, so I hope that would be done.

https://codesearch.wmflabs.org/search/?q=revdelete-reason-dropdown&i=nope&files=.*%5C.php&repos=

Amorymeltzer mentioned this in T245990: Abusefilter suppression options should use new suppression-only reasons.Feb 24 2020, 11:53 AM

Fair enough, opened T245990.

Amorymeltzer mentioned this in T250631: Create a separate list of suppression-only reasons for action=delete.Apr 19 2020, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits