⚓ T115170 Add support for MP3

Subject	Repo	Branch	Lines +/-
MimeAnalyzer: Add testcases for mp3 detection	mediawiki/core	master	+57 -0
MimeAnalyzer: Detect magic bytes for mp3	mediawiki/core	master	+5 -1
TMH: Add support for MP3 upload and playback	mediawiki/extensions/TimedMediaHandler	master	+92 -19
Disable mp3 uploads for now	operations/mediawiki-config	master	+3 -0

Status	Subtype	Assigned	Task
Open	Feature	None	T49487 Display metadata from videos and audio
Open	Feature	None	T164914 Add ID3 metadata fields to the metadata on File description pages
Resolved		kaldari	T120288 Enable MP3 uploads on Wikimedia Commons and TMH playback
Open		None	T44725 Multimedia file format support (tracking)
Resolved		TheDJ	T115170 Add support for MP3

Paladox created this task.Oct 10 2015, 12:06 AM

Paladox raised the priority of this task from to Needs Triage.

Paladox updated the task description. (Show Details)

Paladox added a project: TimedMediaHandler.

Paladox moved this task to To sort on the TimedMediaHandler board.

Paladox added subscribers: Paladox, • brooke.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2015, 12:06 AM

Added @brion.

Please remove your self if you doint want to be added to this task.

Peachey88 subscribed.Oct 10 2015, 2:44 AM

See https://www.mediawiki.org/wiki/Thread:Extension_talk:TimedMediaHandler/How_to_enable_MP3_support%3F

• brooke mentioned this in T115197: Undefined index in handlers/Mp4Handler.php.Oct 20 2015, 10:38 PM

TheDJ moved this task from To sort to Format support on the TimedMediaHandler board.Oct 21 2015, 7:05 PM

• brooke merged a task: T108310: Add support for mp3 uploads and audio transcoding to mp3 and ogg..Oct 23 2015, 7:55 PM

• brooke added subscribers: Matanya, TheDJ, Bawolff, • brooke.

Jdforrester-WMF added a parent task: T120288: Enable MP3 uploads on Wikimedia Commons and TMH playback.Dec 3 2015, 9:36 PM

@Jdforrester-WMF should this also be set as stalled until the mp3 patents expire. Since that would be in two years time.

Paladox removed a subscriber: Jdforrester-WMF.Dec 3 2015, 9:40 PM

This task isn't stalled as people can work on the code ahead of time, but actually enabling it on Wikimedia sites is blocked AIUI.

Poyekhali subscribed.Apr 26 2016, 6:15 AM

RP88 subscribed.Jan 30 2017, 8:27 AM

El_Grafo subscribed.Apr 16 2017, 6:10 PM

Change 349596 had a related patch set uploaded (by TheDJ):
[mediawiki/core@master] MimeAnalyzer: Detect magic bytes for mp3

https://gerrit.wikimedia.org/r/349596

gerritbot added a project: Patch-For-Review.Apr 21 2017, 9:05 PM

Change 349622 had a related patch set uploaded (by TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] TMH: Add support for MP3 files

https://gerrit.wikimedia.org/r/349622

Change 349733 had a related patch set uploaded (by TheDJ):
[operations/mediawiki-config@master] Disable mp3 uploads for now

https://gerrit.wikimedia.org/r/349733

TheDJ mentioned this in T120288: Enable MP3 uploads on Wikimedia Commons and TMH playback.Apr 30 2017, 12:34 PM

zhuyifei1999 subscribed.Apr 30 2017, 12:39 PM

BethNaught subscribed.Apr 30 2017, 3:08 PM

waldyrious subscribed.Apr 30 2017, 7:10 PM

The MP3 license program is terminated now, as the last patent in the US expired on April the 16th. According to Twitter and a Dutch news website (no English media coverage yet) this means the codec is open and free now.

TheDJ added a parent task: T164914: Add ID3 metadata fields to the metadata on File description pages.May 10 2017, 8:30 AM

TheDJ added a parent task: T44725: Multimedia file format support (tracking).May 10 2017, 12:12 PM

putnik subscribed.May 15 2017, 2:15 PM

Change 349733 abandoned by Brion VIBBER:
Disable mp3 uploads for now

Reason:
Abandoning in favor of a config switch for MP3 similar to the existing MP4 switch, disabled by default. We can then flip that switch once legal signs off.

https://gerrit.wikimedia.org/r/349733

Change 349622 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] TMH: Add support for MP3 upload and playback

https://gerrit.wikimedia.org/r/349622

The TMH update has been merged but will remain off until we flip $wgTmhEnableMp3Uploads on in config, so is safe to go to production branches. Note that the core change in https://gerrit.wikimedia.org/r/349596 for the MimeAnalyzer now includes sample test files, so we're waiting on legal's confirm to merge it.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 19 2017, 8:00 AM

• brooke mentioned this in T165717: Support transcoding audio files to MP3 for playback on IE/Edge/Safari/etc.May 19 2017, 8:01 AM

Jdforrester-WMF closed this task as Resolved.May 19 2017, 8:01 AM

Jdforrester-WMF assigned this task to TheDJ.

Change 354456 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] MimeAnalyzer: Add testcases for mp3 detection

https://gerrit.wikimedia.org/r/354456

Change 349596 merged by jenkins-bot:
[mediawiki/core@master] MimeAnalyzer: Detect magic bytes for mp3

https://gerrit.wikimedia.org/r/349596

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 19 2017, 1:00 PM

add hackathon tag, to keep track of what we did.

dr0ptp4kt mentioned this in T167815: Conduct MP3 patrol discussion.Jun 13 2017, 6:00 PM

Change 354456 merged by jenkins-bot:
[mediawiki/core@master] MimeAnalyzer: Add testcases for mp3 detection