Page MenuHomePhabricator

Equip list entry of most current contribution with class
Closed, ResolvedPublic1 Estimated Story Points

Description

On lists like Special:Contributions (and perhaps others) a contribution should be highlighted (or accessible for highlightng) if still unchanged.

Currently at the end of such lines a uctop text equipped with a class="mw-uctop" is displayed.

The CSS sibling rules do not permit to evaluate .mw-uctop property and give the whole item e.g. a green background; only the uctop and later elements like revert link can be accessed with pure CSS. A JavaScript gadget would be required to mark the entire parent.

On the same list items containing a uctop right now the <li> element shall be equipped with class="mw-uctop" and leave it to projects and users how to decorate contributions if not changed yet.

Event Timeline

Florian triaged this task as Low priority.
Florian subscribed.

Sounds reasonable.

Change 279395 had a related patch set uploaded (by Florianschmidtwelzow):
Add new mw-contributions-current css class to Special:Contributions

https://gerrit.wikimedia.org/r/279395

Change 279395 merged by jenkins-bot:
Add new mw-contributions-current css class to Special:Contributions

https://gerrit.wikimedia.org/r/279395

MBinder_WMF set the point value for this task to 1.Jul 7 2016, 5:08 PM
bmansurov subscribed.

To test, please visit http://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Baha and look for "mw-contributions-current" in the source code.

Would it be possible to cover this with a unit test, to help prevent regressions like the one that happened in T378132?

Would it be possible to cover this with a unit test, to help prevent regressions like the one that happened in T378132?

Update: Here are the unit tests, thanks to @Ammarpad: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1083753.

Sorry, adding the mentioned user as a subscriber was automatic and unintentional.