Page MenuHomePhabricator
Create Task
Maniphest T141508

[Task] Pass ValueParser to ValueView, not ValueParserStore
Open, MediumPublic
Actions

Description

Similarly to T125521, all knowledge necessary for creating the ValueParser is already present when creating the ValueView, so we can directly pass in an instance instead of the ValueParserStore.

Related Objects
Search...

Event Timeline

• adrianheine created this task.Jul 28 2016, 11:49 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 28 2016, 11:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• adrianheine renamed this task from [Task] Pass ValueParser to ValueView, not ValueParserFactory to [Task] Pass ValueParser to ValueView, not ValueParserStore.Jul 28 2016, 11:51 AM
• adrianheine updated the task description. (Show Details)
• adrianheine triaged this task as Medium priority.Jul 28 2016, 11:54 AM
• adrianheine added a parent task: T141510: [Task] Remove ValueView option dataTypeId.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits