Page MenuHomePhabricator
Create Task
Maniphest T152115

Restricted lead images to lead section
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Deploy changes from https://phabricator.wikimedia.org/T87336 to all projects
Do not deploy prior to Dec 8. Test thoroughly on beta cluster to account for any possible bugs.

  • $wgPageImagesLeadSectionOnly should be set to true on beta cluster to allow testing for possible bugs
  • Verify we are okay with the beta cluster behaviour (Olga)
  • $wgPageImagesLeadSectionOnly should be set to true in production (initially to a single large wiki to avoid fallout - ca has been selected).
  • Wait 1-2 days to get a sense of impact on cawiki before setting`$wgPageImagesLeadSectionOnly` to true in production for all wikis. Remember that only newly edited pages will get updated with new page images.
  • After this happens images returned by pageimages will only come from the lead section of an article. When enabling be sure to check error logs, performance graphs and end results.
  • The change when merged should be announced on wikitech-l and mediawiki-api (or mediawiki-api-announce) (Olga)
  • Upon sign off a card should be created to remove the $wgPageImagesLeadSectionOnly config variable from the Page Images extension and make this the default behaviour of the extension.

Details

SubjectRepoBranchLines +/-
Remove wgPageImagesLeadSectionOnlymediawiki/extensions/PageImagesmaster+17 -39
Restrict page images to lead sectionoperations/mediawiki-configmaster+1 -2
Restrict page images to lead section on cawikioperations/mediawiki-configmaster+5 -0
Limit page images on beta cluster to images in the lead sectionoperations/mediawiki-configmaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added subscribers: JEumerus, Matanya, Aklapper. · View Herald TranscriptDec 1 2016, 6:25 PM
• jhobs set the point value for this task to 1.Dec 1 2016, 9:16 PM
• bmansurov updated the task description. (Show Details)Dec 1 2016, 9:16 PM
• bmansurov removed the point value for this task.
• jhobs set the point value for this task to 2.Dec 1 2016, 9:16 PM
• bmansurov updated the task description. (Show Details)Dec 1 2016, 9:16 PM
• jhobs triaged this task as High priority.Dec 1 2016, 9:16 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptDec 1 2016, 9:16 PM
• bmansurov moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Dec 1 2016, 9:17 PM
• bmansurov moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.
• bmansurov added a project: Reading-Web-Sprint-87-♨️😭.
Jdlrobson updated the task description. (Show Details)Dec 2 2016, 6:34 PM
Jdlrobson mentioned this in T87336: PageImages shouldn't return images that are not in the lead section.
Jdlrobson merged a task: T152097: Deploy images from the lead section only change to pageimages on all projects.Dec 2 2016, 6:44 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson changed the point value for this task from 2 to 1.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: ovasileva.
Jdlrobson moved this task from Needs Analysis to Blocked Externally on the Reading-Web-Sprint-87-♨️😭 board.Dec 5 2016, 6:14 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Dec 7 2016, 4:07 PM
Jdlrobson removed a project: Reading-Web-Sprint-87-♨️😭.Dec 8 2016, 6:10 PM

We discussed in standup today that we would remove this from sprint as we cannot deploy this change this sprint while T87336 is not merged.

Krenair moved this task from Backlog to External on the Wikimedia-Site-requests board.Dec 10 2016, 4:09 PM
ovasileva moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.Dec 14 2016, 8:53 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jan 11 2017, 1:48 AM
gerritbot subscribed.Feb 2 2017, 7:04 PM

Change 335687 had a related patch set uploaded (by Jdlrobson):
Limit page images on beta cluster to images in the lead section

https://gerrit.wikimedia.org/r/335687

gerritbot added a project: Patch-For-Review.Feb 2 2017, 7:04 PM
Jdlrobson added a comment.Feb 2 2017, 7:43 PM

The patch is in the SWAT today for part 1 (beta cluster) - https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1447091&oldid=1445962
Should make this task easier for next sprint. Have not added to current sprint as this task will not be complete after the SWAT.

gerritbot added a comment.Feb 3 2017, 12:21 AM

Change 335687 merged by jenkins-bot:
Limit page images on beta cluster to images in the lead section

https://gerrit.wikimedia.org/r/335687

Jdlrobson added a comment.Feb 3 2017, 12:33 AM

@ovasileva you can now test the results on beta cluster by doing a search and checking which pages have page images and checking whether they appear in the lead section. Note the changes will take time to propagate so you will need to edit the page to generate the new page image for an article.

Impacted by change (now do not show page images):

Not impacted:

It appears to be working correctly, but I'm not sure how many pages this leads to have no page image (there is no going back when we deploy this to production!)

Jdlrobson updated the task description. (Show Details)Feb 3 2017, 12:33 AM
Jdlrobson removed a project: Patch-For-Review.
ovasileva added a project: Reading-Web-Sprint-93-🔍🔍🔍🔍🔍.Feb 21 2017, 9:43 AM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Feb 21 2017, 5:28 PM
ovasileva changed the point value for this task from 1 to 2.
ovasileva removed a project: Reading-Web-Sprint-93-🔍🔍🔍🔍🔍.Feb 28 2017, 7:56 PM
Jdlrobson updated the task description. (Show Details)Mar 14 2017, 8:49 PM
gerritbot added a comment.Mar 14 2017, 8:58 PM

Change 342696 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config] Restrict page images to lead section on cawiki

https://gerrit.wikimedia.org/r/342696

gerritbot added a project: Patch-For-Review.Mar 14 2017, 8:58 PM
Jdlrobson added a comment.Mar 15 2017, 12:05 AM

SWAT window overran today and I was unable to deploy this.

Jdlrobson added a project: Reading-Web-Sprint-94.Mar 15 2017, 12:26 AM
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-94 board.
Jdlrobson updated the task description. (Show Details)Mar 15 2017, 12:29 AM

Added to sprint 94 as

  1. it's high priority
  2. We already have existing Wikimedia-Site-Requests in the sprint so doing another swat in parallel makes no difference.
  3. I personally plan to do this as I would benefit from this in my personal apps and I want to be honest about that.
  4. We have tech debt that can be removed as a result of seeing this through to completion
Jdlrobson updated the task description. (Show Details)Mar 15 2017, 3:05 AM
Jdlrobson added a comment.Mar 15 2017, 10:45 PM

In swat window for today for cawiki.

gerritbot added a comment.Mar 15 2017, 11:20 PM

Change 342696 merged by jenkins-bot:
[operations/mediawiki-config] Restrict page images to lead section on cawiki

https://gerrit.wikimedia.org/r/342696

Stashbot subscribed.Mar 15 2017, 11:25 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-15T23:25:22Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:342696|Restrict page images to lead section on cawiki]] T152115 (duration: 00m 42s)

Jdlrobson moved this task from Needs Code Review to Blocked Externally on the Reading-Web-Sprint-94 board.Mar 15 2017, 11:31 PM

This is deployed to cawiki now.
We'll have to wait a little as this rolls out.
This is blocked until @ovasileva approves.

I edited all the star wars episodes to force the generation of a new page image.
As you can see images beyond the lead are no longer shown, but now none of them show images as the only image in the lead is a free image.

@ovasileva do we want to/can we show free images in search or is this acceptable? (Please raise a new task if we want to enable free images there)
Before:

Screen Shot 2017-03-15 at 4.20.28 PM.png (784×308 px, 121 KB)

After:
Screen Shot 2017-03-15 at 4.29.09 PM.png (766×295 px, 98 KB)

Jdlrobson removed a project: Patch-For-Review.Mar 16 2017, 12:00 AM
Jdlrobson updated the task description. (Show Details)
Nemo_bis subscribed.Mar 16 2017, 6:40 AM

Such a complicated "solution"... this is not a good use of developer time. T95026 is the only solution.

phuedx subscribed.Mar 16 2017, 10:40 AM

Is this planned Unplanned-Sprint-Work? 😄

ovasileva added a comment.Mar 16 2017, 4:20 PM

@Jdlrobson - no free images in search for now - I will test further later today/tomorrow, post the announcement and ping on here to deploy on all wikis

ovasileva moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-94 board.Mar 20 2017, 7:47 PM

Looks good - some images are lost, but most of them were out of context in the first place.

gerritbot added a comment.Mar 20 2017, 7:47 PM

Change 343733 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config] Restrict page images to lead section

https://gerrit.wikimedia.org/r/343733

gerritbot added a project: Patch-For-Review.Mar 20 2017, 7:47 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Reading-Web-Sprint-94 board.Mar 20 2017, 7:47 PM
Jdlrobson updated the task description. (Show Details)Mar 20 2017, 7:50 PM
gerritbot added a comment.Mar 20 2017, 11:52 PM

Change 343733 merged by jenkins-bot:
[operations/mediawiki-config] Restrict page images to lead section

https://gerrit.wikimedia.org/r/343733

Stashbot added a comment.Mar 20 2017, 11:54 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-20T23:54:10Z] <dereckson@tin> Synchronized wmf-config/InitialiseSettings.php: Restrict page images to lead section (T152115) (duration: 00m 43s)

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Reading-Web-Sprint-94 board.Mar 21 2017, 12:02 AM
Jdlrobson updated the task description. (Show Details)

You can see this in action here now: https://en.m.wikipedia.org/wiki/Star_Trek:_Deep_Space_Nine#/search - most of the search results have non-free images in the lead so an edit will make their page image disappear.

Nemo_bis unsubscribed.Mar 21 2017, 8:58 AM
phuedx assigned this task to ovasileva.Mar 21 2017, 10:46 AM
MBinder_WMF moved this task from Upcoming to 2016-17 Q3 on the Web-Team-Backlog board.Mar 21 2017, 4:04 PM
Jdlrobson removed a project: Patch-For-Review.Mar 21 2017, 5:26 PM
ovasileva closed this task as Resolved.Mar 24 2017, 4:05 PM
ovasileva reopened this task as Open.
phuedx renamed this task from [Config] Restricted lead images to lead section to Restricted lead images to lead section.Apr 3 2017, 5:05 PM
Jdlrobson updated the task description. (Show Details)Apr 4 2017, 10:37 PM

Have created https://phabricator.wikimedia.org/T162203
I assume all that is left is an announcement from Olga?

ovasileva closed this task as Resolved.Apr 5 2017, 12:15 PM
ovasileva updated the task description. (Show Details)

announcement done!

Jdlrobson mentioned this in T166493: No page images selected on English Wiktionary.May 30 2017, 6:27 PM
gerritbot added a comment.Jan 7 2018, 12:45 PM

Change 402643 had a related patch set uploaded (by Albert221; owner: Albert221):
[operations/mediawiki-config@master] Remove 文A icon from Wikidata and MediaWiki

https://gerrit.wikimedia.org/r/402643

gerritbot added a project: Patch-For-Review.Jan 7 2018, 12:45 PM
phuedx added a comment.Jan 8 2018, 7:24 AM

^ Wrong Bug: number 🙂

MBinder_WMF moved this task from 2016-17 Q3 to 2016-17 Q4 on the Web-Team-Backlog board.Mar 6 2018, 6:56 PM
AntiCompositeNumber mentioned this in T91683: Allow editors control of the page image.Sep 7 2021, 6:12 PM
gerritbot added a comment.Dec 2 2021, 12:34 AM

Change 743054 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/PageImages@master] Remove wgPageImagesLeadSectionOnly

https://gerrit.wikimedia.org/r/743054

gerritbot added a comment.Dec 3 2021, 4:19 AM

Change 743054 abandoned by Tim Starling:

[mediawiki/extensions/PageImages@master] Remove wgPageImagesLeadSectionOnly

Reason:

bad change oops

https://gerrit.wikimedia.org/r/743054

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits