| Etonkovidova | |
| Apr 12 2017, 10:33 PM |
| F7989204: Screen Shot 2017-05-08 at 3.03.06 PM.png | |
| May 8 2017, 10:25 PM |
| F7513632: Screen Shot 2017-04-12 at 3.41.55 PM.png | |
| Apr 12 2017, 10:47 PM |
| F7513626: Screen Shot 2017-04-12 at 3.38.07 PM.png | |
| Apr 12 2017, 10:47 PM |
| F7513563: Screen Shot 2017-04-12 at 2.43.04 PM.png | |
| Apr 12 2017, 10:33 PM |
| F7513520: Screen Shot 2017-04-12 at 2.37.22 PM.png | |
| Apr 12 2017, 10:33 PM |
(1) On frwiki (wmf.19) when 'New filters for edit review' beta feature is enabled, an extra dot on a newline is displayed on RC page.
When the beta feature is not enabled, the dot is not displayed:
(2) When RC page is reloading, the help link '?' will be displayed at the beginning of rcfilters-container. The same misplacement will occur when RC filters are not enabled, but the page reloads faster, so it's not noticeable.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove links list from the 'rclinks' message | mediawiki/core | master | +273 -273 |
The first problem comes from the "rclinks" message (french version: Afficher les $1 dernières modifications effectuées au cours des $2 derniers jours<br />$3.) with $3 being the list of show/hide links. When all of them are replaced in the new RC Filters UI, all that's left is a lonely period on a new line.
We could remove $3 from the message and append it as a different section when building the UI. In most languages, "rclinks" ends with <br />$3 or something similar so there would be little to no visual differences. Exceptions are:
languages/i18n/arz.json: "rclinks": "بيين اخر $1 تعديل فى اخر $2 يوم، $3",
languages/i18n/avk.json: "rclinks": "Nedira va $1 ironokaf betaks mali $2 ironokaf viel; $3 betamaks.",
languages/i18n/bqi.json: "rclinks": "نشودادن آخرین $1 تغییر در $2 روز اخیر؛ $3",
languages/i18n/ksh.json: "rclinks": "Zeisch de läzde {{int:pipe-separator}}$1{{int:pipe-separator}} Änderonge us de läzde {{int:pipe-separator}}$2{{int:pipe-separator}} Däch, un dun {{int:pipe-separator}} $3.",
languages/i18n/lrc.json: "rclinks": "آخرین آلشتیا $1 نشو بیه د اخرین روزیا $2",
languages/i18n/luz.json: "rclinks": "نیشۉ دائن ئاخأرین $1 تأغییر مئن $2 روٙز أخیر؛ $3",
languages/i18n/mzn.json: "rclinks": "نـِشون هـِدائن $1 پایانی دَچییهئون، $2 اِسـا روز ره دلـه؛"Note that some of them do not display correctly here, possibly because of directionality charaters.
I have no idea if the proposed change would affect them in a problematic way.
So it looks like arz, bqi and luz do end in $3 (modulo RLE characters maybe)? And lrc and mzn don't have $3 at all, which seems like a bug. The only language where it would really make a difference is avk, and looking at that message I'm not sure if the translators understood what they were doing there. So your suggestion of removing $3 and adding the links separately sounds good to me.
Change 348825 had a related patch set uploaded (by Sbisson):
[mediawiki/core@master] Remove links list from the 'rclinks' message
About #2 (help link), it is caused by a global site script. Search for function rewritePageH1bis() in https://fr.wikipedia.org/wiki/MediaWiki:Common.js
Change 348825 merged by jenkins-bot:
[mediawiki/core@master] Remove links list from the 'rclinks' message
Since the mentioned lang wikis do not exist in betalabs, I will check it after deployment.
Checked in wmf.21 for fr wiki and ksh, lrc, and mzn wikis (https://en.wikipedia.org/wiki/List_of_Wikipedias). No display problems are found.
QA Recommendation: Resolve