Update gadgets for seen/unseen styling
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Sep 5 2017, 7:20 PM

Description

Below should be done for English Wikipedia and other wikis using the same gadgets.

Don't show green bullets for unseen changes if the beta feature is enabled.
Show bold for unseen changes if beta feature is enabled, even if WatchlistChangesBold is off.

Full query is P5999. However, note this only shows gadgets on other wikis with the same name as enwiki's. They could (and likely a few do) have their own names.

Four that we have updates for are:

WatchlistBase - https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Gadget-WatchlistBase.css
WatchlistGreenIndicators (vector) - https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Gadget-WatchlistGreenIndicators.css
WatchlistGreenIndicatorsMono (monobook,modern) - https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Gadget-WatchlistGreenIndicatorsMono.css
WatchlistChangesBold - https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Gadget-WatchlistChangesBold.css

All the exact copies to do are given at P6021.

Details

	Subject	Repo	Branch	Lines +/-
	Add <body> class marking whether RCFilters is enabled	mediawiki/core	master	+21 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• DannyH	T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
Resolved	• DannyH	T171981 Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions
Open	None	T164232 Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?)
Resolved	• Catrope	T181193 [EPIC] Graduate the New Filters UX on Watchlist out of beta on all wikis
Resolved	• Catrope	T164234 Provide "RC Filters" functionality on the watchlist
Resolved	Mooeypoo	T171235 Standardize system for indicating unseen/seen changes on Watchlist
Resolved	• Mattflaschen-WMF	T175062 Update gadgets for seen/unseen styling

Event Timeline

• Mattflaschen-WMF created this task.Sep 5 2017, 7:20 PM

Elena just pointed out to me that the gadget about green dots affects RC page and History as well as Watchlist. The wording:

Display green collapsible arrows and green bullets for changed pages in your watchlist, page history and recent changes

So if we eliminate it from Watchlist and RC page, do we need to move a diminished gadget (that applies only to history) to some other section? Maybe "Appearance"?

We are removing green dots only for Beta. At the moment, the majority of users will not be impacted.

SBisson mentioned this in T164234: Provide "RC Filters" functionality on the watchlist.Sep 6 2017, 12:40 PM

Change 377201 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@master] Add <body> class marking whether RCFilters is enabled

https://gerrit.wikimedia.org/r/377201

gerritbot added a project: Patch-For-Review.Sep 11 2017, 7:13 AM

In T175062#3582119, @jmatazzoni wrote:

Elena just pointed out to me that the gadget about green dots affects RC page and History as well as Watchlist. The wording:

Display green collapsible arrows and green bullets for changed pages in your watchlist, page history and recent changes

So if we eliminate it from Watchlist and RC page, do we need to move a diminished gadget (that applies only to history) to some other section? Maybe "Appearance"?

This is a good point. We could move the ones that apply to more than watchlist at any time, to avoid confusion.

Change 377201 merged by jenkins-bot:
[mediawiki/core@master] Add <body> class marking whether RCFilters is enabled

https://gerrit.wikimedia.org/r/377201

Okay, the CSS itself is ready for review:

WatchlistBase - https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistBase.css
WatchlistGreenIndicators (vector) - https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicators.css
WatchlistGreenIndicatorsMono (monobook,modern) - https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicatorsMono.css
WatchlistChangesBold - https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistChangesBold.css

To test it, you can use the below code (copy to Special:MyPage/common.js). You can customize which gadgets are on by commenting out the relevant parts of the below. WatchlistBase is supposed to always be on, but I tested with it off as well.

Disable the actual gadgets in your preferences, and just use the below instead.

$( function () {
	mw.loader.using( 'mediawiki.util' ).done( function () {
		var $body = $( 'body' ), enabled = false;
		
		if ( $body.is( '.mw-special-Recentchanges, .mw-special-Recentchangeslinked, .mw-special-Watchlist' ) ) {
			if ( mw.user.options.get( 'rcenhancedfilters' ) ) {
				if ( $body.is( '.mw-special-Recentchanges, .mw-special-Recentchangeslinked' ) ) {
					enabled = true;
				} else if ( $body.is ('.mw-special-Watchlist' ) ) {
					enabled = ( mw.util.getParamValue( 'rcfilters' ) === '1' );
				}
			}
		
			$body.addClass( enabled ? 'mw-rcfilters-enabled' : 'mw-rcfilters-disabled' );
		}
	
		mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistBase.css&action=raw&ctype=text/css', 'text/css' );
	
		var skin = mw.config.get( 'skin' );
		if ( skin === 'vector' ) {
			mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicators.css&action=raw&ctype=text/css', 'text/css' );
		} else if ( skin === 'monobook' || skin === 'modern' ) {
			mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicatorsMono.css&action=raw&ctype=text/css', 'text/css' );
		}
	
		mw.loader.load( 'https://en.wikipedia.org/w/index.php?title=User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistChangesBold.css&action=raw&ctype=text/css', 'text/css' );
	} );
} );

• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 12 2017, 2:39 AM

• Mattflaschen-WMF updated the task description. (Show Details)Sep 13 2017, 9:44 AM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF mentioned this in T171030: Announce and follow up with communities about the New Filters for Watchlist Beta feature.Sep 13 2017, 9:48 AM

• Mattflaschen-WMF updated the task description. (Show Details)Sep 13 2017, 5:20 PM

On Beta cluster, you don't need the:

var $body = $( 'body' ), enabled = false;
		
		if ( $body.is( '.mw-special-Recentchanges, .mw-special-Recentchangeslinked, .mw-special-Watchlist' ) ) {
			if ( mw.user.options.get( 'rcenhancedfilters' ) ) {
				if ( $body.is( '.mw-special-Recentchanges, .mw-special-Recentchangeslinked' ) ) {
					enabled = true;
				} else if ( $body.is ('.mw-special-Watchlist' ) ) {
					enabled = ( mw.util.getParamValue( 'rcfilters' ) === '1' );
				}
			}
		
			$body.addClass( enabled ? 'mw-rcfilters-enabled' : 'mw-rcfilters-disabled' );
		}

part (or in production tomorrow once rMWb3becd3a6113: Add <body> class marking whether RCFilters is enabled fully rolls out).

LGTM. Didn't test though, maybe @Etonkovidova can do that now that you've put this on beta cluster?

• Mattflaschen-WMF updated the task description. (Show Details)Sep 14 2017, 12:46 AM

• Mattflaschen-WMF updated the task description. (Show Details)

The new versions are now on the Beta Cluster. People can test there without any code (by just changing whether RCFilters is enabled and/or gadgets and/or skin in your preferences).

• Mattflaschen-WMF updated the task description. (Show Details)Sep 14 2017, 5:37 PM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF updated the task description. (Show Details)Sep 14 2017, 5:40 PM

• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 15 2017, 5:54 PM

The table below summarizes how seen/unseen changes are displayed on Recent changes/Watchlist with enabled/disabled the new filter feature.

Enabled filters	Status of changes	Watchlist
No	Unseen	non-bold titles/green filled dots
No	Seen	non-bold titles/blue filled dots
Yes	Unseen	bold title/blue filled dots
Yes	Seen	non-bold titles/empty dots

For the cases where Watchlist has enabled beta feature and displays empty markers the task was filed: T176191: [betalabs] Watchlist - empty markers displayed for seen/unseen changes

• Mattflaschen-WMF merged a task: T175074: [testwiki-wmf.17] RC page with "Grouped by page" option-Preferences-Gadgets setting "Display green collapsible arrows and green bullets..." displays colored dots .Sep 19 2017, 3:05 AM

• Mattflaschen-WMF updated the task description. (Show Details)Sep 19 2017, 4:15 AM

The copies to do are at P6021. I skipped ur, since it's not an available gadget (and it's different from the others).

Someone should also post on the talk pages that we did this, before this is closed.

All the copies are now done.

With T176191: [betalabs] Watchlist - empty markers displayed for seen/unseen changes fixed/verified, I've update the table in my above column. I also checked monobook skin - the display of dots is identical there to Vector skin.

Note: when new filters are not enabled on RC page and Watchlist, the monobook skin displays not dots but small squares.

monobook RC page - filters not enabled.

Screen Shot 2017-09-19 at 11.44.03 AM.png (401×884 px, 151 KB)

monobook RC page - filters enabled.

Screen Shot 2017-09-19 at 11.48.34 AM.png (486×825 px, 127 KB)

I've updated the table in my comment above and filed T176254: [betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers to prioritize it later.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 19 2017, 7:39 PM

• jmatazzoni closed this task as Resolved.Sep 19 2017, 11:23 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 15 2018, 9:59 AM

	F9652765: Screen Shot 2017-09-19 at 11.48.34 AM.png
	Sep 19 2017, 7:38 PM

	F9652755: Screen Shot 2017-09-19 at 11.44.03 AM.png
	Sep 19 2017, 7:38 PM

Update gadgets for seen/unseen stylingClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Update gadgets for seen/unseen styling
Closed, ResolvedPublic
Actions

Related Objects
Search...