Page MenuHomePhabricator
Create Task
Maniphest T212210

Make query service logo and favicon configurable
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Split off from T211474 as a first step

Problem:
By default the query service uses Wikidata's logo and favicon (with a looking glass overlay). As more installations of it pop up they still use the Wikidata logo and favicon while they really shouldn't.

Acceptance criteria

  • The logo can be configured more easily than before
  • The favicon can be configured more easily than before
  • The configuration works in the same way as other UI configuration does.
  • the same actual logos should be used for now.

Related Objects
Search...

Event Timeline

Addshore created this task.Dec 18 2018, 2:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2018, 2:19 PM
Addshore set the point value for this task to 5.Dec 18 2018, 2:20 PM
Addshore moved this task from Incoming to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore triaged this task as Medium priority.Dec 18 2018, 2:37 PM
Addshore added a parent task: T211474: Make query service logo and favicon have a placeholder image (not wikidata logo).Dec 18 2018, 2:40 PM
Addshore updated the task description. (Show Details)Dec 18 2018, 2:43 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Dec 19 2018, 12:42 PM
Michael claimed this task.Jan 11 2019, 2:26 PM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptJan 11 2019, 2:26 PM
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.Jan 11 2019, 2:31 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 11 2019, 3:34 PM
Michael moved this task from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 11 2019, 3:45 PM
hoo subscribed.

Done with https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/483780/1 and https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/483781/1, I suppose.

Michael added a subscriber: Lydia_Pintscher.Jan 11 2019, 4:02 PM

It turns out that the query service has a no-js mode. The patches implemented in context with this ticket replace favicon, logo and document title with an empty placeholder which is overwritten by js. If there is no js, then the empty placeholders will stay. @Lydia_Pintscher says that this is fine 🙂

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.Jan 14 2019, 3:15 PM
Addshore closed this task as Resolved.Jan 21 2019, 10:39 AM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore mentioned this in T214532: Wikidata logo takes too long to appear on the Query UI on Firefox.Jun 22 2019, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits