| • TBolliger | |
| Feb 27 2019, 4:30 PM |
| F28426907: uw_block_config.png | |
| Mar 20 2019, 6:12 PM |
| F28426905: uw_block_message.png | |
| Mar 20 2019, 6:12 PM |
As a follow-up to T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked
SpecialUploadWizard::isUserUploadAllowed needs to be modified to allow Partially Blocked users from accessing https://test.wikipedia.org/wiki/Special:UploadWizard
Acceptance criteria
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | TheDJ | T190350 Epic: ⚡️ Partial blocks | |||
| Resolved | Tchanders | T217255 Partially blocked users should be allowed to use Special:UploadWizard |
Change 494934 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/UploadWizard@master] Allow partially blocked users to access Special:UploadWizard
Change 494934 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Allow partially blocked users to access Special:UploadWizard
@Tchanders It appears to block partially blocked users at the stage just after they have selected the image (on beta commons).
Block config:
Change 497937 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Check whether a user is blocked from upload in ApiUpload
Change 497937 merged by jenkins-bot:
[mediawiki/core@master] Check whether a user is blocked from upload in ApiUpload
Tested various functions offered by UploadWizard with different block configs.
Block shows the type of block (username, IP, IP range) and if it blocks a relevant namespace or page or if it is irrelevant to the action performed.
| Block | User rights | Action | Outcome |
| Sitewide user | Upload new | Blocked | |
| Partial user (irrelevant) | Upload new | Success | |
| Partial IP (File ns) | Upload new | Blocked | |
| Partial IP (irrel.) | Upload new | Success | |
| Partial IP range (File ns) | ipblock-exempt | Upload new | Success |
| Partial IP range (irrel.) | ipblock-exempt | Upload new | Success |
| Partial IP range (irrel.) | Upload flickr | Success | |
| Partial IP range (File ns) | Upload flickr | Blocked | |
| Partial user (irrel.) | Upload flickr (mobile) | Success | |
| Partial user (File ns) | Upload flickr (mobile) | Blocked | |
| Partial user (Campaign ns) | Upload Wizard campaign editor | Edit campaign | Blocked |
| Partial user (Campaign ns) | Upload to campaign | Success | |
| Partial IP range (irrel.) | Upload Wizard campaign editor | Edit campaign | Success |
| Partial IP (irrel.) | Cross-wiki upload | Success | |
| Partial IP (File ns) | Cross-wiki upload | Blocked | |
I used the visual editor in beta wikipedia to "cross-wiki" upload files to commons. The block on commons was applied appropriately. Any blocks on beta wikipedia appeared to have no affect.
Moving an image
Not strictly related to this change, but improving coverage by looking at file moving.
| Block | **User rights* | Action | Outcome |
| Partial user (irrel.) | file mover | Move | File is moved |
| Partial user (Specific page) | file mover | Move | Blocked |
| Partial IP (File ns) | file mover | Move | Blocked |
| Partial IP range (File ns) | ipblock-exempt,file mover | Move | File is moved |
| Partial IP range (irrel.) | ipblock-exempt,file mover | Move | File is moved |
| Partial IP (irrel.) | Move request | File is moved | |
| Partial IP (irrel.) | file mover | Accepting move request | File is moved |
| Partial user (File ns) | file mover | Decline move request | Blocked |
| Partial user (irrel.) | file mover | Decline move request | File is moved |
Not tested
I could see no way to test the mass-upload user right. Turning it on and off for a user appeared to have no effect. In both cases I was able to upload more than one file at a time with Special:UploadWizard. This makes me think there is something I am missing, but I could find no documentation on this.
Environment
https://commons.wikimedia.beta.wmflabs.org
MediaWiki 1.33.0-alpha (3f54ff5) 08:37, 26 March 2019
Upload Wizard 1.5.0 (dba7f28) 07:45, 26 March 2019
https://en.wikipedia.beta.wmflabs.org
MediaWiki 1.33.0-alpha (3f54ff5) 08:37, 26 March 2019