Page MenuHomePhabricator
Create Task
Maniphest T222406

Switch quibble-based CI jobs from node6 to node10
Closed, ResolvedPublic
Actions

Description

I think we'll need to do the following:

I think this'll have to happen pretty rapidly to avoid too much bitrot from the selenium tests, as I don't see a way of proceeding without switching selenium off first. Anyone want to volunteer to pair on this?

Details

Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT211784 Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects
ResolvedKrinkleT213268 Upgrade webdriverio to version 5 in mediawiki/core
ResolvedJdforrester-WMFT222406 Switch quibble-based CI jobs from node6 to node10
ResolvedJdforrester-WMFT224983 mediawiki-phpunit-coverage-patch-docker fails to install [email protected]
DeclinedJdforrester-WMFT224997 Update MobileFrontend-npm-run-lint-modules-docker to run node10
· · ·

Event Timeline

Jdforrester-WMF triaged this task as Medium priority.May 2 2019, 10:53 PM
Jdforrester-WMF created this task.
• Niedzielski added a comment.May 3 2019, 12:45 AM

MobileFrontend hard-coding checking 6.11.0

I'm sorry I cannot help more. My schedule is booked but I think we could either temporarily disable this check or simply upgrade the version of Node.js expected (we would be delighted to have something more recent!). I think either change would be quick for me to make. Let me know.

Jdforrester-WMF added a comment.May 3 2019, 1:15 AM
In T222406#5154829, @Niedzielski wrote:

MobileFrontend hard-coding checking 6.11.0

I'm sorry I cannot help more. My schedule is booked but I think we could either temporarily disable this check or simply upgrade the version of Node.js expected (we would be delighted to have something more recent!). I think either change would be quick for me to make. Let me know.

No worries, fixing MF for that is easy; it's just an example of no-doubt a bunch of errors we'll get as soon as we do this. Plausibly, it makes most sense to do this over a weekend (to disrupt working developers' lives the least), but finding a CI root who wants to give up their weekend for this may be challenging. :-)

Jdforrester-WMF added a parent task: T213268: Upgrade webdriverio to version 5 in mediawiki/core.May 3 2019, 7:58 PM
Jdforrester-WMF updated the task description. (Show Details)May 6 2019, 7:23 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.May 7 2019, 7:46 PM

Change 508692 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] [DNM] selenium: Temporarily drop all tests so we can migrate to node 10 in CI

https://gerrit.wikimedia.org/r/508692

gerritbot added a project: Patch-For-Review.May 7 2019, 7:46 PM
Jdforrester-WMF updated the task description. (Show Details)May 7 2019, 7:47 PM
Jdforrester-WMF claimed this task.May 30 2019, 5:03 PM
Jdforrester-WMF edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team (Backlog).May 30 2019, 5:11 PM
Stashbot mentioned this in T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.Jun 3 2019, 2:38 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-03T14:38:18Z] <James_F> hashar and I are temporarily disabling running selenium tests in CI. See T211784 T222406 for more details.

gerritbot added a comment.Jun 3 2019, 3:12 PM

Change 514021 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: switch quibble-stretch to node10/npm6

https://gerrit.wikimedia.org/r/514021

gerritbot added a comment.Jun 3 2019, 3:18 PM

Change 514021 merged by jenkins-bot:
[integration/config@master] docker: switch quibble-stretch to node10/npm6

https://gerrit.wikimedia.org/r/514021

gerritbot added a comment.Jun 3 2019, 3:27 PM

Change 514026 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: nodejs10 does provide /usr/bin/node

https://gerrit.wikimedia.org/r/514026

gerritbot added a comment.Jun 3 2019, 3:27 PM

Change 514026 merged by Hashar:
[integration/config@master] docker: nodejs10 does provide /usr/bin/node

https://gerrit.wikimedia.org/r/514026

gerritbot added a comment.Jun 3 2019, 3:34 PM

Change 514034 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Switch most Quibble jobs to NodeJS 10

https://gerrit.wikimedia.org/r/514034

gerritbot added a comment.Jun 3 2019, 4:47 PM

Change 508692 merged by jenkins-bot:
[mediawiki/core@master] selenium: Temporarily drop all tests and wdio-mocha-framework

https://gerrit.wikimedia.org/r/508692

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 3 2019, 5:01 PM
Jdforrester-WMF updated the task description. (Show Details)Jun 3 2019, 5:30 PM
gerritbot added a comment.Jun 3 2019, 5:34 PM

Change 514034 merged by jenkins-bot:
[integration/config@master] Switch most Quibble jobs to NodeJS 10

https://gerrit.wikimedia.org/r/514034

Stashbot added a comment.Jun 3 2019, 5:40 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-03T17:40:56Z] <James_F> Reloading Zuul to switch most Quibble jobs to node 10 T222406

gerritbot added a comment.Jun 3 2019, 5:59 PM

Change 514085 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] selenium: Re-add all tests and wdio-mocha-framework

https://gerrit.wikimedia.org/r/514085

Stashbot added a comment.Jun 3 2019, 6:34 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-03T18:33:59Z] <hashar> hswitch most Quibble jobs to node 10 T222406 - ttps://gerrit.wikimedia.org/r/#/c/integration/config/+/514034/ T222406

Stashbot added a comment.Jun 3 2019, 6:34 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-03T18:33:59Z] <hashar> hswitch most Quibble jobs to node 10 T222406 - ttps://gerrit.wikimedia.org/r/#/c/integration/config/+/514034/ T222406

Stashbot added a comment.Jun 3 2019, 6:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-03T18:35:36Z] <hashar> switch most Quibble jobs to node 10 T222406 - ttps://gerrit.wikimedia.org/r/#/c/integration/config/+/514034/ T222406

Stashbot added a comment.Jun 3 2019, 6:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-03T18:35:36Z] <hashar> switch most Quibble jobs to node 10 T222406 - ttps://gerrit.wikimedia.org/r/#/c/integration/config/+/514034/ T222406

Jdforrester-WMF updated the task description. (Show Details)Jun 3 2019, 7:47 PM
Jdforrester-WMF updated the task description. (Show Details)Jun 3 2019, 8:17 PM

Things we apparently don't need to do:

WebdriverIo5 things:

gerritbot added a comment.Jun 3 2019, 8:38 PM

Change 514085 merged by jenkins-bot:
[mediawiki/core@master] selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4

https://gerrit.wikimedia.org/r/514085

Jdforrester-WMF removed a project: Patch-For-Review.Jun 3 2019, 8:40 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF closed this task as Resolved.Jun 3 2019, 9:30 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Jun 3 2019, 11:10 PM

Fixes so far:

gerritbot added a comment.Jun 4 2019, 10:45 AM

Change 514255 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/core@wmf/1.34.0-wmf.7] selenium: Temporarily drop all tests and wdio-mocha-framework

https://gerrit.wikimedia.org/r/514255

gerritbot added a project: Patch-For-Review.Jun 4 2019, 10:45 AM
gerritbot added a comment.Jun 4 2019, 10:53 AM

Change 514257 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/core@wmf/1.34.0-wmf.7] build: upgrade wdio-mocha-framework for NodeJS 10

https://gerrit.wikimedia.org/r/514257

gerritbot added a comment.Jun 4 2019, 10:58 AM

Change 514255 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.7] selenium: Temporarily drop all tests and wdio-mocha-framework

https://gerrit.wikimedia.org/r/514255

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.7; 2019-05-28); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 4 2019, 11:00 AM
hashar mentioned this in T224978: WikibaseMediaInfo selenium tests failing when run against beta commons.Jun 4 2019, 11:43 AM
hashar reopened this task as Open.Jun 4 2019, 12:23 PM

There are bunch of other quibble based jobs that we still have to update! Eg the one to generate mediawiki/core coverage report T224983

hashar added a subtask: T224983: mediawiki-phpunit-coverage-patch-docker fails to install [email protected].Jun 4 2019, 12:23 PM
gerritbot added a comment.Jun 4 2019, 4:41 PM

Change 514257 abandoned by Hashar:
build: upgrade wdio-mocha-framework for NodeJS 10

https://gerrit.wikimedia.org/r/514257

gerritbot added a comment.Jun 4 2019, 4:42 PM

Change 514331 had a related patch set uploaded (by Hashar; owner: Jforrester):
[mediawiki/core@wmf/1.34.0-wmf.7] selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4

https://gerrit.wikimedia.org/r/514331

gerritbot added a comment.Jun 4 2019, 4:49 PM

Change 514341 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@REL1_33] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514341

gerritbot added a comment.Jun 4 2019, 4:59 PM

Change 514349 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@REL1_32] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514349

gerritbot added a comment.Jun 4 2019, 5:21 PM

Change 514331 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.7] selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4

https://gerrit.wikimedia.org/r/514331

Jdforrester-WMF closed subtask T224983: mediawiki-phpunit-coverage-patch-docker fails to install [email protected] as Resolved.Jun 4 2019, 6:11 PM
gerritbot added a comment.Jun 4 2019, 6:20 PM

Change 514365 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@REL1_31] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514365

Jdforrester-WMF added a comment.Jun 4 2019, 6:24 PM

Remaining matches to quibble-stretch(-bundle:0.0.31-[^3]|-hhvm:0.0.31-[^2]|-php70:0.0.31-[^4]|-php71:0.0.31-[^2]|-php72:0.0.31-[^4]|-php73:0.0.31-[^3]|:0.0.31-[^2]) are

gerritbot added a comment.Jun 4 2019, 7:16 PM

Change 514349 merged by jenkins-bot:
[mediawiki/core@REL1_32] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514349

gerritbot added a comment.Jun 4 2019, 7:19 PM

Change 514341 merged by jenkins-bot:
[mediawiki/core@REL1_33] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514341

ReleaseTaggerBot added projects: MW-1.32-notes, MW-1.33-notes.Jun 4 2019, 8:00 PM
gerritbot added a comment.Jun 4 2019, 8:03 PM

Change 514365 merged by jenkins-bot:
[mediawiki/core@REL1_31] selenium: wdio-mocha-framework now v0.6.4

https://gerrit.wikimedia.org/r/514365

Jdforrester-WMF moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Jun 4 2019, 8:56 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes.Jun 4 2019, 9:00 PM
gerritbot added a comment.Jun 7 2019, 12:00 AM

Change 514987 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@fundraising/REL1_31] Update packages for node 10 / npm 6

https://gerrit.wikimedia.org/r/514987

Jdforrester-WMF closed this task as Resolved.Jun 7 2019, 11:55 PM
Jdforrester-WMF moved this task from In-progress to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
Jdforrester-WMF removed a project: Patch-For-Review.

Only outstanding patch is just waiting for FR to merge.

gerritbot added a comment.Jun 19 2019, 6:05 PM

Change 514987 abandoned by Ejegg:
Update packages for node 10 / npm 6

Reason:
Nothing left to merge after rebase, looks like this was covered in the security merge from 1_31

https://gerrit.wikimedia.org/r/514987

Jdforrester-WMF closed subtask T224997: Update MobileFrontend-npm-run-lint-modules-docker to run node10 as Declined.Jul 8 2019, 11:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits