Page MenuHomePhabricator
Create Task
Maniphest T231385

Recognize EXIF value for iOS Panorama images
Closed, ResolvedPublic
Actions

Description

See: https://sno.phy.queensu.ca/~phil/exiftool/TagNames/EXIF.html

This information is coded in the CustomRendered option, which we already support, but not these parts of it.

Details

SubjectRepoBranchLines +/-
Revert "Recognize exif values for Apple iOS photo modes"mediawiki/coremaster+2 -22
Recognize exif values for Apple iOS photo modesmediawiki/coremaster+22 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Aug 27 2019, 8:35 PM
gerritbot added a comment.Aug 27 2019, 8:37 PM

Change 532783 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] Recognize exif values for Apple iOS photo modes

https://gerrit.wikimedia.org/r/532783

gerritbot added a project: Patch-For-Review.Aug 27 2019, 8:37 PM
TheDJ added a comment.Aug 27 2019, 8:38 PM

For this too, we will have to force a refresh of the EXIF metadata of all jpgs..

Jdforrester-WMF added a comment.Aug 27 2019, 8:57 PM

Do we want to try to land them together so we can co-ordinate?

Jdforrester-WMF added a comment.Aug 27 2019, 9:32 PM

… or should we just merge this one now and wait for the XMPReader update before running the refresh?

TheDJ added a comment.EditedAug 27 2019, 9:37 PM

probably the latter. Who knows, i might discover more useful missing properties ;)

Jdforrester-WMF added a parent task: T231393: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands.Aug 27 2019, 10:02 PM
gerritbot added a comment.Aug 27 2019, 10:22 PM

Change 532783 merged by jenkins-bot:
[mediawiki/core@master] Recognize exif values for Apple iOS photo modes

https://gerrit.wikimedia.org/r/532783

Jdforrester-WMF closed this task as Resolved.Aug 27 2019, 10:32 PM
Jdforrester-WMF assigned this task to TheDJ.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 11:10 PM
DannyS712 mentioned this in T231427: [BUG] Internal error "Invalid option newbies" on Special:NewFiles.Aug 28 2019, 11:20 AM
gerritbot added a comment.Aug 28 2019, 11:24 AM

Change 532979 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Recognize exif values for Apple iOS photo modes"

https://gerrit.wikimedia.org/r/532979

gerritbot added a project: Patch-For-Review.Aug 28 2019, 11:24 AM
DannyS712 reopened this task as Open.Aug 28 2019, 11:25 AM
DannyS712 triaged this task as High priority.
DannyS712 subscribed.

Reverting; causes tests to fail, see T231427#5445266

gerritbot added a comment.Aug 28 2019, 11:51 AM

Change 532979 abandoned by Bartosz Dziewoński:
Revert "Recognize exif values for Apple iOS photo modes"

Reason:
Fixing the test failure with https://gerrit.wikimedia.org/r/c/mediawiki/core/ /532986 instead. The documentation messages were apparently removed by the translation updater bot.

https://gerrit.wikimedia.org/r/532979

matmarex closed this task as Resolved.Aug 28 2019, 11:57 AM
matmarex subscribed.
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 12:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits