1.35.0-wmf.18 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	• mmodell
	Sep 25 2019, 10:14 PM

Details

Backup Train Conductor: dduvall
Release Version: 1.35.0-wmf.18
Release Date: Feb 3 2020, 12:00 AM

2020 week 06 1.35-wmf.18 Changes wmf/1.35.0-wmf.18

This MediaWiki Train Deployment is scheduled for the week of Monday, February 3rd:

Monday February 3rd	Tuesday, February 4th	Wednesday, February 5th	Thursday, February 6th	Friday
Backports only.	Branch `wmf.18` and deploy to Group 0 Wikis.	Deploy `wmf.18` to Group 1 Wikis.	Deploy `wmf.18` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.18 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.17

Next: 1.35.0-wmf.19

Revisions and Commits

rMW MediaWiki
	rMWdbbfeec17d70 Include wmf/1.35.0-wmf.18 submodules and default settings

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	• mmodell	T233866 1.35.0-wmf.18 deployment blockers
Resolved	PRODUCTION ERROR	Peter.ovchyn	T244300 Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207
Resolved	PRODUCTION ERROR	Jdlrobson	T244405 PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php
Resolved		Tarrow	T244529 mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18
Resolved	PRODUCTION ERROR	• Mholloway	T244591 Argument 4 passed to GoogleCloudVisionHandler must be an instance of WikidataDepictsSetter

Event Timeline

• mmodell created this task.Sep 25 2019, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:14 PM

thcipriani assigned this task to • mmodell.Jan 16 2020, 10:08 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: dduvall.

thcipriani added a project: Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.

RhinosF1 mentioned this in T233864: 1.35.0-wmf.16 deployment blockers.Jan 24 2020, 10:35 PM

Lucas_Werkmeister_WMDE added a subtask: T244019: Inconsistent user permissions for users who were recently added to a new group.Jan 31 2020, 12:16 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-04T20:06:00Z] <marxarelli> temporarily holding 1.35.0-wmf.18 [T233866] branch cut and train due to concurrent maps prod issues

Mentioned in SAL (#wikimedia-operations) [2020-02-04T20:20:02Z] <twentyafterfour> branching mediawiki to wmf/1.35.0-wmf.18 from commit 054dd94e97d6 - train blockers should be added as subtasks under T233866

Jdforrester-WMF subscribed.Feb 4 2020, 8:26 PM

branch cut for wmf.18: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/570138

• mmodell added a commit: rMWdbbfeec17d70: Include wmf/1.35.0-wmf.18 submodules and default settings.Feb 4 2020, 9:29 PM

Change 570144 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] testwikis wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570144

Change 570144 merged by jenkins-bot:
[operations/mediawiki-config@master] testwikis wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570144

Mentioned in SAL (#wikimedia-operations) [2020-02-04T21:41:48Z] <twentyafterfour@deploy1001> Started scap: testwikis wikis to 1.35.0-wmf.18 refs T233866

Mentioned in SAL (#wikimedia-operations) [2020-02-04T22:13:51Z] <twentyafterfour@deploy1001> Finished scap: testwikis wikis to 1.35.0-wmf.18 refs T233866 (duration: 32m 03s)

Change 570157 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570157

Change 570157 merged by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570157

Mentioned in SAL (#wikimedia-operations) [2020-02-04T22:35:16Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group0 wikis to 1.35.0-wmf.18 refs T233866

Reedy added a subtask: T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.Feb 4 2020, 10:55 PM

zeljkofilipin mentioned this in T244019: Inconsistent user permissions for users who were recently added to a new group.Feb 5 2020, 2:43 PM

Reedy closed subtask T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207 as Resolved.Feb 5 2020, 5:35 PM

Jdforrester-WMF removed a subtask: T244019: Inconsistent user permissions for users who were recently added to a new group.Feb 5 2020, 6:22 PM

Train status: Unblocked. The train will move forward, at least until there is more evidence for production impact or other serious fallout from T244300.

Tentatively removed as a blocker:
- T244019: Inconsistent user permissions for users who were recently added to a new group, the production impact from this is only theoretical or at least uncertain.
Resolved (thank you!):
- T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207

Mentioned in SAL (#wikimedia-operations) [2020-02-05T20:09:49Z] <twentyafterfour> Preparing to deploy wmf/1.35.0-wmf.18 to group1 wikis refs T233866

• Mholloway subscribed.Feb 5 2020, 8:12 PM

Change 570429 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570429

Change 570429 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570429

Mentioned in SAL (#wikimedia-operations) [2020-02-05T20:44:12Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group1 wikis to 1.35.0-wmf.18 refs T233866

Mentioned in SAL (#wikimedia-operations) [2020-02-05T20:45:19Z] <twentyafterfour@deploy1001> Synchronized php: group1 wikis to 1.35.0-wmf.18 refs T233866 (duration: 01m 07s)

Change 570710 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570710

Change 570710 merged by jenkins-bot:
[operations/mediawiki-config@master] all wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/570710

Mentioned in SAL (#wikimedia-operations) [2020-02-06T20:25:24Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: all wikis to 1.35.0-wmf.18 refs T233866

Change 570713 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.16 refs T233866

https://gerrit.wikimedia.org/r/570713

Change 570713 merged by 20after4:
[operations/mediawiki-config@master] group2 wikis to 1.35.0-wmf.16 refs T233866

https://gerrit.wikimedia.org/r/570713

Krinkle added a subtask: T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.Feb 6 2020, 8:45 PM

Krinkle reopened subtask T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php as Open.

Nemo_bis mentioned this in T240858: Clean up implementation for "follow" cases.Feb 6 2020, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-06T21:40:33Z] <twentyafterfour> train blocked due to serious incident related to deploying the latest branch. Incident documentation: https://wikitech.wikimedia.org/wiki/Incident_documentation/20200206-mediawiki refs T233866

Window over so assuming it gets unblocked the train will resume on Monday.

• mmodell changed the task status from Open to Stalled.Feb 6 2020, 10:45 PM

• mmodell raised the priority of this task from Medium to Unbreak Now!.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 6 2020, 10:45 PM

We need help with T240858. It appears like the train deleted a message on all group 1 wikis it should not have been deleted.

Xover subscribed.Feb 7 2020, 11:23 AM

In T233866#5858082, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2020-02-06T21:40:33Z] <twentyafterfour> train blocked due to serious incident related to deploying the latest branch. Incident documentation: https://wikitech.wikimedia.org/wiki/Incident_documentation/20200206-mediawiki refs T233866

We just tried deploying a config change for T244529 to fix an UBN, and that went wrong, and revealed that infact this config setting being wrong and the defaults changing in Wikibase for .18 is what is blocking the train.

Summary of the blocker at T244529#5859927

Mentioned in SAL (#wikimedia-operations) [2020-02-07T17:22:38Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: roll back all wikis to 1.35.0-wmf.16 refs T233866

Mentioned in SAL (#wikimedia-operations) [2020-02-07T17:32:18Z] <twentyafterfour@deploy1001> Synchronized wmf-config/InitialiseSettings.php: sync https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/570929 refs T233866 (duration: 01m 02s)

Mentioned in SAL (#wikimedia-operations) [2020-02-07T17:36:13Z] <twentyafterfour@deploy1001> Synchronized wmf-config/InitialiseSettings.php: sync InitializeSettings again for lols refs T233866 (duration: 01m 03s)

If .18 restarts next week then the backport for .18 in T244529 is needed for sure and is a blocker.
If next week we roll .19 then T244529 is no longer a blocker, as the patch is already merged in master.

Krinkle added a subtask: T244591: Argument 4 passed to GoogleCloudVisionHandler must be an instance of WikidataDepictsSetter.Feb 7 2020, 5:56 PM

matmarex closed subtask T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php as Resolved.Feb 7 2020, 10:26 PM

In T233866#5860166, @Addshore wrote:

If .18 restarts next week then the backport for .18 in T244529 is needed for sure and is a blocker.
If next week we roll .19 then T244529 is no longer a blocker, as the patch is already merged in master.

I want to deploy the backport as Adam is in vacation. Let me know if you want to roll out wmf.18

Mentioned in SAL (#wikimedia-operations) [2020-02-10T14:40:10Z] <twentyafterfour> MediaWiki Train: Running a full scap to prepare for moving forward to 1.35.0-wmf.18 ( T233866 )

• Mholloway closed subtask T244591: Argument 4 passed to GoogleCloudVisionHandler must be an instance of WikidataDepictsSetter as Resolved.Feb 10 2020, 2:40 PM

• mmodell changed the task status from Stalled to Open.Feb 10 2020, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-10T18:21:23Z] <twentyafterfour> MediaWiki train: finally moving forward with group0 wikis to 1.35.0-wmf.18 refs T233866

Change 571331 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/571331

Change 571331 merged by jenkins-bot:
[operations/mediawiki-config@master] group1 wikis to 1.35.0-wmf.18 refs T233866

https://gerrit.wikimedia.org/r/571331

Mentioned in SAL (#wikimedia-operations) [2020-02-10T18:38:04Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group1 wikis to 1.35.0-wmf.18 refs T233866

Mentioned in SAL (#wikimedia-operations) [2020-02-10T18:39:10Z] <twentyafterfour@deploy1001> Synchronized php: group1 wikis to 1.35.0-wmf.18 refs T233866 (duration: 01m 05s)

Ladsgroup closed subtask T244529: mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18 as Resolved.Feb 10 2020, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-11T18:43:44Z] <twentyafterfour> getting ready to deploy wmf.18 refs T233866

This is (finally) fully deployed. Declaring it done.

Assuming any remaining patch is no longer relevant at this point

1.35.0-wmf.18 deployment blockersClosed, ResolvedPublicReleaseActions