Page MenuHomePhabricator
Create Task
Maniphest T236460

Regression: Changes to email blacklist or muted users do not activate Save button in Preferences
Closed, ResolvedPublic
Actions

Description

The Save button in Special:Preferences is supposed to only be greyed out until you change something. It remains greyed out if you only change the email blacklist at "Prohibit these users from emailing me" under "User profile", or the muted users at "Do not display notifications from these users" under "Notifications".

The Save button works if you also change another preference, but returns to greyed out if you change the other preference back before saving.

(I just copied from T192147, it seems to have regressed again.)

Details

SubjectRepoBranchLines +/-
mw.widgets.UsersMultiselectWidget: Fix property namemediawiki/coremaster+1 -1
mw.widgets.UsersMultiselectWidget: Fix property namemediawiki/corewmf/1.35.0-wmf.4+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Oct 25 2019, 7:06 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 25 2019, 7:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Raymond subscribed.Oct 26 2019, 8:24 AM
Mainframe98 merged a task: T236597: Ignoring users is not working.Oct 26 2019, 4:29 PM
Mainframe98 added a subscriber: DaBPunkt.
Urbanecm merged a task: T236634: Could not add users to blacklist.Oct 27 2019, 10:53 PM
Urbanecm added subscribers: Luke081515, Der-Wir-Ing.
Count_Count subscribed.Oct 28 2019, 10:08 AM
Etonkovidova added a subscriber: matmarex.Oct 31 2019, 10:10 PM
matmarex added subscribers: Esanders, Jdforrester-WMF.Oct 31 2019, 11:26 PM

Caused by rMWa3e3a8032942: Always $-prefix jQuery variable names

gerritbot added a comment.Oct 31 2019, 11:28 PM

Change 547685 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547685

gerritbot added a project: Patch-For-Review.Oct 31 2019, 11:28 PM
gerritbot added a comment.Nov 1 2019, 1:03 AM

Change 547685 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547685

gerritbot added a comment.Nov 1 2019, 1:03 AM

Change 547692 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.35.0-wmf.4] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547692

gerritbot added a comment.Nov 1 2019, 1:14 AM

Change 547692 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.4] mw.widgets.UsersMultiselectWidget: Fix property name

https://gerrit.wikimedia.org/r/547692

Stashbot added a comment.Nov 1 2019, 1:21 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-01T01:21:31Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.4/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js: T236460 mw.widgets.UsersMultiselectWidget: Fix property name (duration: 00m 54s)

Jdforrester-WMF closed this task as Resolved.Nov 1 2019, 1:22 AM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.4; 2019-10-29); removed Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Nov 1 2019, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits