Some suggested copy changes to the mocks related to this story too. Changes must be agreed upon:

What changed:

• Rephrased the sentence "You can save your changes as an anonymous user", by a less inaccurate "You can save your changes without logging in"
• The button copy changed from "Save without logging in" to "Save as IP user", to be more communicative of the compromise that users will be making.

Note: These copy changes also impact story T244360

Please share your thoughts!

I think in MediaWiki, “user” is often used as a shorthand for “registered user”, so I feel like “IP user” might be confusing… I don’t have any better suggestion, though.

I’m also worried about the “Log in (Opens in a new tab)” button label – I’m afraid that some translations of it will be long enough that they don’t fit into the button anymore.

In the story writing the question came up: "how can we, upon sending the user to the login page in a new tab, communicate to them to close the tab and return to bridge after login?".

Option 1: to show a message to the user on the login page (above the username & password fields), we could use the warning parameter, e.g.
https://en.wikipedia.org/w/index.php?title=Special:UserLogin&warning=mobile-frontend-watchlist-purpose (message keys which are applicable can be manipulated via the LoginFormValidErrorMessages hook)

I did not find a built-in way to show a message on the default login success page (LoginSignupSpecialPage::showSuccessPage()) short of using the UserLoginComplete hook to (conditionally?) manipulate $injected_html - which feels rather iffy.

Option 2: to show a message after successful login is to create a dedicated page for this purpose and use it as the returnto parameter of the login, e.g.
https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Special:BridgeWaitingForYou

Option 1 is rather simple to implement but is not ideally placed in the user journey. Option 2 appears in the right moment and offers more possibilities, but comes at the price of maintaining the weird landing page.

Hello! Thank you for bringing up these points.

In T247250#5997934, @Lucas_Werkmeister_WMDE wrote:

I think in MediaWiki, “user” is often used as a shorthand for “registered user”, so I feel like “IP user” might be confusing… I don’t have any better suggestion, though.

we changed it back to the old copy

I’m also worried about the “Log in (Opens in a new tab)” button label – I’m afraid that some translations of it will be long enough that they don’t fit into the button anymore.

i have added a mock to the ticket and figma board of how it'll look when the button spans two lines.
quick question regarding this: would it be possible to separate the two copy parts somehow? part 1: log in part 2: (opens in a new tab)
in such a way that when the line break happens, the break would preferably happen between the two parts, instead of before the first word that is too long for the first line. Do you know what i mean?

Splitting the message into two parts would be possible, and I think it would be acceptable as well, though it goes a little bit in the direction of a “lego message”. I’m not sure how much influence we have over the line breaking, though – unless we completely disable line breaks in the “opens in a new tab” part?

In T247250#6010070, @Pablo-WMDE wrote:

In the story writing the question came up: "how can we, upon sending the user to the login page in a new tab, communicate to them to close the tab and return to bridge after login?".

Story writing note: we’ll go with option 1 for now.

Option 1: to show a message to the user on the login page (above the username & password fields), we could use the warning parameter, e.g.
https://en.wikipedia.org/w/index.php?title=Special:UserLogin&warning=mobile-frontend-watchlist-purpose (message keys which are applicable can be manipulated via the LoginFormValidErrorMessages hook)

I'm confused about the role of Go Back/Keep editing button(or link).
The task says:

GIVEN an IP save error
WHEN the user clicks "go back"
THEN the Bridge returns to the state before save was clicked

The AC says:

go back button is only shown on desktop and styled as a link
back arrow is shown on mobile to get back to previous screen

The Notes say:

The desktop version shows a "Go back" link that takes users back to the editor. In the mobile version, that go back action has to be performed by using the back navigation button in the header

The Figma designs suggest it's called "Keep editing".

Q1: Does Product and/or Design refer to the desktop "Go back"/"Keep editing" as a link or as a button?
Q2: Does that button/link go back to bridge's previous screen or does it close bridge and go back to the Visual Editor?
cc @Lydia_Pintscher @Charlie_WMDE @SaraiSan

Sorry about the confusion! We renamed the link text to say "Keep editing" but forgot to change it in the ticket :(

A1: I guess we referred to it as whatever. But have no agreed that it should be a quiet button
A2: it goes back to the bridge's previous screen

sorry about that again

Change 596167 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] ErrorSavingAssertUser: consistently space buttons

https://gerrit.wikimedia.org/r/596167

Change 596184 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Make proceed button use save or publish text

https://gerrit.wikimedia.org/r/596184

Change 596167 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ErrorSavingAssertUser: consistently space buttons

https://gerrit.wikimedia.org/r/596167

Change 596184 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Make proceed button use save or publish text

https://gerrit.wikimedia.org/r/596184