[EPIC] Support User-Agent Client Hints header in CheckUser
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Goal

Google Chrome sends a reduced user agent header (see T242825: Deal with Google Chrome User-Agent deprecation for more context). This impacts the work of CheckUsers who rely on detailed user agent header in detecting sockpuppets. After talking to Legal, Trust&Safety and stewards, the desired way forward is to continue to get the user-agent data from Chrome, per Chrome's proposed Client-Hints standard. The standard is not yet implemented by Firefox or Safari. Mozilla's position on the standard is "neutral".

Acceptance criteria

Extension:CheckUser stores and displays high entropy client-hint data, similarly to how it currently stores and displays user agent data
- Extension:CheckUser stores client hint header data for specific actions (form edit) | T258105: Implement storage for User-Agent Client Hints header data
- Extension:CheckUser deletes high-entropy client hint header data after 90 days | T337943: Update maintenance/purgeOldData to remove client hint data T340959: Update CheckUser prune job to remove client hint data
- Extension:CheckUser displays client hint header data | T337942: Display client hint data
MediaWiki requests client hint header for web and API entrypoints that CheckUser needs to log (edit) | T337944: Implement support for requesting client hint header

Details

Other Assignee: Dreamy_Jazz

Subject	Repo	Branch	Lines +/-
clienthints: Enable purging of data on all wikis	operations/mediawiki-config	master	+1 -2
Revert "Request high-entropy Sec-CH-UA* client hints"	operations/puppet	production	+1 -67
Request User-Agent Client-Hints on MediaWiki's Responses	mediawiki/core	master	+12 -0

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Resolved		Dreamy_Jazz	T337942 Display client hint data
Resolved		Dreamy_Jazz	T337943 Update maintenance/purgeOldData to remove client hint data
Resolved		kostajh	T337944 Implement support for requesting client hint header
Resolved		Dreamy_Jazz	T340959 Update CheckUser prune job to remove client hint data
Open		None	T340992 Return client hint data in CheckUser API results
Resolved		Dreamy_Jazz	T341093 Provide public explanation of how and why we make use of high entropy user-agent client hints
Open		None	T341094 Create client hint mapping rows for CheckUser-worthy events
Resolved		Dreamy_Jazz	T341110 Deploy client hints functionality
Resolved		kostajh	T258105 Implement storage for User-Agent Client Hints header data
Resolved	BUG REPORT	Dreamy_Jazz	T344679 CheckUser Client Hints ResourceLoader module causing cache polution
Resolved		Dreamy_Jazz	T342134 Limit the ability for other users after the fact storing client hints data using the REST API
Declined		Dreamy_Jazz	T342138 Prevent saving client hints data when the reference ID does not exist in the table
Duplicate	PRODUCTION ERROR	None	T344788 Error 1062 from MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows, Duplicate entry '1147-0-1171766075' for key 'PRIMARY' INSERT INTO `cu_useragent_clienthints_map`
Resolved	PRODUCTION ERROR	Dreamy_Jazz	T344787 [{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'X-X-X' for key 'PRIMARY' Function: MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows
Declined		Dreamy_Jazz	T344826 Add ClientHints header to action=history views when using cached response via HtmlFileCache
Declined		Dreamy_Jazz	T344828 Send Client Hints headers on 304 response for action=history view.
Resolved	PRODUCTION ERROR	Dreamy_Jazz	T344873 [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager)
Duplicate	PRODUCTION ERROR	None	T344875 [{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'X-X-X' for key 'PRIMARY' Function: MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows Query: INSERT INTO `cu_useragent_clienthints_map where query doesn't include duplicated rows
Resolved	PRODUCTION ERROR	Dreamy_Jazz	T344901 TypeError: Argument 1 passed to MediaWiki\CheckUser\ClientHints\ClientHintsData::newFromJsApi() must be of the type array, null given
Open		None	T344983 Flow: Fire postEdit hook after making an edit
Open		None	T344984 [REPO][CLIENT][SW] Wikibase: Fire postEdit hook after making an edit
Declined		None	T345030 Should Accept-CH headers that request Client Hints data on action=history be set only when the user has rollback rights?
Resolved	BUG REPORT	RajashreeTalukdar	T344979 brands and fullVersionList might get the "brand" and "version" the wrong way round
Open		None	T345076 Consider ways to reduce the row count in cu_useragent_clienthints_map
Open		None	T345134 Improve load times for Special:CheckUser's 'Get edits' mode
Resolved		kostajh	T345229 Fire postEdit hook when performing a rollback
Resolved	BUG REPORT	Dreamy_Jazz	T345398 Error: exception of type TypeError: MediaWiki\CheckUser\ClientHints\ClientHintsData::__construct() when array passed for non-array Client Hints value
Resolved		Dreamy_Jazz	T345649 Trim uach_value before insertion to the database
Resolved		KColeman-WMF	T342044 Survey CUs on release 0 wikis for thoughts on display of client hints data
			· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

kostajh claimed this task.Jun 1 2023, 10:43 AM

kostajh raised the priority of this task from Low to High.

kostajh added a project: Epic.

kostajh updated the task description. (Show Details)

kostajh removed a parent task: T258105: Implement storage for User-Agent Client Hints header data.

kostajh added a subtask: T258105: Implement storage for User-Agent Client Hints header data.

kostajh removed subscribers: • EChetty, • aezell, • SPoore, • dpifke.

kostajh updated the task description. (Show Details)Jun 1 2023, 12:11 PM

Melos subscribed.Jun 1 2023, 1:06 PM

kostajh updated the task description. (Show Details)Jun 1 2023, 2:04 PM

kostajh updated the task description. (Show Details)

kostajh mentioned this in T337944: Implement support for requesting client hint header.Jun 1 2023, 2:39 PM

kostajh updated the task description. (Show Details)Jun 1 2023, 2:49 PM

kostajh updated the task description. (Show Details)Jun 1 2023, 3:14 PM

kostajh changed the status of subtask T337944: Implement support for requesting client hint header from Open to In Progress.

dom_walden unsubscribed.Jun 1 2023, 3:35 PM

Xaosflux subscribed.Jun 1 2023, 8:26 PM

kostajh added projects: http-client-hints, Google-Chrome-User-Agent-Deprecation.Jun 3 2023, 5:25 PM

Vermont subscribed.Jun 7 2023, 2:50 PM

kostajh changed the status of subtask T337944: Implement support for requesting client hint header from In Progress to Open.Jun 21 2023, 7:28 AM

kostajh removed a subtask: T337947: Include User-Agent Client Hints in WebRequest logs.

kostajh changed the status of subtask T258105: Implement storage for User-Agent Client Hints header data from Open to In Progress.

Novem_Linguae subscribed.Jun 28 2023, 9:10 PM

Dreamy_Jazz mentioned this in T325306: Provide aggregated user device data per-country.Jun 30 2023, 5:50 PM

mdaniels5757 unsubscribed.Jul 1 2023, 3:01 AM

Dreamy_Jazz updated the task description. (Show Details)Jul 3 2023, 5:57 PM

Dreamy_Jazz mentioned this in T341076: Creation of database tables cu_useragent_clienthints and cu_useragent_clienthints_map.Jul 4 2023, 2:57 PM

kostajh updated Other Assignee, added: Dreamy_Jazz.Jul 6 2023, 9:25 AM

nshahquinn-wmf subscribed.Jul 12 2023, 11:18 PM

Iflorez mentioned this in T341743: Can we see chatgpt accesses in logs?.Jul 17 2023, 11:58 PM

Dreamy_Jazz closed subtask T342138: Prevent saving client hints data when the reference ID does not exist in the table as Declined.Jul 24 2023, 4:47 PM

sbassett subscribed.Jul 28 2023, 6:04 PM

Dreamy_Jazz added a project: CheckUser.Aug 7 2023, 11:38 AM

Tchanders closed subtask T342134: Limit the ability for other users after the fact storing client hints data using the REST API as Resolved.Aug 14 2023, 10:22 AM

Tchanders closed subtask T340959: Update CheckUser prune job to remove client hint data as Resolved.Aug 14 2023, 11:02 AM

Tchanders closed subtask T337943: Update maintenance/purgeOldData to remove client hint data as Resolved.

Tchanders closed subtask T258105: Implement storage for User-Agent Client Hints header data as Resolved.

Tchanders closed subtask T337944: Implement support for requesting client hint header as Resolved.Aug 14 2023, 11:06 AM

Tchanders closed subtask T341093: Provide public explanation of how and why we make use of high entropy user-agent client hints as Resolved.Aug 14 2023, 11:16 AM

Krinkle removed a project: Performance-Team (Radar).Aug 18 2023, 8:13 PM

kostajh changed the status of subtask T341094: Create client hint mapping rows for CheckUser-worthy events from Open to Stalled.Aug 22 2023, 10:23 AM

Dreamy_Jazz added a subtask: T344679: CheckUser Client Hints ResourceLoader module causing cache polution.Aug 22 2023, 10:26 AM

kostajh added a subtask: T344788: Error 1062 from MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows, Duplicate entry '1147-0-1171766075' for key 'PRIMARY' INSERT INTO `cu_useragent_clienthints_map`.Aug 23 2023, 6:34 AM

Dreamy_Jazz added a subtask: T344787: [{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'X-X-X' for key 'PRIMARY' Function: MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows.Aug 23 2023, 6:44 AM

Dreamy_Jazz added a subtask: T344826: Add ClientHints header to action=history views when using cached response via HtmlFileCache.Aug 23 2023, 2:51 PM

Dreamy_Jazz added a subtask: T344828: Send Client Hints headers on 304 response for action=history view..Aug 23 2023, 2:56 PM

Dreamy_Jazz added a subtask: T344873: [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager).Aug 23 2023, 11:27 PM

Dreamy_Jazz added a subtask: T344875: [{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'X-X-X' for key 'PRIMARY' Function: MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows Query: INSERT INTO `cu_useragent_clienthints_map where query doesn't include duplicated rows.Aug 24 2023, 12:10 AM

Dreamy_Jazz added a subtask: T344901: TypeError: Argument 1 passed to MediaWiki\CheckUser\ClientHints\ClientHintsData::newFromJsApi() must be of the type array, null given.Aug 24 2023, 11:06 AM

phuedx unsubscribed.Aug 24 2023, 11:17 AM

kostajh added a subtask: T344983: Flow: Fire postEdit hook after making an edit.Aug 25 2023, 10:31 AM

kostajh added a subtask: T344984: [REPO][CLIENT][SW] Wikibase: Fire postEdit hook after making an edit.

Dreamy_Jazz added a subtask: T345030: Should Accept-CH headers that request Client Hints data on action=history be set only when the user has rollback rights?.Aug 26 2023, 9:04 PM

Dreamy_Jazz added a subtask: T344979: brands and fullVersionList might get the "brand" and "version" the wrong way round.Aug 28 2023, 12:51 PM

Dreamy_Jazz added a subtask: T345076: Consider ways to reduce the row count in cu_useragent_clienthints_map.Aug 28 2023, 1:41 PM

Dreamy_Jazz added a subtask: T345134: Improve load times for Special:CheckUser's 'Get edits' mode.Aug 29 2023, 8:44 AM

Dreamy_Jazz changed the status of subtask T341094: Create client hint mapping rows for CheckUser-worthy events from Stalled to Open.Aug 29 2023, 1:11 PM

kostajh added a subtask: T345229: Fire postEdit hook when performing a rollback.Aug 30 2023, 8:32 AM

Dreamy_Jazz closed subtask T345030: Should Accept-CH headers that request Client Hints data on action=history be set only when the user has rollback rights? as Declined.Aug 30 2023, 6:58 PM

Dreamy_Jazz added a subtask: T345398: Error: exception of type TypeError: MediaWiki\CheckUser\ClientHints\ClientHintsData::__construct() when array passed for non-array Client Hints value.Aug 31 2023, 10:01 PM

kostajh updated the task description. (Show Details)Sep 1 2023, 11:02 AM

Dreamy_Jazz added a subtask: T345649: Trim uach_value before insertion to the database.Sep 5 2023, 5:35 PM

kostajh mentioned this in T345787: useragent-clienthints REST API access by non-checkuser.Sep 7 2023, 9:01 AM

Change 958025 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] clienthints: Enable purging of data on all wikis

https://gerrit.wikimedia.org/r/958025

gerritbot added a project: Patch-For-Review.Sep 16 2023, 10:16 PM

Change 958025 merged by jenkins-bot:

[operations/mediawiki-config@master] clienthints: Enable purging of data on all wikis

https://gerrit.wikimedia.org/r/958025

Mentioned in SAL (#wikimedia-operations) [2023-09-18T20:15:00Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:958025|clienthints: Enable purging of data on all wikis (T257893)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-18T20:16:27Z] <cjming@deploy1002> cjming and dreamyjazz: Backport for [[gerrit:958025|clienthints: Enable purging of data on all wikis (T257893)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-09-18T20:24:25Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:958025|clienthints: Enable purging of data on all wikis (T257893)]] (duration: 09m 24s)

Novem_Linguae unsubscribed.Sep 19 2023, 8:28 AM

kostajh removed a parent task: T242825: Deal with Google Chrome User-Agent deprecation.Sep 26 2023, 10:40 AM

kostajh moved this task from Backlog to Release 2 (iteration, increase data collection coverage) on the http-client-hints board.Sep 26 2023, 12:11 PM

kostajh edited projects, added http-client-hints (Release 2 (iteration, increase data collection coverage)); removed http-client-hints.

kostajh closed subtask T344679: CheckUser Client Hints ResourceLoader module causing cache polution as Resolved.Sep 26 2023, 12:43 PM

kostajh closed subtask T344787: [{reqId}] {exception_url} Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'X-X-X' for key 'PRIMARY' Function: MediaWiki\CheckUser\Services\UserAgentClientHintsManager::insertMappingRows as Resolved.Sep 26 2023, 12:47 PM

kostajh closed subtask T344873: [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager) as Resolved.

kostajh closed subtask T344901: TypeError: Argument 1 passed to MediaWiki\CheckUser\ClientHints\ClientHintsData::newFromJsApi() must be of the type array, null given as Resolved.

kostajh added a subtask: T342044: Survey CUs on release 0 wikis for thoughts on display of client hints data.Sep 26 2023, 12:54 PM

kostajh closed subtask T345649: Trim uach_value before insertion to the database as Resolved.Sep 26 2023, 12:58 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 1:11 PM

kostajh closed subtask T345229: Fire postEdit hook when performing a rollback as Resolved.Sep 26 2023, 7:12 PM