Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays
Closed, ResolvedPublic
Actions

Description

When I was running extensions/GrowthExperiments/maintenance/migrateMentorMenteeRelationship.php for cswiki, @Marostegui notified me that "we are getting a bunch of Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays errors".

Stacktrace

from /srv/mediawiki/php-1.37.0-wmf.1/includes/libs/rdbms/database/Database.php(2245)
#0 /srv/mediawiki/php-1.37.0-wmf.1/includes/libs/rdbms/database/Database.php(3408): Wikimedia\Rdbms\Database->normalizeUpsertKeys(array)
#1 /srv/mediawiki/php-1.37.0-wmf.1/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->upsert(string, array, array, array, string)
#2 /srv/mediawiki/php-1.37.0-wmf.1/includes/libs/rdbms/database/DBConnRef.php(504): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#3 /srv/mediawiki/php-1.37.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Store/DatabaseMentorStore.php(105): Wikimedia\Rdbms\DBConnRef->upsert(string, array, array, array, string)
#4 /srv/mediawiki/php-1.37.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Store/DatabaseMentorStore.php(121): GrowthExperiments\Mentorship\Store\DatabaseMentorStore->setMentorForUserReal(User, User, string)
#5 /srv/mediawiki/php-1.37.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Store/MentorStore.php(149): GrowthExperiments\Mentorship\Store\DatabaseMentorStore->setMentorForUserInternal(User, User, string)
#6 /srv/mediawiki/php-1.37.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Store/SetUserMentorDatabaseJob.php(47): GrowthExperiments\Mentorship\Store\MentorStore->setMentorForUser(User, User, string)
#7 /srv/mediawiki/php-1.37.0-wmf.1/extensions/EventBus/includes/JobExecutor.php(79): GrowthExperiments\Mentorship\Store\SetUserMentorDatabaseJob->run()
#8 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#9 {main}

Logstash link: https://logstash.wikimedia.org/goto/004b938dedef4a372378b6b3460c78c7

Details

	Subject	Repo	Branch	Lines +/-
	DatabaseMentorStore: Fix deprecation warning in upsert query	mediawiki/extensions/GrowthExperiments	wmf/1.37.0-wmf.1	+1 -1
	DatabaseMentorStore: Fix deprecation warning in upsert query	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Urbanecm_WMF	T239234 [EPIC] Newcomer homepage: Mentorship dashboard
Resolved		Urbanecm_WMF	T278920 Mentor dashboard: V1 desktop
Resolved		Urbanecm_WMF	T278971 Mentor dashboard: M1 mentee overview module
Resolved		Urbanecm_WMF	T280007 Create MentorData{Uncached}Provider to provide data about mentor's mentees
Open		None	T289600 Mentor dashboard: Future release
Open		None	T279139 Mentor dashboard: M5 impact module
Resolved		Urbanecm_WMF	T275773 Move mentor/mentee relationship to a separate database table to make it possible to run more queries on it
Resolved	Apr 29 2021	Urbanecm_WMF	T279853 Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis
Resolved		Urbanecm_WMF	T280525 Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays

Event Timeline

Blocks the mentor/mentee migration, and logspam triggered by our team.

Urbanecm_WMF mentioned this in T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis.Apr 19 2021, 1:15 PM

Change 681079 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] DatabaseMentorStore: Fix deprecation warning in upsert query

https://gerrit.wikimedia.org/r/681079

gerritbot added a project: Patch-For-Review.Apr 19 2021, 1:24 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 19 2021, 1:25 PM

So apparently [ 'gemm_mentee_id', 'gemm_mentor_role' ] is normalized into [ [ 'gemm_mentee_id' ], [ 'gemm_mentor_role' ] ] which is incorrect (it would mean gemm_mentee_id and gemm_mentor_role are both unique keys). It doesn't really matter in this case because the MySQL implementation of the database layer ignores this parameter completely (it uses ON DUPLICATE KEY UPDATE while the generic implementation would make a normal UPDATE with the given unique keys and an INSERT if that doesn't update anything). A very error-prone pattern though so good job deprecating it; bad job not really documenting that it's deprecated.

Change 681079 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DatabaseMentorStore: Fix deprecation warning in upsert query

https://gerrit.wikimedia.org/r/681079

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 3:00 PM

Change 680860 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.1] DatabaseMentorStore: Fix deprecation warning in upsert query

https://gerrit.wikimedia.org/r/680860

Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Apr 19 2021, 3:25 PM

Change 680860 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.1] DatabaseMentorStore: Fix deprecation warning in upsert query

https://gerrit.wikimedia.org/r/680860

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 6:00 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-19T18:02:19Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Store/DatabaseMentorStore.php: 0233507470377f6ac45768e345cd2e359e5d0e57: DatabaseMentorStore: Fix deprecation warning in upsert query (T280525) (duration: 00m 57s)