Page MenuHomePhabricator
Create Task
Maniphest T280688

Show Suggested Values field if the type should allow it
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Bug description
Ran into a bug when testing on beta by editing the existing TemplateData for Infobox person in the TemplateData Editor:

  • Suggested values field didn't show for parameters with the types for which it should be enabled, until I clicked on and re-selected the type or selected another type for which it is enabled. Only after I interacted with the "type" field would the suggested values field show below it.
  • I also tested with adding new TemplateData and new parameters. They are set by default to type "Unknown", which should then show the suggested values field in the TemplateData Editor automatically, but I still had to do the same work around to get it to appear. (recorded screen to show this)

bug_suggested values.mov916 KBDownload

Required behavior

  • If a parameter is set to one of the types where Suggested Values should be visible, this field is visible in the TemplateData Editor without the user taking any action.

Details

SubjectRepoBranchLines +/-
Fix suggested values not being shown when the param's type isn't specifiedmediawiki/extensions/TemplateDatawmf/1.37.0-wmf.1+3 -3
Fix suggested values not being shown when the param's type isn't specifiedmediawiki/extensions/TemplateDatamaster+3 -3
Inline fix for suggested values on unkown paramter typesmediawiki/extensions/TemplateDatamaster+2 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ECohen_WMDE created this task.Apr 20 2021, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 3:25 PM
ECohen_WMDE renamed this task from Show Suggested Values field for existing parameters if the type matches to Show Suggested Values field if the type should show allow it.Apr 20 2021, 3:26 PM
Maintenance_bot added a project: VisualEditor.Apr 20 2021, 3:45 PM
Lena_WMDE updated the task description. (Show Details)Apr 21 2021, 6:52 AM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE renamed this task from Show Suggested Values field if the type should show allow it to Show Suggested Values field if the type should allow it.Apr 21 2021, 6:54 AM
ECohen_WMDE updated the task description. (Show Details)Apr 21 2021, 8:22 AM
Lena_WMDE set the point value for this task to 2.Apr 21 2021, 1:05 PM
Lena_WMDE added projects: WMDE-TechWish-Sprint-2021-04-14, Unplanned-Sprint-Work.
WMDE-Fisch subscribed.Apr 21 2021, 1:06 PM

We might want to backport the potential patch to be sure it's there when released on the 29th.

Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Apr 21 2021, 1:18 PM
Andrew-WMDE claimed this task.Apr 22 2021, 7:25 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-04-14 board.
gerritbot added a comment.Apr 22 2021, 8:32 AM

Change 681932 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/TemplateData@master] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681932

gerritbot added a project: Patch-For-Review.Apr 22 2021, 8:32 AM
Andrew-WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 22 2021, 9:06 AM
gerritbot added a comment.Apr 22 2021, 9:59 AM

Change 681932 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681932

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 22 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 22 2021, 10:10 AM
WMDE-Fisch moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 22 2021, 10:36 AM
gerritbot added a comment.Apr 22 2021, 3:40 PM

Change 681969 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):

[mediawiki/extensions/TemplateData@wmf/1.37.0-wmf.1] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681969

gerritbot added a project: Patch-For-Review.Apr 22 2021, 3:40 PM
WMDE-Fisch added a comment.Apr 22 2021, 3:47 PM

Backport scheduled for Monday 1pm window so we're save that the fix is present even when the train gets stuck.

https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1909312&oldid=1909239

gerritbot added a comment.Apr 23 2021, 8:17 AM

Change 682091 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TemplateData@master] Inline fix for suggested values on unkown paramter types

https://gerrit.wikimedia.org/r/682091

gerritbot added a comment.Apr 23 2021, 8:52 AM

Change 682091 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Inline fix for suggested values on unkown paramter types

https://gerrit.wikimedia.org/r/682091

gerritbot added a comment.Apr 26 2021, 11:38 AM

Change 681969 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@wmf/1.37.0-wmf.1] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681969

Stashbot added a comment.Apr 26 2021, 11:45 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-26T11:45:04Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/TemplateData/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js: rETDAa347517f906b: Fix suggested values not being shown when the params type isnt specified (T280688) (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 12:10 PM
Lena_WMDE closed this task as Resolved.Apr 27 2021, 8:37 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits