Page MenuHomePhabricator
Create Task
Maniphest T306719

Hide TOC in print mode (Vector 2022)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
bwang
Apr 22 2022, 5:31 PM
Tags
Referenced Files
F35251971: Screen Recording 2022-06-18 at 6.31.22 PM.mov.gif
Jun 19 2022, 1:32 AM
F35251969: Screen Recording 2022-06-18 at 6.28.45 PM.mov.gif
Jun 19 2022, 1:31 AM
F35236020: Screen Shot 2022-06-13 at 12.37.30 PM.png
Jun 13 2022, 4:37 PM
F35063115: Screen Shot 2022-04-22 at 12.28.10 PM.png
Apr 22 2022, 5:31 PM
F35063118: Screen Shot 2022-04-21 at 11.40.22 AM.png
Apr 22 2022, 5:31 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Jdlrobson
Una_tantum

Description

Description

The table of contents is not critical when printing an article. In a perfect world we would give people the option to include it if they want when printing the article. For now we will hide it when printing the article. (Link to village pump discussion)

AC

  • Hide the TOC when printing an article

QA

Find an article with a table of contents in the sidebar. Click print.

  • There should be no table of contents in the article (note: Clare is turning off the A/B test on beta cluster on Mon June 13th and after that you should not be seeing any kind of table of contents in print mode on the the beta cluster)

Developer notes

Because of the new TOC's location in the DOM, in print mode it is going to go above the h1. Ideally it goes under the h1

QA Results - Beta

ACStatusDetails
1✅T306719#8013317

QA Results - Prod

ACStatusDetails
1✅T306719#8013320

Details

SubjectRepoBranchLines +/-
Hide TOC in print mode and clean up other print stylesmediawiki/skins/Vectormaster+9 -32
Customize query in gerrit

Related Objects

Event Timeline

bwang created this task.Apr 22 2022, 5:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2022, 5:31 PM
bwang updated the task description. (Show Details)Apr 22 2022, 5:35 PM
ovasileva triaged this task as Medium priority.Apr 25 2022, 8:31 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
Jdlrobson assigned this task to • alexhollender_WMF.Apr 25 2022, 5:50 PM
Jdlrobson subscribed.

Alex, is the table of contents helpful in print mode? If so, does it make sense to have it at the top of the printed page, or on a separate page, or to have a slightly different design?

Jdlrobson moved this task from Needs triage to Vector 2022 (tracking) on the Vector (legacy skin) board.Apr 25 2022, 9:32 PM
Jdlrobson merged a task: T309501: "Download as PDF": articles with double TOC.Jun 1 2022, 9:26 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Una_tantum.
• alexhollender_WMF added a comment.Jun 2 2022, 5:27 PM

I asked on village pump (link to discussion) and it seems like the popular opinion is that it depends on the article. @Jdlrobson perhaps in the future we could add a feature that allows people to choose if they want to include the table of contents?

• alexhollender_WMF renamed this task from TOC should be styled for print mode in modern Vector to Hide TOC in print mode (Vector 2022).Jun 2 2022, 5:29 PM
• alexhollender_WMF updated the task description. (Show Details)
• alexhollender_WMF updated the task description. (Show Details)
Jdlrobson removed • alexhollender_WMF as the assignee of this task.Jun 2 2022, 6:27 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: • alexhollender_WMF.
LGoto moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Jun 7 2022, 5:19 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang claimed this task.Jun 9 2022, 3:08 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 9 2022, 7:11 PM

Change 804428 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Hide TOC in print mode

https://gerrit.wikimedia.org/r/804428

gerritbot added a project: Patch-For-Review.Jun 9 2022, 7:11 PM
bwang removed bwang as the assignee of this task.Jun 9 2022, 7:15 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 10 2022, 12:12 AM

Change 804428 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide TOC in print mode and clean up other print styles

https://gerrit.wikimedia.org/r/804428

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2022, 12:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 10 2022, 1:00 AM
Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 10 2022, 10:20 PM
Jdlrobson assigned this task to • alexhollender_WMF.Jun 10 2022, 10:25 PM
• alexhollender_WMF added a comment.Jun 13 2022, 4:37 PM

@Jdlrobson @bwang where should i test this? still seeing the TOC in the printed version on beta

Screen Shot 2022-06-13 at 12.37.30 PM.png (1×1 px, 794 KB)

Jdlrobson added a comment.Jun 13 2022, 4:44 PM

Alex: I think we're currently only hiding the new table of contents. The legacy one is still there, but will disappear this week once the A/B test is completed.

• alexhollender_WMF added a comment.Jun 13 2022, 4:47 PM
In T306719#7999585, @Jdlrobson wrote:

Alex: I think we're currently only hiding the new table of contents. The legacy one is still there, but will disappear this week once the A/B test is completed.

okay. is there anything you want me to review?

just to note: the page i was looking at in beta has the new table of contents.

Jdlrobson moved this task from Design Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 13 2022, 4:52 PM

just to note: the page i was looking at in beta has the new table of contents.

Yep but we currently have both table of contents in the page for narrow screens.

okay. is there anything you want me to review?

If you check a printed article on English Wikipedia you'll see a table of contents at the top of the page: https://en.wikipedia.org/wiki/Kal%C4%81kaua%27s_1881_world_tour
Design review was checking that's gone. I think we can move this to QA.

@bwang I'm not sure it makes sense to hide the legacy table of contents since next week this will be a non-issue. What do you think?

• alexhollender_WMF reassigned this task from • alexhollender_WMF to Edtadros.Jun 13 2022, 5:03 PM

@Jdlrobson for the purposes of QA: where can one check that the TOC is no longer included in print mode?

Jdlrobson updated the task description. (Show Details)Jun 13 2022, 5:10 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 19 2022, 1:31 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Find an article with a table of contents in the sidebar. Click print.

✅ AC1: There should be no table of contents in the article

Screen Recording 2022-06-18 at 6.28.45 PM.mov.gif (718×866 px, 2 MB)

Edtadros reassigned this task from Edtadros to ovasileva.Jun 19 2022, 1:32 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Find an article with a table of contents in the sidebar. Click print.

✅ AC1: There should be no table of contents in the article

Screen Recording 2022-06-18 at 6.31.22 PM.mov.gif (718×866 px, 2 MB)

Edtadros updated the task description. (Show Details)Jun 19 2022, 1:33 AM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Jun 27 2022, 10:23 AM

Looks good!

Aklapper mentioned this in T328871: TOC is not printable.Feb 6 2023, 12:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits