Page MenuHomePhabricator

[minor] MentorDashboard - textbox "Show [number of mentees]" should be aligned with pagination icons
Closed, ResolvedPublic

Description

On Special:MentorDashboard (testwiki) the visual alignment of the textbox element and the pagination label/arrows icon is not optimal.

Screen Shot 2022-08-19 at 9.56.32 AM.png (994×2 px, 234 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hello @Etonkovidova, can you please clarify the wiki the screenshot is
from? I'm asking, because I'd like to know whether this is an issue in the
non-Vue version (production wikis excluding testwiki) or in the new Vue
version (beta wikis and testwiki). If this is from the Vue version, it
should probably be a subtask of T300532.

kostajh subscribed.

Hello @Etonkovidova, can you please clarify the wiki the screenshot is
from? I'm asking, because I'd like to know whether this is an issue in the
non-Vue version (production wikis excluding testwiki) or in the new Vue
version (beta wikis and testwiki). If this is from the Vue version, it
should probably be a subtask of T300532.

Ping @Etonkovidova about the question above :)

If it's the Vue version, let's put it into current sprint and make it a subtask of T300532, as @Urbanecm_WMF suggested.

Hello @Etonkovidova, can you please clarify the wiki the screenshot is
from? I'm asking, because I'd like to know whether this is an issue in the
non-Vue version (production wikis excluding testwiki) or in the new Vue
version (beta wikis and testwiki). If this is from the Vue version, it
should probably be a subtask of T300532.

Ping @Etonkovidova about the question above :)

If it's the Vue version, let's put it into current sprint and make it a subtask of T300532, as @Urbanecm_WMF suggested.

Thanks, @kostajh and @Urbanecm_WMF! The issue was reported on testwiki (I've updated the task description - sorry for that omission). This task is now added to the current sprint and added as a sub-task to T300532.

Change 831835 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview(vue): vertically align pagination and users to show text

https://gerrit.wikimedia.org/r/831835

Change 831835 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview(vue): vertically align pagination and users to show text

https://gerrit.wikimedia.org/r/831835

Checked in betalabs - the issue is fixed:

Screen Shot 2022-09-13 at 4.04.45 PM.png (724×1 px, 84 KB)

Sgs reopened this task as Open.EditedSep 14 2022, 9:50 AM

Checked in betalabs - the issue is fixed:

Screen Shot 2022-09-13 at 4.04.45 PM.png (724×1 px, 84 KB)

Only enwiki and arwiki have the Vue version of the dashboard enabled in the beta cluster. Was this tested in one of these wikis? Looking at the "Show 10" selector in the screenshot, it belongs to the old version. The selector in the Vue version looks "framed" rather than "quiet".

Screenshot 2022-09-14 at 11.46.03.png (1×1 px, 286 KB)

Etonkovidova added a subscriber: Sergio.

Checked in betalabs - the issue is fixed:

Screen Shot 2022-09-13 at 4.04.45 PM.png (724×1 px, 84 KB)

Only enwiki and arwiki have the Vue version of the dashboard enabled in the beta cluster. Was this tested in one of these wikis? Looking at the "Show 10" selector in the screenshot, it belongs to the old version. The selector in the Vue version looks "framed" rather than "quiet".

Screenshot 2022-09-14 at 11.46.03.png (1×1 px, 286 KB)

@Sergio - you're right! When checking, I was concerned only with alignment (which is fixed for non-Vue version also). Show selector is framed on enwiki betalabs. Below is the screenshot:

Screen Shot 2022-09-14 at 12.41.15 PM.png (786×1 px, 119 KB)