Page MenuHomePhabricator

Check for mentors who have mentees assigned to them, while not being listed on Special:ManageMentors
Closed, ResolvedPublic

Description

After the deployment of the structured mentor list, some users reported cases of ex-mentors, who were manually removed from the unstructured lists before the deployment. These mentors still have assigned mentees, but they aren't listed on special:ManageMentors for their wiki.

This task aims to find these former mentors, and then to check if they have to be removed them from the mentors database.

The plan:

  1. identify communities where the issue exist
  2. draft a message and have it being translated for these languages
  3. send a message to these users, asking them to properly sign-up, with a deadline
  4. when the deadline passes, we reassign the mentees for the non-signed-up mentors.

Event Timeline

Urbanecm_WMF moved this task from Needs Discussion to Triaged on the Growth-Team board.

This is quite easy to do -- I can make a report across all of the wikis and leave it for @Trizek-WMF and communities to handle it.

Urbanecm_WMF triaged this task as Low priority.

There's a significant number of mentors who are not listed, see https://docs.google.com/spreadsheets/d/16vMJzoxF_OyxAFtTtEx70hadU8MDbFdOpeNNNUMJmAc/edit?usp=sharing.

@Trizek-WMF I feel it would be nice to do something about the mentors who are not listed, but I'm not sure what. Perhaps inform affected communities only?

@Trizek-WMF I feel it would be nice to do something about the mentors who are not listed, but I'm not sure what. Perhaps inform affected communities only?

Mentors who are "not listed" have mentees, but aren't visible on the structured mentors list, right? Are they the ones tagged as "Not a mentor" on your spreadsheet?

@Trizek-WMF I feel it would be nice to do something about the mentors who are not listed, but I'm not sure what. Perhaps inform affected communities only?

Mentors who are "not listed" have mentees, but aren't visible on the structured mentors list, right? Are they the ones tagged as "Not a mentor" on your spreadsheet?

Correct. Sorry for not making that more clear.

We discussed about this in the Growth Ambassadors meeting, and the agreement goes along the following plan:

  1. send a message to these users, asking them to properly sign-up, with a deadline
  2. when the deadline passes, then we reassign the mentees for the non-signed-up mentors.

@Urbanecm_WMF - the api call (and db query) still show that a mentor has some mentees assigned even though a mentor was removed from the list of mentor. Is there supposed to be a way to find mentees that still have un-listed mentors? Should we keep a track of mentors' status - like removed or something?

The example below from cswiki betalabs to illustrate that a mentor who was removed (manually from Special:ManageMentors or from MediaWiki:GrowthMentors.json) is still presented to mentees.

  1. ET27 (user_id=30) is a mentor and is displayed as a mentor on Special:ManageMentors
  2. One of ET27 mentees - ET73(user_id=214) logs in and sees ET27 as the mentor (CORRECT)
  3. ET13 (as an admin) removes ET27 as a mentor (this revision of MediaWiki:GrowthMentors.json shows that id=30 (ET27) was removed. Special:ManageMentors doesn't display ET27 anymore (CORRECT)
  4. After more than 24 hours, ET73(user_id=214) still sees ET27 as an assigned mentor (INCORRECT)

The api call shows ET27is still listed as a mentor with ET73 as a mentee (INCORRECT)
https://cs.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&prop=&list=growthmentormentee&formatversion=2&gemmmentor=ET27

(cswiki)> select * from growthexperiments_mentor_mentee where gemm_mentor_id=30\G
*************************** 1. row ***************************
       gemm_mentee_id: 214
     gemm_mentor_role: primary
       gemm_mentor_id: 30
gemm_mentee_is_active: 0
*************************** 2. row ***************************
       gemm_mentee_id: 345
     gemm_mentor_role: backup
       gemm_mentor_id: 30
gemm_mentee_is_active: 1
2 rows in set (0.001 sec)

The same scenario happens on testwiki wmf13.

Hi @Etonkovidova,

Thanks for the report. I've followed the instructions at test.wikipedia, and I didn't manage to reproduce this issue. First, I enrolled as a mentor via my test account. Then, I claimed two user accounts:

21:06, 21 December 2022 Martin Urbanec (test) talk contribs block claimed Martin Urbanec (public) as their mentee (previous mentor NGC 54)
21:06, 21 December 2022 Martin Urbanec (test) talk contribs block claimed Martin Urbanec (WMF) as their mentee (previous mentor Martin Urbanec (WMF))

Then, I removed my test account as a mentor via my staff account. After a couple of seconds, both my mentees were reassigned to someone else (with a message explaining the removal):

21:07, 21 December 2022 Martin Urbanec (WMF) talk contribs block set Etonkovidova as the mentor of Martin Urbanec (public) (previous mentor Martin Urbanec (test)) (Martin Urbanec (WMF) removed Martin Urbanec (test) from mentorship)
21:07, 21 December 2022 Martin Urbanec (WMF) talk contribs block set NMW03 as the mentor of Martin Urbanec (WMF) (previous mentor Martin Urbanec (test)) (Martin Urbanec (WMF) removed Martin Urbanec (test) from mentorship)

My test account now no longer has any (primary) mentees:

mysql:[email protected] [testwiki]> select * from actor where actor_name='Martin Urbanec (test)';
+----------+------------+-----------------------+
| actor_id | actor_user | actor_name            |
+----------+------------+-----------------------+
|    36210 |      35167 | Martin Urbanec (test) |
+----------+------------+-----------------------+
1 row in set (0.002 sec)
mysql:[email protected] [testwiki]> select * from growthexperiments_mentor_mentee where gemm_mentor_id=35167 and gemm_mentor_role='primary';
Empty set (0.001 sec)

mysql:[email protected] [testwiki]>

My guess is that beta cluster has or had some issues with the job queue, resulting in the reassignment not happening. Can you please try this in production, and fill a new task if you can reproduce it there as well? Thanks!

Thank you, @Urbanecm_WMF - the workflow with re-assigning users is as you described in the above comment (checked in tetswiki wmf.6. I am closing this task as Resolved since the scope of this task is completed.

The only question now is whether the case presented in T330071 is common and if the solution (https://phabricator.wikimedia.org/T330071#8632168) is ok for now.