Page MenuHomePhabricator

[Unplanned] Regression: Additional margin relating to subtitle element in Minerva
Closed, ResolvedPublicBUG REPORT

Description

Picked up by Pixel (33 failures):

This is most notable on non-existent user pages e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=User:User-0.7967016078790841-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n:

Screen Shot 2022-12-09 at 2.28.42 PM.png (321×1 px, 41 KB)

However pushes content ever so slightly on all mobile article pages:

image.png (480×320 px, 17 KB)

To rectify this, we'll need to make several extensions use the new API first.

QA Results - Beta

ACStatusDetails
1T324876#8506046

Event Timeline

Change 866655 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DiscussionTools@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866655

Change 866656 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866656

Change 866657 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use standard subtitle markup

https://gerrit.wikimedia.org/r/866657

Change 867301 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Parse API should not include #mw-content-subtitle element

https://gerrit.wikimedia.org/r/867301

Change 867301 merged by jenkins-bot:

[mediawiki/core@master] Parse API should not include #mw-content-subtitle element

https://gerrit.wikimedia.org/r/867301

Change 866655 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866655

Change 866656 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866656

Change 866657 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use standard subtitle markup

https://gerrit.wikimedia.org/r/866657

This should be fixed now so moving into QA (beta cluster only). This can skip QA in production.

Jdlrobson renamed this task from Regression: Additional margin relating to subtitle element in Minerva to [Unplanned] Regression: Additional margin relating to subtitle element in Minerva.Dec 14 2022, 6:56 PM
Jdlrobson assigned this task to Edtadros.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Mobile pages should not show any regressions on Pixel.
This may have been tested late. As of today there are no regressions showing on Pixel for mobile pages. Passing this and skipping testing in production per T324876#8468795